-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brand assets #3610
Update brand assets #3610
Conversation
Code Climate has analyzed commit c896f69 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3610 +/- ##
==========================================
- Coverage 37.50% 37.20% -0.30%
==========================================
Files 311 322 +11
Lines 8357 8717 +360
Branches 1295 1349 +54
==========================================
+ Hits 3134 3243 +109
- Misses 5074 5332 +258
+ Partials 149 142 -7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please ensure that the files are in similar pixel sizes and KB sizes? Github PRs are now finally very rich in image diff and show huge reduction in pixel sizes but increases in the KB size. Could you compress the PNGs with some compressor like https://compresspng.com/ ?
they're the same pixel size and i'll compress again |
According to the diff
|
oooops, read heights as width 😭 i don't think we need the 3000px width since svgs will be readily available and it would save on bundle size, would that be ok with you? |
Can we keep the original sizes with similar compression since the rendered versions are super convenient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for re-uploading the assets!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the assets/lodestar_icon_text_black_stroke.png
asset is missing a white stroke or it won't be legible in Github dark mode. Please if you can add a simple white stroke in similar fashion to the original asset
Motivation
updating the assets to make experience of lodestar more awesome. kept file names the same so hopefully no breaking changes.