-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move shufflings code together into seed util #3710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
g11tech,
mpetrunic,
twoeths and
wemeetagain
as code owners
February 7, 2022 05:00
dapplion
force-pushed
the
dapplion/computeProposers
branch
from
February 7, 2022 05:18
faee037
to
d4c9912
Compare
Codecov Report
@@ Coverage Diff @@
## master #3710 +/- ##
=======================================
Coverage 37.17% 37.17%
=======================================
Files 322 322
Lines 8723 8723
Branches 1350 1350
=======================================
Hits 3243 3243
Misses 5338 5338
Partials 142 142 |
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now functions to compute proposer and attester shufflings were splited in multiple files. Move together into seed
Description