-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check, validate and skip if we got any deposit events already present in DB #3716
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3716 +/- ##
==========================================
- Coverage 37.16% 37.14% -0.02%
==========================================
Files 321 321
Lines 8712 8722 +10
Branches 1350 1352 +2
==========================================
+ Hits 3238 3240 +2
- Misses 5332 5340 +8
Partials 142 142 |
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really tidy now! Thanks for the logic re-write and the comments ❤️
Motivation
Previously, we were checking and throwing error if we got any deposit events which were already in DB. however a "reset" in remote EL/eth1 ' head can cause our tracker to import events which are already in DB causing our tracker to throw error and preventing the node from proposing.
This PR fixes that behavior by checking and validating if we get events which are already in DB. If the event doesn't match up it throws the DUPLICATE_DISTINCT_LOG error as it means either the DB is corrupted or the EL/eth1 did a reorg, both catastrophic.
Closes #3674
Steps to test or reproduce