Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup amphora merge testnet scripts/configs #3741

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Cleanup amphora merge testnet scripts/configs #3741

merged 1 commit into from
Feb 10, 2022

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Feb 10, 2022

Motivation

Cleanup amphora merge testnet scripts/configs as they are now outdated.
Kintsugi config dir will also get renamed/updated to Kiln in the Kiln impl PR: #3736

@codecov
Copy link

codecov bot commented Feb 10, 2022 •
edited
Loading

Codecov Report

Merging #3741 (b2c1a86) into master (cd2edf2) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3741      +/-   ##
==========================================
- Coverage   37.10%   36.53%   -0.58%     
==========================================
  Files         320      320              
  Lines        8724     8976     +252     
  Branches     1356     1435      +79     
==========================================
+ Hits         3237     3279      +42     
- Misses       5345     5555     +210     
  Partials      142      142

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: a3b0ac1 Previous: f9cf7a3 Ratio
BeaconState.hashTreeRoot - No change 633.00 ns/op 560.00 ns/op 1.13
BeaconState.hashTreeRoot - 1 full validator 147.23 us/op 132.89 us/op 1.11
BeaconState.hashTreeRoot - 32 full validator 2.2355 ms/op 2.0330 ms/op 1.10
BeaconState.hashTreeRoot - 512 full validator 30.394 ms/op 27.197 ms/op 1.12
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 149.14 us/op 136.50 us/op 1.09
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.4524 ms/op 2.2556 ms/op 1.09
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 33.339 ms/op 42.782 ms/op 0.78
BeaconState.hashTreeRoot - 1 balances 108.69 us/op 98.674 us/op 1.10
BeaconState.hashTreeRoot - 32 balances 918.86 us/op 803.44 us/op 1.14
BeaconState.hashTreeRoot - 512 balances 8.8818 ms/op 7.7680 ms/op 1.14
BeaconState.hashTreeRoot - 250000 balances 165.87 ms/op 150.06 ms/op 1.11
processSlot - 1 slots 53.959 us/op 63.453 us/op 0.85
processSlot - 32 slots 3.2734 ms/op 3.0860 ms/op 1.06
getCommitteeAssignments - req 1 vs - 250000 vc 6.1413 ms/op 5.9445 ms/op 1.03
getCommitteeAssignments - req 100 vs - 250000 vc 8.4502 ms/op 8.4874 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 9.1550 ms/op 8.3745 ms/op 1.09
computeProposers - vc 250000 24.635 ms/op 22.236 ms/op 1.11
computeEpochShuffling - vc 250000 219.31 ms/op 200.54 ms/op 1.09
getNextSyncCommittee - vc 250000 399.69 ms/op 356.27 ms/op 1.12
altair processAttestation - 250000 vs - 7PWei normalcase 48.262 ms/op 38.030 ms/op 1.27
altair processAttestation - 250000 vs - 7PWei worstcase 41.294 ms/op 37.168 ms/op 1.11
altair processAttestation - setStatus - 1/6 committees join 14.249 ms/op 10.483 ms/op 1.36
altair processAttestation - setStatus - 1/3 committees join 28.457 ms/op 22.087 ms/op 1.29
altair processAttestation - setStatus - 1/2 committees join 43.961 ms/op 33.486 ms/op 1.31
altair processAttestation - setStatus - 2/3 committees join 54.792 ms/op 46.535 ms/op 1.18
altair processAttestation - setStatus - 4/5 committees join 62.650 ms/op 55.827 ms/op 1.12
altair processAttestation - setStatus - 100% committees join 78.640 ms/op 60.079 ms/op 1.31
altair processAttestation - updateEpochParticipants - 1/6 committees join 15.640 ms/op 10.432 ms/op 1.50
altair processAttestation - updateEpochParticipants - 1/3 committees join 23.972 ms/op 21.962 ms/op 1.09
altair processAttestation - updateEpochParticipants - 1/2 committees join 27.440 ms/op 24.772 ms/op 1.11
altair processAttestation - updateEpochParticipants - 2/3 committees join 24.379 ms/op 22.057 ms/op 1.11
altair processAttestation - updateEpochParticipants - 4/5 committees join 25.607 ms/op 23.625 ms/op 1.08
altair processAttestation - updateEpochParticipants - 100% committees join 31.579 ms/op 29.670 ms/op 1.06
altair processAttestation - updateAllStatus 22.185 ms/op 20.368 ms/op 1.09
altair processBlock - 250000 vs - 7PWei normalcase 39.573 ms/op 34.005 ms/op 1.16
altair processBlock - 250000 vs - 7PWei worstcase 120.00 ms/op 108.62 ms/op 1.10
altair processEpoch - mainnet_e81889 1.2443 s/op 1.0825 s/op 1.15
mainnet_e81889 - altair beforeProcessEpoch 310.65 ms/op 328.46 ms/op 0.95
mainnet_e81889 - altair processJustificationAndFinalization 73.809 us/op 105.13 us/op 0.70
mainnet_e81889 - altair processInactivityUpdates 21.762 ms/op 19.112 ms/op 1.14
mainnet_e81889 - altair processRewardsAndPenalties 312.96 ms/op 282.95 ms/op 1.11
mainnet_e81889 - altair processRegistryUpdates 10.586 us/op 11.155 us/op 0.95
mainnet_e81889 - altair processSlashings 2.9760 us/op 3.1440 us/op 0.95
mainnet_e81889 - altair processEth1DataReset 2.8340 us/op 2.8310 us/op 1.00
mainnet_e81889 - altair processEffectiveBalanceUpdates 7.7906 ms/op 7.3488 ms/op 1.06
mainnet_e81889 - altair processSlashingsReset 17.562 us/op 13.891 us/op 1.26
mainnet_e81889 - altair processRandaoMixesReset 22.441 us/op 18.727 us/op 1.20
mainnet_e81889 - altair processHistoricalRootsUpdate 4.0140 us/op 3.9350 us/op 1.02
mainnet_e81889 - altair processParticipationFlagUpdates 98.436 ms/op 76.235 ms/op 1.29
mainnet_e81889 - altair processSyncCommitteeUpdates 2.9940 us/op 2.8680 us/op 1.04
mainnet_e81889 - altair afterProcessEpoch 300.78 ms/op 252.48 ms/op 1.19
altair processInactivityUpdates - 250000 normalcase 85.280 ms/op 69.217 ms/op 1.23
altair processInactivityUpdates - 250000 worstcase 79.848 ms/op 101.70 ms/op 0.79
altair processParticipationFlagUpdates - 250000 anycase 80.711 ms/op 74.065 ms/op 1.09
altair processRewardsAndPenalties - 250000 normalcase 243.72 ms/op 224.06 ms/op 1.09
altair processRewardsAndPenalties - 250000 worstcase 271.66 ms/op 242.85 ms/op 1.12
altair processSyncCommitteeUpdates - 250000 413.96 ms/op 379.25 ms/op 1.09
Tree 40 250000 create 706.67 ms/op 651.30 ms/op 1.08
Tree 40 250000 get(125000) 375.88 ns/op 350.26 ns/op 1.07
Tree 40 250000 set(125000) 2.2728 us/op 2.1164 us/op 1.07
Tree 40 250000 toArray() 43.018 ms/op 39.189 ms/op 1.10
Tree 40 250000 iterate all - toArray() + loop 43.200 ms/op 39.121 ms/op 1.10
Tree 40 250000 iterate all - get(i) 139.13 ms/op 144.66 ms/op 0.96
MutableVector 250000 create 26.370 ms/op 25.249 ms/op 1.04
MutableVector 250000 get(125000) 15.120 ns/op 14.266 ns/op 1.06
MutableVector 250000 set(125000) 575.28 ns/op 493.12 ns/op 1.17
MutableVector 250000 toArray() 9.5845 ms/op 9.1557 ms/op 1.05
MutableVector 250000 iterate all - toArray() + loop 9.7058 ms/op 9.1090 ms/op 1.07
MutableVector 250000 iterate all - get(i) 3.8951 ms/op 3.9723 ms/op 0.98
Array 250000 create 5.8191 ms/op 5.3922 ms/op 1.08
Array 250000 clone - spread 2.5594 ms/op 2.3526 ms/op 1.09
Array 250000 get(125000) 1.1820 ns/op 1.1040 ns/op 1.07
Array 250000 set(125000) 1.1680 ns/op 1.1100 ns/op 1.05
Array 250000 iterate all - loop 192.28 us/op 187.18 us/op 1.03
effectiveBalanceIncrements clone Uint8Array 300000 73.169 us/op 75.322 us/op 0.97
effectiveBalanceIncrements clone MutableVector 300000 757.00 ns/op 731.00 ns/op 1.04
effectiveBalanceIncrements rw all Uint8Array 300000 348.38 us/op 335.15 us/op 1.04
effectiveBalanceIncrements rw all MutableVector 300000 192.14 ms/op 181.63 ms/op 1.06
aggregationBits - 2048 els - readonlyValues 208.91 us/op 188.85 us/op 1.11
aggregationBits - 2048 els - zipIndexesInBitList 38.998 us/op 34.812 us/op 1.12
regular array get 100000 times 78.310 us/op 73.628 us/op 1.06
wrappedArray get 100000 times 77.846 us/op 70.440 us/op 1.11
arrayWithProxy get 100000 times 35.067 ms/op 36.290 ms/op 0.97
ssz.Root.equals 1.2390 us/op 1.0810 us/op 1.15
ssz.Root.equals with valueOf() 1.5270 us/op 1.2780 us/op 1.19
byteArrayEquals with valueOf() 1.4740 us/op 1.2890 us/op 1.14
phase0 processBlock - 250000 vs - 7PWei normalcase 9.0075 ms/op 8.0970 ms/op 1.11
phase0 processBlock - 250000 vs - 7PWei worstcase 82.576 ms/op 78.492 ms/op 1.05
phase0 afterProcessEpoch - 250000 vs - 7PWei 242.03 ms/op 221.29 ms/op 1.09
phase0 beforeProcessEpoch - 250000 vs - 7PWei 650.54 ms/op 622.01 ms/op 1.05
phase0 processEpoch - mainnet_e58758 1.0205 s/op 909.45 ms/op 1.12
mainnet_e58758 - phase0 beforeProcessEpoch 514.62 ms/op 427.87 ms/op 1.20
mainnet_e58758 - phase0 processJustificationAndFinalization 58.007 us/op 107.13 us/op 0.54
mainnet_e58758 - phase0 processRewardsAndPenalties 172.10 ms/op 134.25 ms/op 1.28
mainnet_e58758 - phase0 processRegistryUpdates 64.440 us/op 76.037 us/op 0.85
mainnet_e58758 - phase0 processSlashings 3.7520 us/op 4.5790 us/op 0.82
mainnet_e58758 - phase0 processEth1DataReset 3.0390 us/op 4.5860 us/op 0.66
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 6.3318 ms/op 5.9615 ms/op 1.06
mainnet_e58758 - phase0 processSlashingsReset 17.237 us/op 21.143 us/op 0.82
mainnet_e58758 - phase0 processRandaoMixesReset 22.606 us/op 30.115 us/op 0.75
mainnet_e58758 - phase0 processHistoricalRootsUpdate 4.5210 us/op 5.4610 us/op 0.83
mainnet_e58758 - phase0 processParticipationRecordUpdates 19.108 us/op 12.798 us/op 1.49
mainnet_e58758 - phase0 afterProcessEpoch 217.24 ms/op 198.40 ms/op 1.09
phase0 processEffectiveBalanceUpdates - 250000 normalcase 7.1354 ms/op 6.9364 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 7.7602 ms/op 7.0596 ms/op 1.10
phase0 processRegistryUpdates - 250000 normalcase 69.744 us/op 43.173 us/op 1.62
phase0 processRegistryUpdates - 250000 badcase_full_deposits 3.1441 ms/op 3.0512 ms/op 1.03
phase0 processRegistryUpdates - 250000 worstcase 0.5 1.6548 s/op 1.7502 s/op 0.95
phase0 getAttestationDeltas - 250000 normalcase 81.436 ms/op 70.129 ms/op 1.16
phase0 getAttestationDeltas - 250000 worstcase 81.403 ms/op 72.128 ms/op 1.13
phase0 processSlashings - 250000 worstcase 38.409 ms/op 33.033 ms/op 1.16
shuffle list - 16384 els 14.976 ms/op 13.996 ms/op 1.07
shuffle list - 250000 els 216.46 ms/op 197.74 ms/op 1.09
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 511.32 us/op 465.16 us/op 1.10
pass gossip attestations to forkchoice per slot 21.125 ms/op 17.627 ms/op 1.20
computeDeltas 3.5924 ms/op 3.5216 ms/op 1.02
computeProposerBoostScoreFromBalances 580.84 us/op 561.73 us/op 1.03
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.9537 ms/op 2.1771 ms/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 851.53 us/op 740.11 us/op 1.15
BLS verify - blst-native 2.1868 ms/op 2.0812 ms/op 1.05
BLS verifyMultipleSignatures 3 - blst-native 4.4397 ms/op 4.2501 ms/op 1.04
BLS verifyMultipleSignatures 8 - blst-native 9.5543 ms/op 9.2078 ms/op 1.04
BLS verifyMultipleSignatures 32 - blst-native 34.399 ms/op 33.526 ms/op 1.03
BLS aggregatePubkeys 32 - blst-native 45.665 us/op 44.470 us/op 1.03
BLS aggregatePubkeys 128 - blst-native 179.26 us/op 173.55 us/op 1.03
getAttestationsForBlock 75.580 ms/op 67.598 ms/op 1.12
CheckpointStateCache - add get delete 21.369 us/op 19.472 us/op 1.10
validate gossip signedAggregateAndProof - struct 5.2478 ms/op 4.8635 ms/op 1.08
validate gossip signedAggregateAndProof - treeBacked 5.2278 ms/op 5.1259 ms/op 1.02
validate gossip attestation - struct 2.4054 ms/op 2.3520 ms/op 1.02
validate gossip attestation - treeBacked 2.4410 ms/op 2.3345 ms/op 1.05
pickEth1Vote - no votes 9.8469 ms/op 9.5089 ms/op 1.04
pickEth1Vote - max votes 56.354 ms/op 52.191 ms/op 1.08
pickEth1Vote - Eth1Data hashTreeRoot value x2048 28.537 ms/op 26.510 ms/op 1.08
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 10.843 ms/op 10.245 ms/op 1.06
pickEth1Vote - Eth1Data fastSerialize value x2048 6.1080 ms/op 5.4651 ms/op 1.12
pickEth1Vote - Eth1Data fastSerialize tree x2048 24.417 ms/op 23.667 ms/op 1.03
bytes32 toHexString 1.8190 us/op 1.7280 us/op 1.05
bytes32 Buffer.toString(hex) 781.00 ns/op 788.00 ns/op 0.99
bytes32 Buffer.toString(hex) from Uint8Array 987.00 ns/op 1.0220 us/op 0.97
bytes32 Buffer.toString(hex) + 0x 765.00 ns/op 767.00 ns/op 1.00
Object access 1 prop 0.35800 ns/op 0.34000 ns/op 1.05
Map access 1 prop 0.31400 ns/op 0.30900 ns/op 1.02
Object get x1000 20.342 ns/op 19.890 ns/op 1.02
Map get x1000 1.0930 ns/op 1.0760 ns/op 1.02
Object set x1000 118.69 ns/op 113.25 ns/op 1.05
Map set x1000 71.571 ns/op 68.057 ns/op 1.05
Return object 10000 times 0.42800 ns/op 0.41160 ns/op 1.04
Throw Error 10000 times 7.0878 us/op 6.5686 us/op 1.08
enrSubnets - fastDeserialize 64 bits 1.4260 us/op 1.2840 us/op 1.11
enrSubnets - ssz BitVector 64 bits 19.211 us/op 17.900 us/op 1.07
enrSubnets - fastDeserialize 4 bits 499.00 ns/op 465.00 ns/op 1.07
enrSubnets - ssz BitVector 4 bits 3.2570 us/op 3.1730 us/op 1.03
RateTracker 1000000 limit, 1 obj count per request 209.15 ns/op 197.19 ns/op 1.06
RateTracker 1000000 limit, 2 obj count per request 151.38 ns/op 144.25 ns/op 1.05
RateTracker 1000000 limit, 4 obj count per request 122.32 ns/op 117.59 ns/op 1.04
RateTracker 1000000 limit, 8 obj count per request 111.17 ns/op 108.51 ns/op 1.02
RateTracker with prune 4.1040 us/op 4.0710 us/op 1.01

by benchmarkbot/action

@dapplion dapplion merged commit 18df0a6 into master Feb 10, 2022
@dapplion dapplion deleted the g11tech/cleanupamphora branch February 10, 2022 14:09
@snyk-bot snyk-bot mentioned this pull request Nov 19, 2022
Closed
@nazarhussain nazarhussain mentioned this pull request Nov 22, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@wemeetagain wemeetagain Awaiting requested review from wemeetagain

@twoeths twoeths Awaiting requested review from twoeths

@philknows philknows Awaiting requested review from philknows

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g11tech @dapplion