Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call deliverMessage before gossip queue #3812

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Call deliverMessage before gossip queue #3812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/lodestar/src/network/gossip/gossipsub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,11 @@ export class Eth2Gossipsub extends Gossipsub {
*/
async validate(message: InMessage): Promise<void> {
try {
// Resolve IWANT promise before sending message to the queue. Attestations and aggregates can remain in the
// validation queue for > 1 min. Metrics show that peers are severly penalized with P7 due to broken promises,
// which they fullfil but _publish() is not called in time.
await this.gossipTracer.deliverMessage(message);

// messages must have a single topicID
const topicStr = Array.isArray(message.topicIDs) ? message.topicIDs[0] : undefined;

Expand Down