-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing eth2 mentions in documentation and fix links #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philknows
requested review from
wemeetagain,
twoeths,
dapplion and
g11tech
as code owners
March 11, 2022 06:24
Codecov Report
@@ Coverage Diff @@
## master #3848 +/- ##
=======================================
Coverage 36.12% 36.12%
=======================================
Files 325 325
Lines 9041 9041
Branches 1419 1419
=======================================
Hits 3266 3266
Misses 5632 5632
Partials 143 143 |
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
approved these changes
Mar 11, 2022
wemeetagain
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to update the documentation with Eth Consensus nomenclature and update minor non-engineering mentions of eth2. Fixes reference links to the old ethereum/eth2.0-specs to ethereum/consensus-specs and ethereum/beacon-APIs. Some are left behind due to the naming of certain functions and variables which is not covered with this PR. Also updates some documentation such as updating badges, including our minimum requirement of node 16.x
Description
Addresses issue and resolves #3626.