Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare routeId in HTTP client metrics #4151

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Declare routeId in HTTP client metrics #4151

merged 1 commit into from
Jun 13, 2022

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Jun 13, 2022 •
edited
Loading

Motivation

Regression introduced probably by #4127 which did not add the labelNames property in metrics definition. Unfortunately, there no safety guard now to ensure we don't make this mistakes.

Description

Declare routeId in HTTP client metrics

Closes #4147

@dapplion dapplion requested a review from a team as a code owner June 13, 2022 13:29
g11tech
g11tech approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@g11tech g11tech enabled auto-merge (squash) June 13, 2022 13:31
@g11tech g11tech merged commit 32e7ce3 into unstable Jun 13, 2022
@g11tech g11tech deleted the dapplion/declare-label-routeId branch June 13, 2022 13:50
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 7789dc4 Previous: 43efd05 Ratio
altair processAttestation - 250000 vs - 7PWei normalcase 4.4863 ms/op 5.0462 ms/op 0.89
altair processAttestation - 250000 vs - 7PWei worstcase 7.5408 ms/op 7.9055 ms/op 0.95
altair processAttestation - setStatus - 1/6 committees join 237.18 us/op 284.97 us/op 0.83
altair processAttestation - setStatus - 1/3 committees join 433.76 us/op 524.83 us/op 0.83
altair processAttestation - setStatus - 1/2 committees join 619.37 us/op 681.27 us/op 0.91
altair processAttestation - setStatus - 2/3 committees join 813.53 us/op 930.92 us/op 0.87
altair processAttestation - setStatus - 4/5 committees join 1.1391 ms/op 1.3354 ms/op 0.85
altair processAttestation - setStatus - 100% committees join 1.4060 ms/op 1.5722 ms/op 0.89
altair processBlock - 250000 vs - 7PWei normalcase 29.555 ms/op 33.677 ms/op 0.88
altair processBlock - 250000 vs - 7PWei normalcase hashState 39.781 ms/op 51.624 ms/op 0.77
altair processBlock - 250000 vs - 7PWei worstcase 104.13 ms/op 94.866 ms/op 1.10
altair processBlock - 250000 vs - 7PWei worstcase hashState 130.34 ms/op 128.87 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei normalcase 4.3837 ms/op 4.6854 ms/op 0.94
phase0 processBlock - 250000 vs - 7PWei worstcase 65.438 ms/op 60.808 ms/op 1.08
altair processEth1Data - 250000 vs - 7PWei normalcase 952.85 us/op 902.60 us/op 1.06
Tree 40 250000 create 1.1047 s/op 938.99 ms/op 1.18
Tree 40 250000 get(125000) 336.32 ns/op 357.50 ns/op 0.94
Tree 40 250000 set(125000) 3.3388 us/op 3.2946 us/op 1.01
Tree 40 250000 toArray() 35.173 ms/op 38.996 ms/op 0.90
Tree 40 250000 iterate all - toArray() + loop 36.280 ms/op 38.160 ms/op 0.95
Tree 40 250000 iterate all - get(i) 136.82 ms/op 147.16 ms/op 0.93
MutableVector 250000 create 16.969 ms/op 17.700 ms/op 0.96
MutableVector 250000 get(125000) 14.857 ns/op 14.903 ns/op 1.00
MutableVector 250000 set(125000) 853.12 ns/op 903.84 ns/op 0.94
MutableVector 250000 toArray() 7.4645 ms/op 7.7834 ms/op 0.96
MutableVector 250000 iterate all - toArray() + loop 7.7313 ms/op 7.5632 ms/op 1.02
MutableVector 250000 iterate all - get(i) 3.5025 ms/op 3.6599 ms/op 0.96
Array 250000 create 7.1648 ms/op 6.9231 ms/op 1.03
Array 250000 clone - spread 3.9932 ms/op 4.0519 ms/op 0.99
Array 250000 get(125000) 1.7220 ns/op 1.7960 ns/op 0.96
Array 250000 set(125000) 1.7720 ns/op 1.8150 ns/op 0.98
Array 250000 iterate all - loop 149.39 us/op 160.22 us/op 0.93
effectiveBalanceIncrements clone Uint8Array 300000 116.59 us/op 120.57 us/op 0.97
effectiveBalanceIncrements clone MutableVector 300000 1.2580 us/op 1.4240 us/op 0.88
effectiveBalanceIncrements rw all Uint8Array 300000 387.53 us/op 326.67 us/op 1.19
effectiveBalanceIncrements rw all MutableVector 300000 271.94 ms/op 301.63 ms/op 0.90
phase0 afterProcessEpoch - 250000 vs - 7PWei 229.55 ms/op 225.68 ms/op 1.02
phase0 beforeProcessEpoch - 250000 vs - 7PWei 79.094 ms/op 95.302 ms/op 0.83
altair processEpoch - mainnet_e81889 664.47 ms/op 695.44 ms/op 0.96
mainnet_e81889 - altair beforeProcessEpoch 171.46 ms/op 124.23 ms/op 1.38
mainnet_e81889 - altair processJustificationAndFinalization 71.615 us/op 66.067 us/op 1.08
mainnet_e81889 - altair processInactivityUpdates 12.834 ms/op 12.710 ms/op 1.01
mainnet_e81889 - altair processRewardsAndPenalties 101.58 ms/op 190.44 ms/op 0.53
mainnet_e81889 - altair processRegistryUpdates 15.075 us/op 15.780 us/op 0.96
mainnet_e81889 - altair processSlashings 3.5530 us/op 3.0610 us/op 1.16
mainnet_e81889 - altair processEth1DataReset 3.9900 us/op 3.5940 us/op 1.11
mainnet_e81889 - altair processEffectiveBalanceUpdates 3.3088 ms/op 3.2787 ms/op 1.01
mainnet_e81889 - altair processSlashingsReset 32.373 us/op 31.536 us/op 1.03
mainnet_e81889 - altair processRandaoMixesReset 28.103 us/op 26.482 us/op 1.06
mainnet_e81889 - altair processHistoricalRootsUpdate 4.8070 us/op 3.9880 us/op 1.21
mainnet_e81889 - altair processParticipationFlagUpdates 18.523 us/op 12.157 us/op 1.52
mainnet_e81889 - altair processSyncCommitteeUpdates 3.8280 us/op 3.5450 us/op 1.08
mainnet_e81889 - altair afterProcessEpoch 226.84 ms/op 241.58 ms/op 0.94
phase0 processEpoch - mainnet_e58758 731.96 ms/op 651.92 ms/op 1.12
mainnet_e58758 - phase0 beforeProcessEpoch 252.72 ms/op 287.99 ms/op 0.88
mainnet_e58758 - phase0 processJustificationAndFinalization 64.806 us/op 61.139 us/op 1.06
mainnet_e58758 - phase0 processRewardsAndPenalties 86.235 ms/op 159.55 ms/op 0.54
mainnet_e58758 - phase0 processRegistryUpdates 34.094 us/op 29.990 us/op 1.14
mainnet_e58758 - phase0 processSlashings 3.5200 us/op 3.2080 us/op 1.10
mainnet_e58758 - phase0 processEth1DataReset 3.4230 us/op 3.3310 us/op 1.03
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.6462 ms/op 2.1813 ms/op 1.21
mainnet_e58758 - phase0 processSlashingsReset 17.696 us/op 16.664 us/op 1.06
mainnet_e58758 - phase0 processRandaoMixesReset 28.606 us/op 26.286 us/op 1.09
mainnet_e58758 - phase0 processHistoricalRootsUpdate 4.3260 us/op 3.9980 us/op 1.08
mainnet_e58758 - phase0 processParticipationRecordUpdates 25.574 us/op 21.122 us/op 1.21
mainnet_e58758 - phase0 afterProcessEpoch 185.82 ms/op 190.28 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.4359 ms/op 2.6639 ms/op 0.91
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.1025 ms/op 2.9445 ms/op 1.05
altair processInactivityUpdates - 250000 normalcase 34.648 ms/op 38.266 ms/op 0.91
altair processInactivityUpdates - 250000 worstcase 34.805 ms/op 37.084 ms/op 0.94
phase0 processRegistryUpdates - 250000 normalcase 29.882 us/op 26.358 us/op 1.13
phase0 processRegistryUpdates - 250000 badcase_full_deposits 517.08 us/op 587.05 us/op 0.88
phase0 processRegistryUpdates - 250000 worstcase 0.5 240.79 ms/op 265.12 ms/op 0.91
altair processRewardsAndPenalties - 250000 normalcase 141.38 ms/op 102.67 ms/op 1.38
altair processRewardsAndPenalties - 250000 worstcase 91.599 ms/op 98.434 ms/op 0.93
phase0 getAttestationDeltas - 250000 normalcase 16.334 ms/op 15.481 ms/op 1.06
phase0 getAttestationDeltas - 250000 worstcase 15.126 ms/op 16.151 ms/op 0.94
phase0 processSlashings - 250000 worstcase 6.7925 ms/op 7.3798 ms/op 0.92
altair processSyncCommitteeUpdates - 250000 360.41 ms/op 388.82 ms/op 0.93
BeaconState.hashTreeRoot - No change 730.00 ns/op 826.00 ns/op 0.88
BeaconState.hashTreeRoot - 1 full validator 86.298 us/op 86.830 us/op 0.99
BeaconState.hashTreeRoot - 32 full validator 885.81 us/op 823.31 us/op 1.08
BeaconState.hashTreeRoot - 512 full validator 8.1365 ms/op 8.9849 ms/op 0.91
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 111.97 us/op 112.57 us/op 0.99
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3983 ms/op 1.6402 ms/op 0.85
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 20.226 ms/op 22.390 ms/op 0.90
BeaconState.hashTreeRoot - 1 balances 83.490 us/op 86.814 us/op 0.96
BeaconState.hashTreeRoot - 32 balances 748.83 us/op 808.16 us/op 0.93
BeaconState.hashTreeRoot - 512 balances 6.7344 ms/op 6.8309 ms/op 0.99
BeaconState.hashTreeRoot - 250000 balances 122.79 ms/op 115.63 ms/op 1.06
aggregationBits - 2048 els - zipIndexesInBitList 35.160 us/op 35.681 us/op 0.99
regular array get 100000 times 59.020 us/op 63.849 us/op 0.92
wrappedArray get 100000 times 58.924 us/op 65.095 us/op 0.91
arrayWithProxy get 100000 times 41.829 ms/op 39.725 ms/op 1.05
ssz.Root.equals 603.00 ns/op 621.00 ns/op 0.97
byteArrayEquals 599.00 ns/op 632.00 ns/op 0.95
shuffle list - 16384 els 12.589 ms/op 13.839 ms/op 0.91
shuffle list - 250000 els 183.21 ms/op 201.70 ms/op 0.91
processSlot - 1 slots 17.478 us/op 19.142 us/op 0.91
processSlot - 32 slots 2.4517 ms/op 2.5769 ms/op 0.95
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 437.93 us/op 886.96 us/op 0.49
getCommitteeAssignments - req 1 vs - 250000 vc 5.6219 ms/op 5.8542 ms/op 0.96
getCommitteeAssignments - req 100 vs - 250000 vc 8.1113 ms/op 8.4543 ms/op 0.96
getCommitteeAssignments - req 1000 vs - 250000 vc 8.6199 ms/op 9.3677 ms/op 0.92
computeProposers - vc 250000 22.998 ms/op 24.312 ms/op 0.95
computeEpochShuffling - vc 250000 184.14 ms/op 208.69 ms/op 0.88
getNextSyncCommittee - vc 250000 345.94 ms/op 390.50 ms/op 0.89
pass gossip attestations to forkchoice per slot 3.7467 ms/op 4.2169 ms/op 0.89
computeDeltas 4.3079 ms/op 4.6840 ms/op 0.92
computeProposerBoostScoreFromBalances 903.76 us/op 1.0110 ms/op 0.89
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.7140 ms/op 2.7540 ms/op 0.99
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 99.519 us/op 112.41 us/op 0.89
BLS verify - blst-native 2.7571 ms/op 2.4266 ms/op 1.14
BLS verifyMultipleSignatures 3 - blst-native 5.5961 ms/op 5.1138 ms/op 1.09
BLS verifyMultipleSignatures 8 - blst-native 12.234 ms/op 11.029 ms/op 1.11
BLS verifyMultipleSignatures 32 - blst-native 44.733 ms/op 39.743 ms/op 1.13
BLS aggregatePubkeys 32 - blst-native 60.317 us/op 53.793 us/op 1.12
BLS aggregatePubkeys 128 - blst-native 234.60 us/op 206.66 us/op 1.14
getAttestationsForBlock 72.276 ms/op 84.873 ms/op 0.85
isKnown best case - 1 super set check 544.00 ns/op 623.00 ns/op 0.87
isKnown normal case - 2 super set checks 514.00 ns/op 601.00 ns/op 0.86
isKnown worse case - 16 super set checks 518.00 ns/op 570.00 ns/op 0.91
CheckpointStateCache - add get delete 14.887 us/op 15.072 us/op 0.99
validate gossip signedAggregateAndProof - struct 6.3747 ms/op 5.5695 ms/op 1.14
validate gossip attestation - struct 3.0160 ms/op 2.7780 ms/op 1.09
altair verifyImport mainnet_s3766816:31 8.7221 s/op 8.2405 s/op 1.06
pickEth1Vote - no votes 2.5552 ms/op 2.6679 ms/op 0.96
pickEth1Vote - max votes 29.969 ms/op 31.245 ms/op 0.96
pickEth1Vote - Eth1Data hashTreeRoot value x2048 16.087 ms/op 16.750 ms/op 0.96
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 25.690 ms/op 27.763 ms/op 0.93
pickEth1Vote - Eth1Data fastSerialize value x2048 1.8921 ms/op 1.9608 ms/op 0.96
pickEth1Vote - Eth1Data fastSerialize tree x2048 21.322 ms/op 22.179 ms/op 0.96
bytes32 toHexString 1.4180 us/op 1.3970 us/op 1.02
bytes32 Buffer.toString(hex) 875.00 ns/op 939.00 ns/op 0.93
bytes32 Buffer.toString(hex) from Uint8Array 1.1550 us/op 1.3010 us/op 0.89
bytes32 Buffer.toString(hex) + 0x 884.00 ns/op 885.00 ns/op 1.00
Object access 1 prop 0.56400 ns/op 0.48400 ns/op 1.17
Map access 1 prop 0.46600 ns/op 0.40600 ns/op 1.15
Object get x1000 17.675 ns/op 18.125 ns/op 0.98
Map get x1000 1.0970 ns/op 1.1000 ns/op 1.00
Object set x1000 124.78 ns/op 125.25 ns/op 1.00
Map set x1000 87.243 ns/op 88.360 ns/op 0.99
Return object 10000 times 0.43890 ns/op 0.46020 ns/op 0.95
Throw Error 10000 times 7.3863 us/op 7.8272 us/op 0.94
enrSubnets - fastDeserialize 64 bits 3.4430 us/op 3.4200 us/op 1.01
enrSubnets - ssz BitVector 64 bits 982.00 ns/op 988.00 ns/op 0.99
enrSubnets - fastDeserialize 4 bits 512.00 ns/op 472.00 ns/op 1.08
enrSubnets - ssz BitVector 4 bits 990.00 ns/op 942.00 ns/op 1.05
prioritizePeers score -10:0 att 32-0.1 sync 2-0 117.62 us/op 131.88 us/op 0.89
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 155.83 us/op 174.81 us/op 0.89
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 292.87 us/op 301.91 us/op 0.97
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 614.53 us/op 668.30 us/op 0.92
prioritizePeers score 0:0 att 64-1 sync 4-1 639.31 us/op 624.15 us/op 1.02
RateTracker 1000000 limit, 1 obj count per request 218.42 ns/op 227.58 ns/op 0.96
RateTracker 1000000 limit, 2 obj count per request 165.46 ns/op 174.58 ns/op 0.95
RateTracker 1000000 limit, 4 obj count per request 139.04 ns/op 144.35 ns/op 0.96
RateTracker 1000000 limit, 8 obj count per request 123.11 ns/op 122.75 ns/op 1.00
RateTracker with prune 6.0330 us/op 5.4470 us/op 1.11
array of 16000 items push then shift 5.3935 us/op 6.0133 us/op 0.90
LinkedList of 16000 items push then shift 30.750 ns/op 30.611 ns/op 1.00
array of 16000 items push then pop 277.83 ns/op 286.49 ns/op 0.97
LinkedList of 16000 items push then pop 24.685 ns/op 25.520 ns/op 0.97
array of 24000 items push then shift 8.3153 us/op 9.2593 us/op 0.90
LinkedList of 24000 items push then shift 28.896 ns/op 31.581 ns/op 0.91
array of 24000 items push then pop 226.69 ns/op 257.42 ns/op 0.88
LinkedList of 24000 items push then pop 26.665 ns/op 25.719 ns/op 1.04
intersect bitArray bitLen 8 12.726 ns/op 13.193 ns/op 0.96
intersect array and set length 8 207.04 ns/op 204.65 ns/op 1.01
intersect bitArray bitLen 128 73.147 ns/op 79.610 ns/op 0.92
intersect array and set length 128 2.5972 us/op 2.5924 us/op 1.00

by benchmarkbot/action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error updating eth1 chain cache unknown metrics label "routeId"
2 participants
@dapplion @g11tech