Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delete-tag from rollback in publish workflows #4218

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

wemeetagain
Copy link
Member

Motivation

In lodestar, tags should only be modified by humans as ways to trigger CI.
Deleting tags is considered harmful.

@wemeetagain wemeetagain requested a review from a team as a code owner June 28, 2022 19:13
@wemeetagain wemeetagain enabled auto-merge (squash) June 28, 2022 19:26
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 4f7afbc Previous: 7c5aa21 Ratio
altair processAttestation - 250000 vs - 7PWei normalcase 3.8273 ms/op 4.1483 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei worstcase 6.1476 ms/op 7.4266 ms/op 0.83
altair processAttestation - setStatus - 1/6 committees join 225.86 us/op 219.56 us/op 1.03
altair processAttestation - setStatus - 1/3 committees join 430.83 us/op 420.15 us/op 1.03
altair processAttestation - setStatus - 1/2 committees join 626.28 us/op 590.43 us/op 1.06
altair processAttestation - setStatus - 2/3 committees join 798.04 us/op 764.16 us/op 1.04
altair processAttestation - setStatus - 4/5 committees join 1.1061 ms/op 1.0146 ms/op 1.09
altair processAttestation - setStatus - 100% committees join 1.3278 ms/op 1.2678 ms/op 1.05
altair processBlock - 250000 vs - 7PWei normalcase 29.855 ms/op 28.153 ms/op 1.06
altair processBlock - 250000 vs - 7PWei normalcase hashState 38.044 ms/op 36.439 ms/op 1.04
altair processBlock - 250000 vs - 7PWei worstcase 81.409 ms/op 96.186 ms/op 0.85
altair processBlock - 250000 vs - 7PWei worstcase hashState 106.34 ms/op 127.70 ms/op 0.83
phase0 processBlock - 250000 vs - 7PWei normalcase 3.6617 ms/op 3.9288 ms/op 0.93
phase0 processBlock - 250000 vs - 7PWei worstcase 49.361 ms/op 59.486 ms/op 0.83
altair processEth1Data - 250000 vs - 7PWei normalcase 738.39 us/op 823.86 us/op 0.90
Tree 40 250000 create 785.90 ms/op 947.38 ms/op 0.83
Tree 40 250000 get(125000) 311.34 ns/op 324.06 ns/op 0.96
Tree 40 250000 set(125000) 2.7550 us/op 3.0804 us/op 0.89
Tree 40 250000 toArray() 32.802 ms/op 34.379 ms/op 0.95
Tree 40 250000 iterate all - toArray() + loop 33.869 ms/op 33.969 ms/op 1.00
Tree 40 250000 iterate all - get(i) 113.82 ms/op 126.83 ms/op 0.90
MutableVector 250000 create 15.840 ms/op 18.937 ms/op 0.84
MutableVector 250000 get(125000) 14.861 ns/op 13.193 ns/op 1.13
MutableVector 250000 set(125000) 680.62 ns/op 850.92 ns/op 0.80
MutableVector 250000 toArray() 7.3045 ms/op 6.8382 ms/op 1.07
MutableVector 250000 iterate all - toArray() + loop 7.4014 ms/op 6.8786 ms/op 1.08
MutableVector 250000 iterate all - get(i) 3.2900 ms/op 3.3093 ms/op 0.99
Array 250000 create 6.4275 ms/op 6.6327 ms/op 0.97
Array 250000 clone - spread 4.3840 ms/op 4.9969 ms/op 0.88
Array 250000 get(125000) 1.7850 ns/op 2.0480 ns/op 0.87
Array 250000 set(125000) 1.7870 ns/op 1.9620 ns/op 0.91
Array 250000 iterate all - loop 182.20 us/op 137.53 us/op 1.32
effectiveBalanceIncrements clone Uint8Array 300000 94.617 us/op 286.26 us/op 0.33
effectiveBalanceIncrements clone MutableVector 300000 1.4160 us/op 724.00 ns/op 1.96
effectiveBalanceIncrements rw all Uint8Array 300000 253.39 us/op 285.19 us/op 0.89
effectiveBalanceIncrements rw all MutableVector 300000 226.58 ms/op 206.56 ms/op 1.10
phase0 afterProcessEpoch - 250000 vs - 7PWei 214.13 ms/op 205.01 ms/op 1.04
phase0 beforeProcessEpoch - 250000 vs - 7PWei 72.410 ms/op 73.606 ms/op 0.98
altair processEpoch - mainnet_e81889 599.81 ms/op 607.97 ms/op 0.99
mainnet_e81889 - altair beforeProcessEpoch 114.80 ms/op 106.55 ms/op 1.08
mainnet_e81889 - altair processJustificationAndFinalization 52.708 us/op 76.400 us/op 0.69
mainnet_e81889 - altair processInactivityUpdates 11.906 ms/op 11.698 ms/op 1.02
mainnet_e81889 - altair processRewardsAndPenalties 92.527 ms/op 147.02 ms/op 0.63
mainnet_e81889 - altair processRegistryUpdates 7.2430 us/op 25.516 us/op 0.28
mainnet_e81889 - altair processSlashings 2.3480 us/op 4.2160 us/op 0.56
mainnet_e81889 - altair processEth1DataReset 2.8470 us/op 5.1910 us/op 0.55
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.5233 ms/op 3.3337 ms/op 0.76
mainnet_e81889 - altair processSlashingsReset 16.766 us/op 32.234 us/op 0.52
mainnet_e81889 - altair processRandaoMixesReset 16.364 us/op 34.965 us/op 0.47
mainnet_e81889 - altair processHistoricalRootsUpdate 2.6860 us/op 6.1750 us/op 0.43
mainnet_e81889 - altair processParticipationFlagUpdates 8.6740 us/op 19.495 us/op 0.44
mainnet_e81889 - altair processSyncCommitteeUpdates 2.2810 us/op 5.2990 us/op 0.43
mainnet_e81889 - altair afterProcessEpoch 199.50 ms/op 201.64 ms/op 0.99
phase0 processEpoch - mainnet_e58758 534.17 ms/op 584.14 ms/op 0.91
mainnet_e58758 - phase0 beforeProcessEpoch 206.25 ms/op 231.68 ms/op 0.89
mainnet_e58758 - phase0 processJustificationAndFinalization 45.675 us/op 66.829 us/op 0.68
mainnet_e58758 - phase0 processRewardsAndPenalties 74.029 ms/op 140.86 ms/op 0.53
mainnet_e58758 - phase0 processRegistryUpdates 23.331 us/op 38.693 us/op 0.60
mainnet_e58758 - phase0 processSlashings 2.1980 us/op 4.4560 us/op 0.49
mainnet_e58758 - phase0 processEth1DataReset 2.6460 us/op 5.6970 us/op 0.46
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1265 ms/op 2.8051 ms/op 0.76
mainnet_e58758 - phase0 processSlashingsReset 11.952 us/op 21.441 us/op 0.56
mainnet_e58758 - phase0 processRandaoMixesReset 14.975 us/op 30.395 us/op 0.49
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.3800 us/op 6.1000 us/op 0.39
mainnet_e58758 - phase0 processParticipationRecordUpdates 12.535 us/op 30.087 us/op 0.42
mainnet_e58758 - phase0 afterProcessEpoch 175.59 ms/op 166.12 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.1930 ms/op 2.5194 ms/op 1.27
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.6963 ms/op 2.6615 ms/op 1.39
altair processInactivityUpdates - 250000 normalcase 30.640 ms/op 34.031 ms/op 0.90
altair processInactivityUpdates - 250000 worstcase 37.783 ms/op 33.288 ms/op 1.14
phase0 processRegistryUpdates - 250000 normalcase 14.016 us/op 34.170 us/op 0.41
phase0 processRegistryUpdates - 250000 badcase_full_deposits 477.79 us/op 505.71 us/op 0.94
phase0 processRegistryUpdates - 250000 worstcase 0.5 243.24 ms/op 225.35 ms/op 1.08
altair processRewardsAndPenalties - 250000 normalcase 90.365 ms/op 86.931 ms/op 1.04
altair processRewardsAndPenalties - 250000 worstcase 135.98 ms/op 141.39 ms/op 0.96
phase0 getAttestationDeltas - 250000 normalcase 13.174 ms/op 13.095 ms/op 1.01
phase0 getAttestationDeltas - 250000 worstcase 13.716 ms/op 13.688 ms/op 1.00
phase0 processSlashings - 250000 worstcase 6.1264 ms/op 6.0880 ms/op 1.01
altair processSyncCommitteeUpdates - 250000 301.46 ms/op 321.72 ms/op 0.94
BeaconState.hashTreeRoot - No change 582.00 ns/op 673.00 ns/op 0.86
BeaconState.hashTreeRoot - 1 full validator 65.838 us/op 78.301 us/op 0.84
BeaconState.hashTreeRoot - 32 full validator 591.42 us/op 826.93 us/op 0.72
BeaconState.hashTreeRoot - 512 full validator 7.0007 ms/op 7.9659 ms/op 0.88
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 86.788 us/op 109.49 us/op 0.79
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.2040 ms/op 1.2567 ms/op 0.96
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 16.197 ms/op 18.439 ms/op 0.88
BeaconState.hashTreeRoot - 1 balances 63.565 us/op 77.809 us/op 0.82
BeaconState.hashTreeRoot - 32 balances 653.92 us/op 667.33 us/op 0.98
BeaconState.hashTreeRoot - 512 balances 5.5615 ms/op 7.1861 ms/op 0.77
BeaconState.hashTreeRoot - 250000 balances 95.578 ms/op 106.60 ms/op 0.90
aggregationBits - 2048 els - zipIndexesInBitList 36.595 us/op 32.030 us/op 1.14
regular array get 100000 times 76.312 us/op 55.226 us/op 1.38
wrappedArray get 100000 times 76.995 us/op 57.494 us/op 1.34
arrayWithProxy get 100000 times 34.206 ms/op 33.858 ms/op 1.01
ssz.Root.equals 556.00 ns/op 534.00 ns/op 1.04
byteArrayEquals 563.00 ns/op 553.00 ns/op 1.02
shuffle list - 16384 els 12.535 ms/op 12.182 ms/op 1.03
shuffle list - 250000 els 182.10 ms/op 175.41 ms/op 1.04
processSlot - 1 slots 12.918 us/op 16.785 us/op 0.77
processSlot - 32 slots 1.9039 ms/op 2.3071 ms/op 0.83
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 433.52 us/op 373.97 us/op 1.16
getCommitteeAssignments - req 1 vs - 250000 vc 5.7335 ms/op 5.3805 ms/op 1.07
getCommitteeAssignments - req 100 vs - 250000 vc 7.5729 ms/op 7.6888 ms/op 0.98
getCommitteeAssignments - req 1000 vs - 250000 vc 8.2027 ms/op 7.8567 ms/op 1.04
computeProposers - vc 250000 19.406 ms/op 19.711 ms/op 0.98
computeEpochShuffling - vc 250000 173.42 ms/op 174.89 ms/op 0.99
getNextSyncCommittee - vc 250000 287.43 ms/op 322.19 ms/op 0.89
pass gossip attestations to forkchoice per slot 5.6685 ms/op 3.8865 ms/op 1.46
computeDeltas 3.8976 ms/op 3.8304 ms/op 1.02
computeProposerBoostScoreFromBalances 973.75 us/op 858.66 us/op 1.13
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.2482 ms/op 2.2042 ms/op 1.02
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 82.360 us/op 88.723 us/op 0.93
BLS verify - blst-native 2.0211 ms/op 2.5919 ms/op 0.78
BLS verifyMultipleSignatures 3 - blst-native 4.0490 ms/op 5.3405 ms/op 0.76
BLS verifyMultipleSignatures 8 - blst-native 8.7001 ms/op 11.285 ms/op 0.77
BLS verifyMultipleSignatures 32 - blst-native 31.021 ms/op 41.028 ms/op 0.76
BLS aggregatePubkeys 32 - blst-native 42.531 us/op 58.687 us/op 0.72
BLS aggregatePubkeys 128 - blst-native 168.20 us/op 231.94 us/op 0.73
getAttestationsForBlock 75.139 ms/op 60.553 ms/op 1.24
isKnown best case - 1 super set check 482.00 ns/op 504.00 ns/op 0.96
isKnown normal case - 2 super set checks 467.00 ns/op 485.00 ns/op 0.96
isKnown worse case - 16 super set checks 471.00 ns/op 483.00 ns/op 0.98
CheckpointStateCache - add get delete 10.853 us/op 12.595 us/op 0.86
validate gossip signedAggregateAndProof - struct 4.7359 ms/op 5.8670 ms/op 0.81
validate gossip attestation - struct 2.1327 ms/op 2.7673 ms/op 0.77
altair verifyImport mainnet_s3766816:31 6.9115 s/op 8.3088 s/op 0.83
pickEth1Vote - no votes 2.2368 ms/op 2.3155 ms/op 0.97
pickEth1Vote - max votes 25.587 ms/op 25.259 ms/op 1.01
pickEth1Vote - Eth1Data hashTreeRoot value x2048 12.381 ms/op 14.097 ms/op 0.88
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.934 ms/op 22.924 ms/op 0.96
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6854 ms/op 1.7220 ms/op 0.98
pickEth1Vote - Eth1Data fastSerialize tree x2048 18.559 ms/op 18.753 ms/op 0.99
bytes32 toHexString 1.1860 us/op 1.2530 us/op 0.95
bytes32 Buffer.toString(hex) 781.00 ns/op 782.00 ns/op 1.00
bytes32 Buffer.toString(hex) from Uint8Array 961.00 ns/op 1.0770 us/op 0.89
bytes32 Buffer.toString(hex) + 0x 720.00 ns/op 820.00 ns/op 0.88
Object access 1 prop 0.37900 ns/op 0.38000 ns/op 1.00
Map access 1 prop 0.30200 ns/op 0.32600 ns/op 0.93
Object get x1000 18.533 ns/op 15.568 ns/op 1.19
Map get x1000 1.1340 ns/op 0.87800 ns/op 1.29
Object set x1000 122.99 ns/op 113.21 ns/op 1.09
Map set x1000 75.482 ns/op 77.100 ns/op 0.98
Return object 10000 times 0.40490 ns/op 0.40290 ns/op 1.00
Throw Error 10000 times 6.6088 us/op 6.6610 us/op 0.99
enrSubnets - fastDeserialize 64 bits 2.8630 us/op 2.8770 us/op 1.00
enrSubnets - ssz BitVector 64 bits 792.00 ns/op 856.00 ns/op 0.93
enrSubnets - fastDeserialize 4 bits 406.00 ns/op 406.00 ns/op 1.00
enrSubnets - ssz BitVector 4 bits 854.00 ns/op 846.00 ns/op 1.01
prioritizePeers score -10:0 att 32-0.1 sync 2-0 115.37 us/op 105.00 us/op 1.10
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 150.32 us/op 149.43 us/op 1.01
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 248.80 us/op 263.67 us/op 0.94
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 437.10 us/op 561.26 us/op 0.78
prioritizePeers score 0:0 att 64-1 sync 4-1 514.56 us/op 590.69 us/op 0.87
RateTracker 1000000 limit, 1 obj count per request 210.60 ns/op 200.98 ns/op 1.05
RateTracker 1000000 limit, 2 obj count per request 163.61 ns/op 150.78 ns/op 1.09
RateTracker 1000000 limit, 4 obj count per request 137.25 ns/op 119.82 ns/op 1.15
RateTracker 1000000 limit, 8 obj count per request 122.32 ns/op 108.82 ns/op 1.12
RateTracker with prune 4.7420 us/op 4.9160 us/op 0.96
array of 16000 items push then shift 3.7127 us/op 5.1246 us/op 0.72
LinkedList of 16000 items push then shift 26.516 ns/op 28.298 ns/op 0.94
array of 16000 items push then pop 295.80 ns/op 245.65 ns/op 1.20
LinkedList of 16000 items push then pop 23.159 ns/op 23.200 ns/op 1.00
array of 24000 items push then shift 5.4811 us/op 7.7698 us/op 0.71
LinkedList of 24000 items push then shift 28.223 ns/op 28.429 ns/op 0.99
array of 24000 items push then pop 236.54 ns/op 211.06 ns/op 1.12
LinkedList of 24000 items push then pop 23.388 ns/op 24.406 ns/op 0.96
intersect bitArray bitLen 8 14.086 ns/op 11.900 ns/op 1.18
intersect array and set length 8 194.00 ns/op 181.81 ns/op 1.07
intersect bitArray bitLen 128 74.292 ns/op 67.949 ns/op 1.09
intersect array and set length 128 2.6238 us/op 2.3009 us/op 1.14

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 2e52cc7 into unstable Jun 28, 2022
@wemeetagain wemeetagain deleted the cayman/remove-rollback branch June 28, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants