Replace findAttesterDependentRoot with getDependantRoot #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
requested changes
Sep 16, 2022
|
|
||
| // Special case close to genesis block, return the genesis block root | ||
| if (beforeSlot <= 0) { | ||
| const genesisBlock = this.protoArray.nodes[0]; |
There was a problem hiding this comment.
If that's the usage may be we make the getNodeFromIndex function public and then use it here.
There was a problem hiding this comment.
Yes, but getNodeFromIndex would throw PROTO_ARRAY_ERROR_INVALID_NODE_INDEX, while this implementation would throw Genesis block not available, which would be much easier to debug if a user reports. Would prefer to stick to this one-line re-implementation, as it's quite peculiar use of the nodes array
This was referenced Sep 16, 2022
|
dependant -> dependent |
nazarhussain
previously approved these changes
Sep 16, 2022
|
@wemeetagain @dapplion Interesting information. Seems both are valid spellings.
|
nazarhussain
approved these changes
Sep 16, 2022
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Generalize logic from
findAttesterDependentRootto work for both proposer and attester dependant root computation. To be used latter in API implDescription