Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.md to remove devops tasks and include local backup strategy #4602

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

philknows
Copy link
Member

Motivation

Improve the RELEASE.md release manager checklist from lessons learned up to v1.1.0 release.

Description

This PR is to update the Release manager checklist to remove tasks specified for the PM + Devops. It only serves as a reminder, but not an action item for the release manager. Also includes a strategy of backing up local stable and unstable branches before merging incase of using the wrong merge strategy.

@philknows philknows requested a review from a team as a code owner September 27, 2022 21:35
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 9c1ec9e Previous: 0e600d8 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.2314 ms/op 1.5254 ms/op 1.46
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 72.415 us/op 67.948 us/op 1.07
BLS verify - blst-native 1.8563 ms/op 2.1653 ms/op 0.86
BLS verifyMultipleSignatures 3 - blst-native 3.8071 ms/op 4.4687 ms/op 0.85
BLS verifyMultipleSignatures 8 - blst-native 8.1957 ms/op 9.6628 ms/op 0.85
BLS verifyMultipleSignatures 32 - blst-native 29.696 ms/op 35.119 ms/op 0.85
BLS aggregatePubkeys 32 - blst-native 39.528 us/op 46.458 us/op 0.85
BLS aggregatePubkeys 128 - blst-native 152.95 us/op 182.08 us/op 0.84
getAttestationsForBlock 89.352 ms/op 72.570 ms/op 1.23
isKnown best case - 1 super set check 436.00 ns/op 479.00 ns/op 0.91
isKnown normal case - 2 super set checks 419.00 ns/op 462.00 ns/op 0.91
isKnown worse case - 16 super set checks 417.00 ns/op 465.00 ns/op 0.90
CheckpointStateCache - add get delete 8.9590 us/op 8.6310 us/op 1.04
validate gossip signedAggregateAndProof - struct 4.2635 ms/op 5.0208 ms/op 0.85
validate gossip attestation - struct 2.0296 ms/op 2.3627 ms/op 0.86
pickEth1Vote - no votes 2.2608 ms/op 2.0768 ms/op 1.09
pickEth1Vote - max votes 21.380 ms/op 17.001 ms/op 1.26
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.869 ms/op 11.814 ms/op 0.92
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.039 ms/op 19.139 ms/op 1.10
pickEth1Vote - Eth1Data fastSerialize value x2048 1.5706 ms/op 1.3757 ms/op 1.14
pickEth1Vote - Eth1Data fastSerialize tree x2048 14.194 ms/op 11.227 ms/op 1.26
bytes32 toHexString 1.0600 us/op 958.00 ns/op 1.11
bytes32 Buffer.toString(hex) 725.00 ns/op 764.00 ns/op 0.95
bytes32 Buffer.toString(hex) from Uint8Array 1.0010 us/op 995.00 ns/op 1.01
bytes32 Buffer.toString(hex) + 0x 722.00 ns/op 763.00 ns/op 0.95
Object access 1 prop 0.35400 ns/op 0.34400 ns/op 1.03
Map access 1 prop 0.29200 ns/op 0.31500 ns/op 0.93
Object get x1000 17.522 ns/op 10.788 ns/op 1.62
Map get x1000 1.1650 ns/op 1.0180 ns/op 1.14
Object set x1000 125.04 ns/op 68.918 ns/op 1.81
Map set x1000 76.981 ns/op 45.154 ns/op 1.70
Return object 10000 times 0.37150 ns/op 0.43170 ns/op 0.86
Throw Error 10000 times 5.9563 us/op 5.9474 us/op 1.00
enrSubnets - fastDeserialize 64 bits 2.6640 us/op 2.3960 us/op 1.11
enrSubnets - ssz BitVector 64 bits 767.00 ns/op 740.00 ns/op 1.04
enrSubnets - fastDeserialize 4 bits 395.00 ns/op 353.00 ns/op 1.12
enrSubnets - ssz BitVector 4 bits 775.00 ns/op 761.00 ns/op 1.02
prioritizePeers score -10:0 att 32-0.1 sync 2-0 95.101 us/op 80.035 us/op 1.19
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 121.84 us/op 121.71 us/op 1.00
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 217.84 us/op 193.96 us/op 1.12
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 477.82 us/op 334.68 us/op 1.43
prioritizePeers score 0:0 att 64-1 sync 4-1 457.29 us/op 405.41 us/op 1.13
RateTracker 1000000 limit, 1 obj count per request 196.20 ns/op 174.12 ns/op 1.13
RateTracker 1000000 limit, 2 obj count per request 141.17 ns/op 127.45 ns/op 1.11
RateTracker 1000000 limit, 4 obj count per request 120.57 ns/op 103.93 ns/op 1.16
RateTracker 1000000 limit, 8 obj count per request 107.37 ns/op 91.777 ns/op 1.17
RateTracker with prune 4.3710 us/op 3.7070 us/op 1.18
array of 16000 items push then shift 3.1897 us/op 51.570 us/op 0.06
LinkedList of 16000 items push then shift 17.427 ns/op 12.150 ns/op 1.43
array of 16000 items push then pop 233.86 ns/op 171.12 ns/op 1.37
LinkedList of 16000 items push then pop 16.410 ns/op 11.944 ns/op 1.37
array of 24000 items push then shift 4.5564 us/op 77.335 us/op 0.06
LinkedList of 24000 items push then shift 20.708 ns/op 12.437 ns/op 1.67
array of 24000 items push then pop 202.84 ns/op 189.03 ns/op 1.07
LinkedList of 24000 items push then pop 17.740 ns/op 12.035 ns/op 1.47
intersect bitArray bitLen 8 11.644 ns/op 10.876 ns/op 1.07
intersect array and set length 8 167.72 ns/op 128.54 ns/op 1.30
intersect bitArray bitLen 128 72.068 ns/op 56.458 ns/op 1.28
intersect array and set length 128 2.2934 us/op 1.7190 us/op 1.33
Buffer.concat 32 items 2.1920 ns/op 1.8180 ns/op 1.21
pass gossip attestations to forkchoice per slot 4.0547 ms/op 3.5660 ms/op 1.14
computeDeltas 5.4697 ms/op 4.4289 ms/op 1.23
computeProposerBoostScoreFromBalances 921.47 us/op 808.87 us/op 1.14
altair processAttestation - 250000 vs - 7PWei normalcase 3.9103 ms/op 3.3225 ms/op 1.18
altair processAttestation - 250000 vs - 7PWei worstcase 5.7975 ms/op 5.2988 ms/op 1.09
altair processAttestation - setStatus - 1/6 committees join 207.37 us/op 186.07 us/op 1.11
altair processAttestation - setStatus - 1/3 committees join 400.83 us/op 361.49 us/op 1.11
altair processAttestation - setStatus - 1/2 committees join 564.10 us/op 522.91 us/op 1.08
altair processAttestation - setStatus - 2/3 committees join 725.99 us/op 682.41 us/op 1.06
altair processAttestation - setStatus - 4/5 committees join 999.95 us/op 948.52 us/op 1.05
altair processAttestation - setStatus - 100% committees join 1.1857 ms/op 1.1435 ms/op 1.04
altair processBlock - 250000 vs - 7PWei normalcase 27.944 ms/op 24.617 ms/op 1.14
altair processBlock - 250000 vs - 7PWei normalcase hashState 42.313 ms/op 33.250 ms/op 1.27
altair processBlock - 250000 vs - 7PWei worstcase 80.371 ms/op 86.575 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase hashState 96.268 ms/op 101.14 ms/op 0.95
phase0 processBlock - 250000 vs - 7PWei normalcase 3.5974 ms/op 3.1373 ms/op 1.15
phase0 processBlock - 250000 vs - 7PWei worstcase 46.344 ms/op 50.767 ms/op 0.91
altair processEth1Data - 250000 vs - 7PWei normalcase 837.56 us/op 726.99 us/op 1.15
Tree 40 250000 create 793.02 ms/op 679.32 ms/op 1.17
Tree 40 250000 get(125000) 299.79 ns/op 238.75 ns/op 1.26
Tree 40 250000 set(125000) 2.7549 us/op 2.0539 us/op 1.34
Tree 40 250000 toArray() 32.866 ms/op 27.337 ms/op 1.20
Tree 40 250000 iterate all - toArray() + loop 32.845 ms/op 27.012 ms/op 1.22
Tree 40 250000 iterate all - get(i) 113.72 ms/op 110.15 ms/op 1.03
MutableVector 250000 create 18.140 ms/op 12.686 ms/op 1.43
MutableVector 250000 get(125000) 14.795 ns/op 10.637 ns/op 1.39
MutableVector 250000 set(125000) 677.54 ns/op 513.74 ns/op 1.32
MutableVector 250000 toArray() 7.9337 ms/op 5.9195 ms/op 1.34
MutableVector 250000 iterate all - toArray() + loop 8.3006 ms/op 6.1088 ms/op 1.36
MutableVector 250000 iterate all - get(i) 3.2847 ms/op 2.7532 ms/op 1.19
Array 250000 create 7.1066 ms/op 5.2264 ms/op 1.36
Array 250000 clone - spread 4.0700 ms/op 2.3275 ms/op 1.75
Array 250000 get(125000) 1.6960 ns/op 1.1470 ns/op 1.48
Array 250000 set(125000) 1.6700 ns/op 1.1450 ns/op 1.46
Array 250000 iterate all - loop 167.78 us/op 151.86 us/op 1.10
effectiveBalanceIncrements clone Uint8Array 300000 97.090 us/op 51.747 us/op 1.88
effectiveBalanceIncrements clone MutableVector 300000 1.2700 us/op 637.00 ns/op 1.99
effectiveBalanceIncrements rw all Uint8Array 300000 252.55 us/op 246.97 us/op 1.02
effectiveBalanceIncrements rw all MutableVector 300000 222.27 ms/op 125.26 ms/op 1.77
phase0 afterProcessEpoch - 250000 vs - 7PWei 207.87 ms/op 196.66 ms/op 1.06
phase0 beforeProcessEpoch - 250000 vs - 7PWei 69.684 ms/op 58.045 ms/op 1.20
altair processEpoch - mainnet_e81889 596.62 ms/op 542.45 ms/op 1.10
mainnet_e81889 - altair beforeProcessEpoch 95.886 ms/op 125.21 ms/op 0.77
mainnet_e81889 - altair processJustificationAndFinalization 21.998 us/op 17.229 us/op 1.28
mainnet_e81889 - altair processInactivityUpdates 10.794 ms/op 8.5981 ms/op 1.26
mainnet_e81889 - altair processRewardsAndPenalties 163.33 ms/op 120.32 ms/op 1.36
mainnet_e81889 - altair processRegistryUpdates 3.3560 us/op 2.6670 us/op 1.26
mainnet_e81889 - altair processSlashings 733.00 ns/op 672.00 ns/op 1.09
mainnet_e81889 - altair processEth1DataReset 784.00 ns/op 653.00 ns/op 1.20
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.9149 ms/op 2.4301 ms/op 1.20
mainnet_e81889 - altair processSlashingsReset 5.4650 us/op 3.9860 us/op 1.37
mainnet_e81889 - altair processRandaoMixesReset 6.4730 us/op 3.9780 us/op 1.63
mainnet_e81889 - altair processHistoricalRootsUpdate 914.00 ns/op 668.00 ns/op 1.37
mainnet_e81889 - altair processParticipationFlagUpdates 2.8730 us/op 2.3670 us/op 1.21
mainnet_e81889 - altair processSyncCommitteeUpdates 643.00 ns/op 533.00 ns/op 1.21
mainnet_e81889 - altair afterProcessEpoch 195.31 ms/op 199.77 ms/op 0.98
phase0 processEpoch - mainnet_e58758 531.58 ms/op 483.59 ms/op 1.10
mainnet_e58758 - phase0 beforeProcessEpoch 228.12 ms/op 176.40 ms/op 1.29
mainnet_e58758 - phase0 processJustificationAndFinalization 21.088 us/op 16.439 us/op 1.28
mainnet_e58758 - phase0 processRewardsAndPenalties 137.40 ms/op 106.51 ms/op 1.29
mainnet_e58758 - phase0 processRegistryUpdates 10.775 us/op 7.7600 us/op 1.39
mainnet_e58758 - phase0 processSlashings 703.00 ns/op 568.00 ns/op 1.24
mainnet_e58758 - phase0 processEth1DataReset 799.00 ns/op 588.00 ns/op 1.36
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.0607 ms/op 1.9121 ms/op 1.08
mainnet_e58758 - phase0 processSlashingsReset 4.9210 us/op 3.1440 us/op 1.57
mainnet_e58758 - phase0 processRandaoMixesReset 5.5500 us/op 4.3420 us/op 1.28
mainnet_e58758 - phase0 processHistoricalRootsUpdate 774.00 ns/op 607.00 ns/op 1.28
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.2310 us/op 3.3850 us/op 1.55
mainnet_e58758 - phase0 afterProcessEpoch 160.93 ms/op 165.04 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.6432 ms/op 1.9990 ms/op 1.32
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.4131 ms/op 2.2739 ms/op 1.50
altair processInactivityUpdates - 250000 normalcase 38.762 ms/op 39.428 ms/op 0.98
altair processInactivityUpdates - 250000 worstcase 40.960 ms/op 32.688 ms/op 1.25
phase0 processRegistryUpdates - 250000 normalcase 7.9400 us/op 6.1970 us/op 1.28
phase0 processRegistryUpdates - 250000 badcase_full_deposits 409.23 us/op 382.71 us/op 1.07
phase0 processRegistryUpdates - 250000 worstcase 0.5 207.16 ms/op 172.94 ms/op 1.20
altair processRewardsAndPenalties - 250000 normalcase 87.781 ms/op 74.300 ms/op 1.18
altair processRewardsAndPenalties - 250000 worstcase 135.43 ms/op 104.34 ms/op 1.30
phase0 getAttestationDeltas - 250000 normalcase 12.331 ms/op 11.349 ms/op 1.09
phase0 getAttestationDeltas - 250000 worstcase 12.632 ms/op 11.494 ms/op 1.10
phase0 processSlashings - 250000 worstcase 5.3102 ms/op 5.1323 ms/op 1.03
altair processSyncCommitteeUpdates - 250000 288.03 ms/op 287.03 ms/op 1.00
BeaconState.hashTreeRoot - No change 485.00 ns/op 544.00 ns/op 0.89
BeaconState.hashTreeRoot - 1 full validator 64.212 us/op 69.537 us/op 0.92
BeaconState.hashTreeRoot - 32 full validator 544.05 us/op 650.13 us/op 0.84
BeaconState.hashTreeRoot - 512 full validator 6.4184 ms/op 7.3009 ms/op 0.88
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 80.323 us/op 84.687 us/op 0.95
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1823 ms/op 1.2631 ms/op 0.94
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.598 ms/op 16.180 ms/op 0.96
BeaconState.hashTreeRoot - 1 balances 58.555 us/op 62.991 us/op 0.93
BeaconState.hashTreeRoot - 32 balances 621.74 us/op 640.02 us/op 0.97
BeaconState.hashTreeRoot - 512 balances 5.6571 ms/op 6.0964 ms/op 0.93
BeaconState.hashTreeRoot - 250000 balances 92.874 ms/op 111.03 ms/op 0.84
aggregationBits - 2048 els - zipIndexesInBitList 33.463 us/op 24.851 us/op 1.35
regular array get 100000 times 67.406 us/op 61.605 us/op 1.09
wrappedArray get 100000 times 67.357 us/op 61.608 us/op 1.09
arrayWithProxy get 100000 times 29.177 ms/op 28.333 ms/op 1.03
ssz.Root.equals 499.00 ns/op 485.00 ns/op 1.03
byteArrayEquals 501.00 ns/op 446.00 ns/op 1.12
shuffle list - 16384 els 11.060 ms/op 11.564 ms/op 0.96
shuffle list - 250000 els 166.15 ms/op 169.54 ms/op 0.98
processSlot - 1 slots 12.687 us/op 12.803 us/op 0.99
processSlot - 32 slots 1.8168 ms/op 1.8915 ms/op 0.96
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 399.97 us/op 400.94 us/op 1.00
getCommitteeAssignments - req 1 vs - 250000 vc 5.2833 ms/op 5.4863 ms/op 0.96
getCommitteeAssignments - req 100 vs - 250000 vc 7.2980 ms/op 7.9940 ms/op 0.91
getCommitteeAssignments - req 1000 vs - 250000 vc 7.8036 ms/op 8.6009 ms/op 0.91
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 10.570 ns/op 8.0500 ns/op 1.31
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1908 us/op 951.72 ns/op 1.25
computeProposers - vc 250000 17.553 ms/op 16.780 ms/op 1.05
computeEpochShuffling - vc 250000 169.36 ms/op 173.18 ms/op 0.98
getNextSyncCommittee - vc 250000 291.10 ms/op 283.72 ms/op 1.03

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 6681763 into unstable Sep 28, 2022
@wemeetagain wemeetagain deleted the philknows/release-checklist-update branch September 28, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants