Add vc bn fallback #4648
Merged
Add vc bn fallback #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
previously approved these changes
Oct 7, 2022
twoeths
reviewed
Oct 7, 2022
twoeths
reviewed
Oct 7, 2022
Looked into it and doesn't simplify the code that much since I have to track which URL completed the request successfully. Also Promise.any is available in NodeJS >= 15.0.0 and our engine is still > 12.9 |
Performance Report✔️ no performance regression detected Full benchmark results
|
|
Is there any sort of notification for us we can use when a fallback is triggered? |
Yes, this PRs adds metrics that will clearly show if a URL is down |
g11tech
reviewed
Oct 10, 2022
| resolve(res); | ||
| }, | ||
| (err) => { | ||
| this.urlsScore[i_] = Math.max(URL_SCORE_MIN, this.urlsScore[i_] - URL_SCORE_DELTA_ERROR); |
There was a problem hiding this comment.
should the score be reduced by half, so that the url will have to prove working multiple times to come back to max
There was a problem hiding this comment.
Looks like currently score decreases twice as fast as score increases
wemeetagain
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
A good vc bn fallback must fulfill these goals
This behaviour is not simple, so classic patterns like Promise.all() or for try catch are not enough.
The solution of this PR appears complex, but that's what's needed to achieve the goals above. Please check the inline comments for pointers on the logic.
A unit tests proves that it works, but I haven't tested yet on a deployed beacon node.
Closes #4337