Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validator waiting on start #500

Merged
merged 3 commits into from
Oct 6, 2019
Merged

Fix validator waiting on start #500

merged 3 commits into from
Oct 6, 2019

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Oct 3, 2019 •
edited
Loading

Goal

Unit test

Validator
2019-10-03 16:27:09  [VALIDATOR]        info: Setting up validator client...
2019-10-03 16:27:09  [VALIDATOR]        info: Setting up RPC connection...
    ✓ Should be able to connect with the beacon chain
2019-10-03 16:27:09  [VALIDATOR]        info: RPC connection successfully established: inmemory!
2019-10-03 16:27:09  [VALIDATOR]        info: Checking if chain has started...


  298 passing (21s)
  1 pending

2019-10-03 16:27:10  [VALIDATOR]        info: Chain start has occured!

@GregTheGreek GregTheGreek mentioned this pull request Oct 3, 2019
Closed
mpetrunic
mpetrunic requested changes Oct 4, 2019
View reviewed changes
packages/lodestar/src/validator/rpc/abstract.ts Outdated Show resolved Hide resolved
packages/lodestar/src/validator/rpc/interface.ts Outdated Show resolved Hide resolved
@twoeths twoeths force-pushed the tuyen/validator-wait-for-chain-start branch from 0499cd9 to b821da6 Compare October 5, 2019 01:21
@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #500 into master will increase coverage by 0.02%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   66.84%   66.87%   +0.02%     
==========================================
  Files         226      226              
  Lines        4241     4241              
  Branches      400      401       +1     
==========================================
+ Hits         2835     2836       +1     
+ Misses       1302     1300       -2     
- Partials      104      105       +1

mpetrunic
mpetrunic requested changes Oct 5, 2019
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one small thing

packages/lodestar/src/validator/validator.ts Outdated Show resolved Hide resolved
@mpetrunic
Copy link
Member

@GregTheGreek labeler?

@GregTheGreek
Copy link
Member

Fails on forks unfortunately

@mpetrunic mpetrunic merged commit 99d56b4 into ChainSafe:master Oct 6, 2019
@twoeths twoeths deleted the tuyen/validator-wait-for-chain-start branch October 6, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregTheGreek GregTheGreek GregTheGreek approved these changes

@mpetrunic mpetrunic mpetrunic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix validator waiting on start
3 participants
@twoeths @mpetrunic @GregTheGreek