Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.4.3 #5135

Merged
merged 4 commits into from
Feb 12, 2023
Merged

Release v1.4.3 #5135

merged 4 commits into from
Feb 12, 2023

Conversation

wemeetagain
Copy link
Member

No description provided.

wemeetagain and others added 4 commits February 12, 2023 11:35
@wemeetagain
v1.4.3
8890b7f
@filoozom @wemeetagain
feat: add chiado config (#5108)
1262052 
* feat: add chiado config

* feat: add chiado to cli package

* chore: add chiado to default.env

* feat: automatically apply right preset for Chiado
@g11tech @wemeetagain
Add zhejiang network option (#5132)
628ac62
@wemeetagain
Fix dynamically set max peers (#5130)
ce35af9 
* Fix dynamically set max peers

* Ensure maxPeers >= targetPeers
@wemeetagain wemeetagain requested a review from a team as a code owner February 12, 2023 16:39
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: bac69c9 Previous: 0ede2a1 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 690.52 us/op 742.33 us/op 0.93
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 42.711 us/op 44.307 us/op 0.96
BLS verify - blst-native 1.1436 ms/op 1.1978 ms/op 0.95
BLS verifyMultipleSignatures 3 - blst-native 2.3264 ms/op 2.4388 ms/op 0.95
BLS verifyMultipleSignatures 8 - blst-native 4.9920 ms/op 5.2372 ms/op 0.95
BLS verifyMultipleSignatures 32 - blst-native 18.857 ms/op 19.034 ms/op 0.99
BLS aggregatePubkeys 32 - blst-native 25.408 us/op 25.671 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 98.451 us/op 99.277 us/op 0.99
getAttestationsForBlock 52.880 ms/op 52.930 ms/op 1.00
isKnown best case - 1 super set check 286.00 ns/op 253.00 ns/op 1.13
isKnown normal case - 2 super set checks 278.00 ns/op 258.00 ns/op 1.08
isKnown worse case - 16 super set checks 282.00 ns/op 255.00 ns/op 1.11
CheckpointStateCache - add get delete 4.8130 us/op 5.0720 us/op 0.95
validate gossip signedAggregateAndProof - struct 2.6071 ms/op 2.7401 ms/op 0.95
validate gossip attestation - struct 1.2391 ms/op 1.3121 ms/op 0.94
pickEth1Vote - no votes 1.1578 ms/op 1.2329 ms/op 0.94
pickEth1Vote - max votes 9.7825 ms/op 10.491 ms/op 0.93
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.3578 ms/op 8.7054 ms/op 0.96
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.454 ms/op 14.592 ms/op 0.99
pickEth1Vote - Eth1Data fastSerialize value x2048 614.40 us/op 625.79 us/op 0.98
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.5377 ms/op 7.5363 ms/op 1.00
bytes32 toHexString 475.00 ns/op 477.00 ns/op 1.00
bytes32 Buffer.toString(hex) 329.00 ns/op 335.00 ns/op 0.98
bytes32 Buffer.toString(hex) from Uint8Array 514.00 ns/op 537.00 ns/op 0.96
bytes32 Buffer.toString(hex) + 0x 329.00 ns/op 335.00 ns/op 0.98
Object access 1 prop 0.16600 ns/op 0.16300 ns/op 1.02
Map access 1 prop 0.15600 ns/op 0.17000 ns/op 0.92
Object get x1000 6.1350 ns/op 7.2440 ns/op 0.85
Map get x1000 0.57300 ns/op 0.61000 ns/op 0.94
Object set x1000 48.444 ns/op 50.964 ns/op 0.95
Map set x1000 40.638 ns/op 42.167 ns/op 0.96
Return object 10000 times 0.22100 ns/op 0.23390 ns/op 0.94
Throw Error 10000 times 3.8722 us/op 4.0387 us/op 0.96
fastMsgIdFn sha256 / 200 bytes 3.2630 us/op 3.3880 us/op 0.96
fastMsgIdFn h32 xxhash / 200 bytes 264.00 ns/op 289.00 ns/op 0.91
fastMsgIdFn h64 xxhash / 200 bytes 365.00 ns/op 382.00 ns/op 0.96
fastMsgIdFn sha256 / 1000 bytes 10.819 us/op 11.505 us/op 0.94
fastMsgIdFn h32 xxhash / 1000 bytes 382.00 ns/op 403.00 ns/op 0.95
fastMsgIdFn h64 xxhash / 1000 bytes 433.00 ns/op 451.00 ns/op 0.96
fastMsgIdFn sha256 / 10000 bytes 97.633 us/op 103.33 us/op 0.94
fastMsgIdFn h32 xxhash / 10000 bytes 1.7780 us/op 1.8850 us/op 0.94
fastMsgIdFn h64 xxhash / 10000 bytes 1.2570 us/op 1.3290 us/op 0.95
enrSubnets - fastDeserialize 64 bits 1.1980 us/op 1.2830 us/op 0.93
enrSubnets - ssz BitVector 64 bits 485.00 ns/op 465.00 ns/op 1.04
enrSubnets - fastDeserialize 4 bits 163.00 ns/op 170.00 ns/op 0.96
enrSubnets - ssz BitVector 4 bits 468.00 ns/op 474.00 ns/op 0.99
prioritizePeers score -10:0 att 32-0.1 sync 2-0 92.946 us/op 94.276 us/op 0.99
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 121.21 us/op 123.28 us/op 0.98
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 165.62 us/op 169.63 us/op 0.98
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 297.00 us/op 300.61 us/op 0.99
prioritizePeers score 0:0 att 64-1 sync 4-1 355.77 us/op 358.66 us/op 0.99
array of 16000 items push then shift 1.6052 us/op 1.6129 us/op 1.00
LinkedList of 16000 items push then shift 8.7080 ns/op 8.7520 ns/op 0.99
array of 16000 items push then pop 81.928 ns/op 76.714 ns/op 1.07
LinkedList of 16000 items push then pop 8.4180 ns/op 8.4530 ns/op 1.00
array of 24000 items push then shift 2.3381 us/op 2.3325 us/op 1.00
LinkedList of 24000 items push then shift 8.6750 ns/op 8.6190 ns/op 1.01
array of 24000 items push then pop 74.105 ns/op 72.068 ns/op 1.03
LinkedList of 24000 items push then pop 8.3360 ns/op 8.0840 ns/op 1.03
intersect bitArray bitLen 8 13.066 ns/op 12.629 ns/op 1.03
intersect array and set length 8 75.929 ns/op 73.382 ns/op 1.03
intersect bitArray bitLen 128 43.384 ns/op 42.078 ns/op 1.03
intersect array and set length 128 1.0311 us/op 1.0072 us/op 1.02
Buffer.concat 32 items 2.9430 us/op 2.6700 us/op 1.10
Uint8Array.set 32 items 2.8750 us/op 2.9580 us/op 0.97
pass gossip attestations to forkchoice per slot 3.1956 ms/op 2.2075 ms/op 1.45
computeDeltas 2.8408 ms/op 3.3784 ms/op 0.84
computeProposerBoostScoreFromBalances 1.7632 ms/op 1.7671 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 1.9958 ms/op 1.9963 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei worstcase 3.1759 ms/op 3.1599 ms/op 1.01
altair processAttestation - setStatus - 1/6 committees join 136.31 us/op 131.74 us/op 1.03
altair processAttestation - setStatus - 1/3 committees join 268.35 us/op 256.81 us/op 1.04
altair processAttestation - setStatus - 1/2 committees join 359.31 us/op 348.34 us/op 1.03
altair processAttestation - setStatus - 2/3 committees join 437.61 us/op 450.70 us/op 0.97
altair processAttestation - setStatus - 4/5 committees join 612.62 us/op 621.08 us/op 0.99
altair processAttestation - setStatus - 100% committees join 743.24 us/op 728.79 us/op 1.02
altair processBlock - 250000 vs - 7PWei normalcase 18.821 ms/op 17.794 ms/op 1.06
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.014 ms/op 27.650 ms/op 1.01
altair processBlock - 250000 vs - 7PWei worstcase 46.444 ms/op 51.287 ms/op 0.91
altair processBlock - 250000 vs - 7PWei worstcase hashState 74.515 ms/op 70.805 ms/op 1.05
phase0 processBlock - 250000 vs - 7PWei normalcase 2.0014 ms/op 1.9695 ms/op 1.02
phase0 processBlock - 250000 vs - 7PWei worstcase 28.426 ms/op 26.478 ms/op 1.07
altair processEth1Data - 250000 vs - 7PWei normalcase 464.28 us/op 452.89 us/op 1.03
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 7.8440 us/op 6.5810 us/op 1.19
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 20.907 us/op 19.436 us/op 1.08
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 8.4740 us/op 8.4570 us/op 1.00
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.8010 us/op 6.2310 us/op 1.09
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 79.594 us/op 73.886 us/op 1.08
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 634.48 us/op 614.80 us/op 1.03
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 894.56 us/op 907.88 us/op 0.99
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 854.84 us/op 866.75 us/op 0.99
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.4079 ms/op 2.1907 ms/op 1.10
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.5421 ms/op 1.5475 ms/op 1.00
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.7996 ms/op 3.7431 ms/op 1.02
Tree 40 250000 create 329.90 ms/op 290.72 ms/op 1.13
Tree 40 250000 get(125000) 183.04 ns/op 177.33 ns/op 1.03
Tree 40 250000 set(125000) 1.0018 us/op 879.60 ns/op 1.14
Tree 40 250000 toArray() 21.151 ms/op 16.794 ms/op 1.26
Tree 40 250000 iterate all - toArray() + loop 21.654 ms/op 16.249 ms/op 1.33
Tree 40 250000 iterate all - get(i) 76.100 ms/op 63.346 ms/op 1.20
MutableVector 250000 create 11.645 ms/op 10.442 ms/op 1.12
MutableVector 250000 get(125000) 6.4410 ns/op 6.1400 ns/op 1.05
MutableVector 250000 set(125000) 288.97 ns/op 252.19 ns/op 1.15
MutableVector 250000 toArray() 3.1364 ms/op 2.6810 ms/op 1.17
MutableVector 250000 iterate all - toArray() + loop 3.2721 ms/op 2.7924 ms/op 1.17
MutableVector 250000 iterate all - get(i) 1.5237 ms/op 1.4670 ms/op 1.04
Array 250000 create 2.9315 ms/op 2.4920 ms/op 1.18
Array 250000 clone - spread 1.3009 ms/op 1.2436 ms/op 1.05
Array 250000 get(125000) 0.66400 ns/op 0.57700 ns/op 1.15
Array 250000 set(125000) 0.73300 ns/op 0.66000 ns/op 1.11
Array 250000 iterate all - loop 85.052 us/op 103.77 us/op 0.82
effectiveBalanceIncrements clone Uint8Array 300000 37.051 us/op 28.308 us/op 1.31
effectiveBalanceIncrements clone MutableVector 300000 441.00 ns/op 395.00 ns/op 1.12
effectiveBalanceIncrements rw all Uint8Array 300000 166.82 us/op 159.87 us/op 1.04
effectiveBalanceIncrements rw all MutableVector 300000 85.624 ms/op 78.511 ms/op 1.09
phase0 afterProcessEpoch - 250000 vs - 7PWei 113.61 ms/op 107.07 ms/op 1.06
phase0 beforeProcessEpoch - 250000 vs - 7PWei 34.732 ms/op 33.938 ms/op 1.02
altair processEpoch - mainnet_e81889 330.89 ms/op 300.76 ms/op 1.10
mainnet_e81889 - altair beforeProcessEpoch 64.321 ms/op 46.476 ms/op 1.38
mainnet_e81889 - altair processJustificationAndFinalization 16.411 us/op 15.367 us/op 1.07
mainnet_e81889 - altair processInactivityUpdates 6.0516 ms/op 5.3129 ms/op 1.14
mainnet_e81889 - altair processRewardsAndPenalties 52.907 ms/op 53.584 ms/op 0.99
mainnet_e81889 - altair processRegistryUpdates 2.6060 us/op 2.7510 us/op 0.95
mainnet_e81889 - altair processSlashings 480.00 ns/op 537.00 ns/op 0.89
mainnet_e81889 - altair processEth1DataReset 598.00 ns/op 504.00 ns/op 1.19
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2177 ms/op 1.1810 ms/op 1.03
mainnet_e81889 - altair processSlashingsReset 4.9900 us/op 5.0470 us/op 0.99
mainnet_e81889 - altair processRandaoMixesReset 4.2720 us/op 4.1910 us/op 1.02
mainnet_e81889 - altair processHistoricalRootsUpdate 604.00 ns/op 559.00 ns/op 1.08
mainnet_e81889 - altair processParticipationFlagUpdates 2.6070 us/op 2.3940 us/op 1.09
mainnet_e81889 - altair processSyncCommitteeUpdates 1.3800 us/op 554.00 ns/op 2.49
mainnet_e81889 - altair afterProcessEpoch 124.59 ms/op 115.23 ms/op 1.08
phase0 processEpoch - mainnet_e58758 349.76 ms/op 313.58 ms/op 1.12
mainnet_e58758 - phase0 beforeProcessEpoch 108.19 ms/op 121.79 ms/op 0.89
mainnet_e58758 - phase0 processJustificationAndFinalization 17.683 us/op 15.261 us/op 1.16
mainnet_e58758 - phase0 processRewardsAndPenalties 66.666 ms/op 56.602 ms/op 1.18
mainnet_e58758 - phase0 processRegistryUpdates 7.4420 us/op 7.7580 us/op 0.96
mainnet_e58758 - phase0 processSlashings 475.00 ns/op 435.00 ns/op 1.09
mainnet_e58758 - phase0 processEth1DataReset 423.00 ns/op 437.00 ns/op 0.97
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2696 ms/op 945.55 us/op 1.34
mainnet_e58758 - phase0 processSlashingsReset 3.1920 us/op 2.7160 us/op 1.18
mainnet_e58758 - phase0 processRandaoMixesReset 4.6640 us/op 4.3770 us/op 1.07
mainnet_e58758 - phase0 processHistoricalRootsUpdate 500.00 ns/op 502.00 ns/op 1.00
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.8720 us/op 3.9230 us/op 0.99
mainnet_e58758 - phase0 afterProcessEpoch 97.686 ms/op 92.499 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2353 ms/op 1.1946 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4769 ms/op 1.4248 ms/op 1.04
altair processInactivityUpdates - 250000 normalcase 24.425 ms/op 21.141 ms/op 1.16
altair processInactivityUpdates - 250000 worstcase 25.441 ms/op 23.688 ms/op 1.07
phase0 processRegistryUpdates - 250000 normalcase 6.1670 us/op 6.1960 us/op 1.00
phase0 processRegistryUpdates - 250000 badcase_full_deposits 229.55 us/op 229.10 us/op 1.00
phase0 processRegistryUpdates - 250000 worstcase 0.5 123.27 ms/op 115.45 ms/op 1.07
altair processRewardsAndPenalties - 250000 normalcase 66.759 ms/op 41.217 ms/op 1.62
altair processRewardsAndPenalties - 250000 worstcase 68.989 ms/op 54.743 ms/op 1.26
phase0 getAttestationDeltas - 250000 normalcase 6.7012 ms/op 6.5519 ms/op 1.02
phase0 getAttestationDeltas - 250000 worstcase 6.6254 ms/op 6.4261 ms/op 1.03
phase0 processSlashings - 250000 worstcase 3.3360 ms/op 3.4363 ms/op 0.97
altair processSyncCommitteeUpdates - 250000 172.20 ms/op 174.22 ms/op 0.99
BeaconState.hashTreeRoot - No change 271.00 ns/op 263.00 ns/op 1.03
BeaconState.hashTreeRoot - 1 full validator 52.554 us/op 48.545 us/op 1.08
BeaconState.hashTreeRoot - 32 full validator 501.95 us/op 513.43 us/op 0.98
BeaconState.hashTreeRoot - 512 full validator 6.0898 ms/op 5.1433 ms/op 1.18
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 62.300 us/op 63.008 us/op 0.99
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 894.49 us/op 857.43 us/op 1.04
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 10.907 ms/op 10.745 ms/op 1.02
BeaconState.hashTreeRoot - 1 balances 49.821 us/op 47.529 us/op 1.05
BeaconState.hashTreeRoot - 32 balances 439.88 us/op 427.99 us/op 1.03
BeaconState.hashTreeRoot - 512 balances 4.4602 ms/op 4.4156 ms/op 1.01
BeaconState.hashTreeRoot - 250000 balances 73.170 ms/op 75.281 ms/op 0.97
aggregationBits - 2048 els - zipIndexesInBitList 15.828 us/op 15.784 us/op 1.00
regular array get 100000 times 32.790 us/op 35.722 us/op 0.92
wrappedArray get 100000 times 34.156 us/op 32.812 us/op 1.04
arrayWithProxy get 100000 times 16.554 ms/op 15.680 ms/op 1.06
ssz.Root.equals 559.00 ns/op 556.00 ns/op 1.01
byteArrayEquals 541.00 ns/op 546.00 ns/op 0.99
shuffle list - 16384 els 6.9407 ms/op 6.7473 ms/op 1.03
shuffle list - 250000 els 99.570 ms/op 99.119 ms/op 1.00
processSlot - 1 slots 8.4420 us/op 8.5550 us/op 0.99
processSlot - 32 slots 1.3200 ms/op 1.3249 ms/op 1.00
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 188.43 us/op 197.45 us/op 0.95
getCommitteeAssignments - req 1 vs - 250000 vc 2.8928 ms/op 2.8867 ms/op 1.00
getCommitteeAssignments - req 100 vs - 250000 vc 4.1559 ms/op 4.0814 ms/op 1.02
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3235 ms/op 4.4559 ms/op 0.97
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.7400 ns/op 4.4100 ns/op 1.07
state getBlockRootAtSlot - 250000 vs - 7PWei 700.80 ns/op 732.93 ns/op 0.96
computeProposers - vc 250000 11.250 ms/op 10.224 ms/op 1.10
computeEpochShuffling - vc 250000 99.502 ms/op 97.484 ms/op 1.02
getNextSyncCommittee - vc 250000 168.78 ms/op 176.08 ms/op 0.96

by benchmarkbot/action

g11tech
g11tech previously approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wemeetagain wemeetagain changed the base branch from unstable to stable February 12, 2023 22:53
@wemeetagain wemeetagain dismissed g11tech’s stale review February 12, 2023 22:53

The base branch was changed.

@wemeetagain wemeetagain merged commit 941a1cf into stable Feb 12, 2023
@wemeetagain wemeetagain deleted the rc/v1.4.3 branch February 12, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

@g11tech g11tech g11tech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wemeetagain @twoeths @g11tech @filoozom