Refactor client monitoring #5183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
force-pushed
the
refactor-monitoring
branch
from
259ed76 to
e85cc13
Compare
- remove caching as it is currently unused, system data providers handle the caching internally - remove support for async provider functions, not needed at the moment as all functions are synchronous
For some environments (e.g. windows) the collecting of system data might take a bit longer. This bucket allows to get better insights on function calls that took between 1-5 seconds.
nflaig
force-pushed
the
refactor-monitoring
branch
from
e85cc13 to
6d149d2
Compare
Some calls randomly run into rate limiting, this might be due to delays when collecting system data or other reasons which delay the previous request which could let the next request run into a rate limit. It might also just be due to a clock skew or other inaccuracies, it is hard to rely on time between two remote systems. Adding 2 seconds seems to resolve this issue but needs to be further observed. The https://github.com/gobitfly/eth2-client-metrics-exporter also uses a default interval of 62 seconds instead of 60 seconds.
Use color red for errors and color green for successful requests to remote service.
nflaig
force-pushed
the
refactor-monitoring
branch
from
6d149d2 to
d0084dc
Compare
|
🎉 This PR is included in v1.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some follow up changes/refactoring for #5037 to clean up few things and fix some minor issues.
Description
CONSTANT_CASEfor client stats schema fixturesSee commits for further details.