Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builder http client metric prefix #5270

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fix builder http client metric prefix #5270

merged 1 commit into from
Mar 16, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Mar 16, 2023

Motivation

Wrong metric prefix found in #5231 (comment) , thanks @nflaig

Description

Change builder http client metrcis to lodestar_ prefix

@twoeths twoeths requested a review from a team as a code owner March 16, 2023 01:28
@twoeths twoeths enabled auto-merge (squash) March 16, 2023 01:33
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: f15e126 Previous: 73c6c6c Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 519.67 us/op 893.70 us/op 0.58
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 46.867 us/op 51.145 us/op 0.92
BLS verify - blst-native 1.2432 ms/op 1.3306 ms/op 0.93
BLS verifyMultipleSignatures 3 - blst-native 2.5338 ms/op 2.7003 ms/op 0.94
BLS verifyMultipleSignatures 8 - blst-native 5.4207 ms/op 5.7879 ms/op 0.94
BLS verifyMultipleSignatures 32 - blst-native 19.651 ms/op 20.064 ms/op 0.98
BLS aggregatePubkeys 32 - blst-native 26.551 us/op 26.718 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 103.09 us/op 106.10 us/op 0.97
getAttestationsForBlock 58.054 ms/op 55.382 ms/op 1.05
isKnown best case - 1 super set check 269.00 ns/op 260.00 ns/op 1.03
isKnown normal case - 2 super set checks 265.00 ns/op 260.00 ns/op 1.02
isKnown worse case - 16 super set checks 262.00 ns/op 259.00 ns/op 1.01
CheckpointStateCache - add get delete 5.2440 us/op 5.2940 us/op 0.99
validate gossip signedAggregateAndProof - struct 2.8582 ms/op 2.9026 ms/op 0.98
validate gossip attestation - struct 1.3605 ms/op 1.4292 ms/op 0.95
pickEth1Vote - no votes 1.2975 ms/op 1.3087 ms/op 0.99
pickEth1Vote - max votes 9.1983 ms/op 10.936 ms/op 0.84
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.3693 ms/op 9.4922 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.723 ms/op 14.852 ms/op 1.06
pickEth1Vote - Eth1Data fastSerialize value x2048 694.24 us/op 714.47 us/op 0.97
pickEth1Vote - Eth1Data fastSerialize tree x2048 8.3916 ms/op 6.8788 ms/op 1.22
bytes32 toHexString 546.00 ns/op 557.00 ns/op 0.98
bytes32 Buffer.toString(hex) 393.00 ns/op 369.00 ns/op 1.07
bytes32 Buffer.toString(hex) from Uint8Array 598.00 ns/op 584.00 ns/op 1.02
bytes32 Buffer.toString(hex) + 0x 369.00 ns/op 369.00 ns/op 1.00
Object access 1 prop 0.18600 ns/op 0.17900 ns/op 1.04
Map access 1 prop 0.16400 ns/op 0.16500 ns/op 0.99
Object get x1000 6.9490 ns/op 7.5730 ns/op 0.92
Map get x1000 0.81000 ns/op 0.62300 ns/op 1.30
Object set x1000 85.447 ns/op 55.294 ns/op 1.55
Map set x1000 63.881 ns/op 49.377 ns/op 1.29
Return object 10000 times 0.32060 ns/op 0.25820 ns/op 1.24
Throw Error 10000 times 4.9459 us/op 4.5457 us/op 1.09
fastMsgIdFn sha256 / 200 bytes 3.8970 us/op 3.6210 us/op 1.08
fastMsgIdFn h32 xxhash / 200 bytes 483.00 ns/op 302.00 ns/op 1.60
fastMsgIdFn h64 xxhash / 200 bytes 538.00 ns/op 399.00 ns/op 1.35
fastMsgIdFn sha256 / 1000 bytes 13.337 us/op 11.977 us/op 1.11
fastMsgIdFn h32 xxhash / 1000 bytes 496.00 ns/op 446.00 ns/op 1.11
fastMsgIdFn h64 xxhash / 1000 bytes 924.00 ns/op 499.00 ns/op 1.85
fastMsgIdFn sha256 / 10000 bytes 151.81 us/op 108.99 us/op 1.39
fastMsgIdFn h32 xxhash / 10000 bytes 2.9560 us/op 2.0370 us/op 1.45
fastMsgIdFn h64 xxhash / 10000 bytes 1.7600 us/op 1.4280 us/op 1.23
enrSubnets - fastDeserialize 64 bits 2.4510 us/op 1.3390 us/op 1.83
enrSubnets - ssz BitVector 64 bits 787.00 ns/op 502.00 ns/op 1.57
enrSubnets - fastDeserialize 4 bits 333.00 ns/op 172.00 ns/op 1.94
enrSubnets - ssz BitVector 4 bits 719.00 ns/op 513.00 ns/op 1.40
prioritizePeers score -10:0 att 32-0.1 sync 2-0 143.87 us/op 107.84 us/op 1.33
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 183.64 us/op 137.72 us/op 1.33
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 332.17 us/op 171.11 us/op 1.94
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 553.46 us/op 308.20 us/op 1.80
prioritizePeers score 0:0 att 64-1 sync 4-1 740.71 us/op 374.56 us/op 1.98
array of 16000 items push then shift 2.7540 us/op 1.7508 us/op 1.57
LinkedList of 16000 items push then shift 15.572 ns/op 9.2180 ns/op 1.69
array of 16000 items push then pop 176.36 ns/op 95.622 ns/op 1.84
LinkedList of 16000 items push then pop 10.792 ns/op 9.0180 ns/op 1.20
array of 24000 items push then shift 3.2145 us/op 2.4237 us/op 1.33
LinkedList of 24000 items push then shift 11.956 ns/op 9.1560 ns/op 1.31
array of 24000 items push then pop 99.422 ns/op 85.428 ns/op 1.16
LinkedList of 24000 items push then pop 9.1610 ns/op 8.8930 ns/op 1.03
intersect bitArray bitLen 8 15.135 ns/op 14.162 ns/op 1.07
intersect array and set length 8 146.13 ns/op 81.146 ns/op 1.80
intersect bitArray bitLen 128 51.640 ns/op 46.236 ns/op 1.12
intersect array and set length 128 1.5374 us/op 1.0814 us/op 1.42
Buffer.concat 32 items 3.1620 us/op 2.7460 us/op 1.15
Uint8Array.set 32 items 4.1240 us/op 3.0080 us/op 1.37
pass gossip attestations to forkchoice per slot 2.7562 ms/op 2.4124 ms/op 1.14
computeDeltas 3.9522 ms/op 3.6203 ms/op 1.09
computeProposerBoostScoreFromBalances 1.9454 ms/op 1.8515 ms/op 1.05
altair processAttestation - 250000 vs - 7PWei normalcase 2.4410 ms/op 2.2093 ms/op 1.10
altair processAttestation - 250000 vs - 7PWei worstcase 3.4916 ms/op 3.4316 ms/op 1.02
altair processAttestation - setStatus - 1/6 committees join 147.65 us/op 146.80 us/op 1.01
altair processAttestation - setStatus - 1/3 committees join 291.66 us/op 287.84 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 390.13 us/op 375.83 us/op 1.04
altair processAttestation - setStatus - 2/3 committees join 492.05 us/op 478.93 us/op 1.03
altair processAttestation - setStatus - 4/5 committees join 680.55 us/op 691.34 us/op 0.98
altair processAttestation - setStatus - 100% committees join 794.51 us/op 783.96 us/op 1.01
altair processBlock - 250000 vs - 7PWei normalcase 19.207 ms/op 19.384 ms/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.818 ms/op 24.986 ms/op 1.07
altair processBlock - 250000 vs - 7PWei worstcase 53.246 ms/op 50.509 ms/op 1.05
altair processBlock - 250000 vs - 7PWei worstcase hashState 71.891 ms/op 81.223 ms/op 0.89
phase0 processBlock - 250000 vs - 7PWei normalcase 2.0632 ms/op 2.0994 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei worstcase 29.525 ms/op 28.378 ms/op 1.04
altair processEth1Data - 250000 vs - 7PWei normalcase 481.80 us/op 492.67 us/op 0.98
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 7.2400 us/op 6.7370 us/op 1.07
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 22.240 us/op 21.535 us/op 1.03
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 8.9970 us/op 9.5100 us/op 0.95
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.9970 us/op 8.0840 us/op 0.87
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 82.890 us/op 90.628 us/op 0.91
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 652.65 us/op 677.57 us/op 0.96
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 922.50 us/op 952.23 us/op 0.97
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 878.13 us/op 915.06 us/op 0.96
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.5056 ms/op 2.4429 ms/op 1.03
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.5424 ms/op 1.7012 ms/op 0.91
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.9189 ms/op 3.9967 ms/op 0.98
Tree 40 250000 create 293.98 ms/op 336.23 ms/op 0.87
Tree 40 250000 get(125000) 187.41 ns/op 201.34 ns/op 0.93
Tree 40 250000 set(125000) 906.16 ns/op 1.0358 us/op 0.87
Tree 40 250000 toArray() 17.189 ms/op 20.274 ms/op 0.85
Tree 40 250000 iterate all - toArray() + loop 17.797 ms/op 18.531 ms/op 0.96
Tree 40 250000 iterate all - get(i) 68.560 ms/op 75.877 ms/op 0.90
MutableVector 250000 create 9.0593 ms/op 11.941 ms/op 0.76
MutableVector 250000 get(125000) 6.4100 ns/op 6.8310 ns/op 0.94
MutableVector 250000 set(125000) 267.83 ns/op 281.87 ns/op 0.95
MutableVector 250000 toArray() 2.7742 ms/op 3.3040 ms/op 0.84
MutableVector 250000 iterate all - toArray() + loop 3.4014 ms/op 3.4130 ms/op 1.00
MutableVector 250000 iterate all - get(i) 1.6067 ms/op 1.7283 ms/op 0.93
Array 250000 create 2.6095 ms/op 2.7717 ms/op 0.94
Array 250000 clone - spread 1.1310 ms/op 1.2976 ms/op 0.87
Array 250000 get(125000) 0.57000 ns/op 0.62800 ns/op 0.91
Array 250000 set(125000) 0.62800 ns/op 0.71200 ns/op 0.88
Array 250000 iterate all - loop 115.84 us/op 119.08 us/op 0.97
effectiveBalanceIncrements clone Uint8Array 300000 29.482 us/op 34.390 us/op 0.86
effectiveBalanceIncrements clone MutableVector 300000 331.00 ns/op 449.00 ns/op 0.74
effectiveBalanceIncrements rw all Uint8Array 300000 171.77 us/op 198.64 us/op 0.86
effectiveBalanceIncrements rw all MutableVector 300000 80.268 ms/op 92.663 ms/op 0.87
phase0 afterProcessEpoch - 250000 vs - 7PWei 117.42 ms/op 131.71 ms/op 0.89
phase0 beforeProcessEpoch - 250000 vs - 7PWei 44.037 ms/op 35.485 ms/op 1.24
altair processEpoch - mainnet_e81889 309.98 ms/op 338.84 ms/op 0.91
mainnet_e81889 - altair beforeProcessEpoch 61.725 ms/op 63.521 ms/op 0.97
mainnet_e81889 - altair processJustificationAndFinalization 18.806 us/op 15.737 us/op 1.20
mainnet_e81889 - altair processInactivityUpdates 5.3959 ms/op 5.4973 ms/op 0.98
mainnet_e81889 - altair processRewardsAndPenalties 66.501 ms/op 70.206 ms/op 0.95
mainnet_e81889 - altair processRegistryUpdates 2.5040 us/op 2.9210 us/op 0.86
mainnet_e81889 - altair processSlashings 629.00 ns/op 440.00 ns/op 1.43
mainnet_e81889 - altair processEth1DataReset 607.00 ns/op 463.00 ns/op 1.31
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2389 ms/op 1.2430 ms/op 1.00
mainnet_e81889 - altair processSlashingsReset 4.4370 us/op 4.5420 us/op 0.98
mainnet_e81889 - altair processRandaoMixesReset 6.0510 us/op 4.7030 us/op 1.29
mainnet_e81889 - altair processHistoricalRootsUpdate 632.00 ns/op 585.00 ns/op 1.08
mainnet_e81889 - altair processParticipationFlagUpdates 2.1750 us/op 2.5150 us/op 0.86
mainnet_e81889 - altair processSyncCommitteeUpdates 566.00 ns/op 468.00 ns/op 1.21
mainnet_e81889 - altair afterProcessEpoch 127.29 ms/op 123.31 ms/op 1.03
phase0 processEpoch - mainnet_e58758 353.88 ms/op 327.24 ms/op 1.08
mainnet_e58758 - phase0 beforeProcessEpoch 131.32 ms/op 141.51 ms/op 0.93
mainnet_e58758 - phase0 processJustificationAndFinalization 15.553 us/op 16.937 us/op 0.92
mainnet_e58758 - phase0 processRewardsAndPenalties 63.517 ms/op 57.193 ms/op 1.11
mainnet_e58758 - phase0 processRegistryUpdates 7.8470 us/op 7.3260 us/op 1.07
mainnet_e58758 - phase0 processSlashings 562.00 ns/op 647.00 ns/op 0.87
mainnet_e58758 - phase0 processEth1DataReset 539.00 ns/op 492.00 ns/op 1.10
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 939.10 us/op 1.0726 ms/op 0.88
mainnet_e58758 - phase0 processSlashingsReset 3.7040 us/op 4.6600 us/op 0.79
mainnet_e58758 - phase0 processRandaoMixesReset 4.5400 us/op 7.7020 us/op 0.59
mainnet_e58758 - phase0 processHistoricalRootsUpdate 600.00 ns/op 791.00 ns/op 0.76
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.1530 us/op 11.194 us/op 0.37
mainnet_e58758 - phase0 afterProcessEpoch 96.793 ms/op 111.09 ms/op 0.87
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.1968 ms/op 1.4351 ms/op 0.83
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.3897 ms/op 1.7029 ms/op 0.82
altair processInactivityUpdates - 250000 normalcase 19.269 ms/op 22.593 ms/op 0.85
altair processInactivityUpdates - 250000 worstcase 26.005 ms/op 25.944 ms/op 1.00
phase0 processRegistryUpdates - 250000 normalcase 6.2030 us/op 8.4950 us/op 0.73
phase0 processRegistryUpdates - 250000 badcase_full_deposits 236.07 us/op 297.44 us/op 0.79
phase0 processRegistryUpdates - 250000 worstcase 0.5 113.53 ms/op 130.82 ms/op 0.87
altair processRewardsAndPenalties - 250000 normalcase 66.821 ms/op 56.628 ms/op 1.18
altair processRewardsAndPenalties - 250000 worstcase 72.049 ms/op 47.875 ms/op 1.50
phase0 getAttestationDeltas - 250000 normalcase 6.4495 ms/op 7.5134 ms/op 0.86
phase0 getAttestationDeltas - 250000 worstcase 6.5558 ms/op 7.3938 ms/op 0.89
phase0 processSlashings - 250000 worstcase 3.3414 ms/op 3.9112 ms/op 0.85
altair processSyncCommitteeUpdates - 250000 174.57 ms/op 208.09 ms/op 0.84
BeaconState.hashTreeRoot - No change 260.00 ns/op 304.00 ns/op 0.86
BeaconState.hashTreeRoot - 1 full validator 53.801 us/op 58.099 us/op 0.93
BeaconState.hashTreeRoot - 32 full validator 548.80 us/op 589.63 us/op 0.93
BeaconState.hashTreeRoot - 512 full validator 5.4934 ms/op 5.9093 ms/op 0.93
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 61.164 us/op 70.156 us/op 0.87
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 894.53 us/op 938.04 us/op 0.95
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.589 ms/op 12.602 ms/op 0.92
BeaconState.hashTreeRoot - 1 balances 47.521 us/op 56.267 us/op 0.84
BeaconState.hashTreeRoot - 32 balances 472.84 us/op 473.52 us/op 1.00
BeaconState.hashTreeRoot - 512 balances 4.4166 ms/op 4.7090 ms/op 0.94
BeaconState.hashTreeRoot - 250000 balances 77.368 ms/op 79.649 ms/op 0.97
aggregationBits - 2048 els - zipIndexesInBitList 15.598 us/op 16.069 us/op 0.97
regular array get 100000 times 32.779 us/op 33.514 us/op 0.98
wrappedArray get 100000 times 32.756 us/op 33.430 us/op 0.98
arrayWithProxy get 100000 times 15.681 ms/op 16.572 ms/op 0.95
ssz.Root.equals 546.00 ns/op 577.00 ns/op 0.95
byteArrayEquals 531.00 ns/op 565.00 ns/op 0.94
shuffle list - 16384 els 6.7373 ms/op 7.1819 ms/op 0.94
shuffle list - 250000 els 104.64 ms/op 105.60 ms/op 0.99
processSlot - 1 slots 9.2830 us/op 8.6910 us/op 1.07
processSlot - 32 slots 1.3236 ms/op 1.3567 ms/op 0.98
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 194.46 us/op 201.42 us/op 0.97
getCommitteeAssignments - req 1 vs - 250000 vc 2.8941 ms/op 3.0523 ms/op 0.95
getCommitteeAssignments - req 100 vs - 250000 vc 4.1418 ms/op 4.3436 ms/op 0.95
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4489 ms/op 4.6633 ms/op 0.95
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.3700 ns/op 4.8000 ns/op 0.91
state getBlockRootAtSlot - 250000 vs - 7PWei 975.90 ns/op 973.58 ns/op 1.00
computeProposers - vc 250000 10.326 ms/op 10.945 ms/op 0.94
computeEpochShuffling - vc 250000 101.01 ms/op 107.09 ms/op 0.94
getNextSyncCommittee - vc 250000 173.50 ms/op 181.27 ms/op 0.96

by benchmarkbot/action

nflaig
nflaig approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I assume we are fine with not having dashboard panels for those

@twoeths twoeths merged commit 4028a01 into unstable Mar 16, 2023
@twoeths twoeths deleted the tuyen/fix_builder_metric_prefix branch March 16, 2023 09:07
twoeths added a commit that referenced this pull request Mar 20, 2023
@twoeths
Fix builder http client metric prefix (#5270)
58dc0ba
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.6.0 🎉

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoeths @wemeetagain @nflaig