-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip serializing gossip block when persisting to db #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
changed the title
Tuyen/do not serialize gossip blocks
feat: skip serializing gossip block when persisting to db
Apr 27, 2023
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
force-pushed
the
tuyen/do_not_serialize_gossip_blocks
branch
from
May 3, 2023 08:41
7416368
to
b05b060
Compare
wemeetagain
previously approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dapplion
approved these changes
May 8, 2023
dapplion
suggested changes
May 8, 2023
dapplion
approved these changes
May 8, 2023
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now when gossipsub deliver a gossip block, we already have serialized data but still have to serialize signed block when persisting to db
Description
WithBytes, WithOptionalBytes
WithOptionalBytes<BlockInput>
, at gossip we pass in bytes data, for blocks from other flow we keep them as isCloses #5422