-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: block network processor when processing current slot block #5458
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
@@ -284,6 +285,10 @@ export class BeaconChain implements IBeaconChain { | |||
await this.bls.close(); | |||
} | |||
|
|||
isProcessingCurrentSlotBlock(): boolean { | |||
return this._isProcessingCurrentSlotBlock; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this logic and _isProcessingCurrentSlotBlock
be in the network processor class? It knows the block's slot and current clock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I can move the logic there. It means we block network processor messages right after we receive a gossip block message instead of at the time we process block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in v1.9.0 🎉 |
Motivation
Description
maxGossipTopicConcurrency
part of #5413
Closes #5441
Testing