feat: add support for justified block id in Beacon Node API
#5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Performance Report✔️ no performance regression detected Full benchmark results
|
acuarica
changed the title
justified block id in Beacon Node APIjustified block id in Beacon Node API
dapplion
reviewed
May 4, 2023
| it("should resolve justified", async function () { | ||
| const expected = 0; | ||
| forkChoiceStub.getJustifiedBlock.returns(expectedSummary); | ||
| await resolveBlockId(forkChoiceStub, dbStub, "justified").catch(() => {}); |
There was a problem hiding this comment.
Why the silent catch all errors here?
There was a problem hiding this comment.
Not sure why, all other tests for resolveBlockId have the same structure, so I didn't want to make it different in case I'm missing something.
There was a problem hiding this comment.
After reviewing this with @nazarhussain, we found that without the catch all these tests fail here
dapplion
reviewed
May 4, 2023
| @@ -65,6 +65,13 @@ async function resolveBlockIdOrNull( | |||
| }; | |||
| } | |||
|
|
|||
| if (blockId === "justified") { | |||
| return { | |||
| block: await db.blockArchive.get(forkChoice.getJustifiedBlock().slot), | |||
There was a problem hiding this comment.
Non finalized blocks are not in the archive, but in the block hot db. blockArchive will most likely return null for this query. Instead grab by root from the hot db.
There was a problem hiding this comment.
Just pushed a fix for this, thanks @nazarhussain for helping me to validate the solution.
dapplion
reviewed
May 4, 2023
| const justified = forkChoice.getJustifiedBlock(); | ||
| return { | ||
| block: await db.block.get(fromHexString(justified.blockRoot)), | ||
| executionOptimistic: false, |
There was a problem hiding this comment.
You can compute the correct executionOptimistic boolean value with the forkChoice returned data structure. Check other API endpoints can't recall the exact helper fn name
acuarica
commented
May 5, 2023
| const justified = forkChoice.getJustifiedBlock(); | ||
| return { | ||
| block: await db.block.get(fromHexString(justified.blockRoot)), | ||
| executionOptimistic: isOptimisticBlock(justified), |
There was a problem hiding this comment.
Hey @dapplion, is this what you meant regarding #5459 (comment)?
wemeetagain
approved these changes
May 8, 2023
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR closes #4255.
Description
The
ethereum-metrics-exporterusesjustifiedas block id to retrieve block details https://ethereum.github.io/beacon-APIs/?urls.primaryName=v2.4.0#/Beacon/getBlockV2.This PR adds support for the
justifiedblock id, even if it is not explicitly stated in the Beacon API.