docs: remove instruction for ignore-optional

[dapplion]

Motivation

In the past spec test download was controlled via --ignore-optional. However that's no longer the case, tests are downloaded via a script only if spec tests are run.

However nx requires some optional dependencies to work, so let's drop the flag.

Description

Remove instruction for ignore-optional

[github-actions]

Performance Report

✔️ no performance regression detected

Full benchmark results

Benchmark suite	Current: d7c1732	Previous: a24ada9	Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc	884.73 us/op	812.82 us/op	1.09
getPubkeys - validatorsArr - req 1000 vs - 250000 vc	43.923 us/op	51.210 us/op	0.86
BLS verify - blst-native	1.1879 ms/op	1.2408 ms/op	0.96
BLS verifyMultipleSignatures 3 - blst-native	2.4123 ms/op	2.5205 ms/op	0.96
BLS verifyMultipleSignatures 8 - blst-native	5.1856 ms/op	5.4257 ms/op	0.96
BLS verifyMultipleSignatures 32 - blst-native	18.692 ms/op	19.835 ms/op	0.94
BLS aggregatePubkeys 32 - blst-native	24.874 us/op	26.628 us/op	0.93
BLS aggregatePubkeys 128 - blst-native	97.093 us/op	103.52 us/op	0.94
getAttestationsForBlock	51.921 ms/op	55.745 ms/op	0.93
isKnown best case - 1 super set check	253.00 ns/op	247.00 ns/op	1.02
isKnown normal case - 2 super set checks	248.00 ns/op	249.00 ns/op	1.00
isKnown worse case - 16 super set checks	256.00 ns/op	254.00 ns/op	1.01
CheckpointStateCache - add get delete	4.7810 us/op	5.0170 us/op	0.95
validate gossip signedAggregateAndProof - struct	2.7230 ms/op	2.7501 ms/op	0.99
validate gossip attestation - struct	1.2975 ms/op	1.3123 ms/op	0.99
pickEth1Vote - no votes	1.1750 ms/op	1.2240 ms/op	0.96
pickEth1Vote - max votes	11.243 ms/op	9.4101 ms/op	1.19
pickEth1Vote - Eth1Data hashTreeRoot value x2048	8.5877 ms/op	8.3577 ms/op	1.03
pickEth1Vote - Eth1Data hashTreeRoot tree x2048	15.035 ms/op	15.388 ms/op	0.98
pickEth1Vote - Eth1Data fastSerialize value x2048	630.54 us/op	722.25 us/op	0.87
pickEth1Vote - Eth1Data fastSerialize tree x2048	7.8134 ms/op	7.8064 ms/op	1.00
bytes32 toHexString	472.00 ns/op	499.00 ns/op	0.95
bytes32 Buffer.toString(hex)	334.00 ns/op	347.00 ns/op	0.96
bytes32 Buffer.toString(hex) from Uint8Array	551.00 ns/op	542.00 ns/op	1.02
bytes32 Buffer.toString(hex) + 0x	342.00 ns/op	351.00 ns/op	0.97
Object access 1 prop	0.16100 ns/op	0.15900 ns/op	1.01
Map access 1 prop	0.14800 ns/op	0.14400 ns/op	1.03
Object get x1000	6.6970 ns/op	6.3780 ns/op	1.05
Map get x1000	0.56800 ns/op	0.52500 ns/op	1.08
Object set x1000	51.961 ns/op	48.846 ns/op	1.06
Map set x1000	45.706 ns/op	41.205 ns/op	1.11
Return object 10000 times	0.23920 ns/op	0.22370 ns/op	1.07
Throw Error 10000 times	4.2149 us/op	4.0053 us/op	1.05
fastMsgIdFn sha256 / 200 bytes	3.5220 us/op	3.2400 us/op	1.09
fastMsgIdFn h32 xxhash / 200 bytes	289.00 ns/op	263.00 ns/op	1.10
fastMsgIdFn h64 xxhash / 200 bytes	385.00 ns/op	374.00 ns/op	1.03
fastMsgIdFn sha256 / 1000 bytes	11.357 us/op	11.022 us/op	1.03
fastMsgIdFn h32 xxhash / 1000 bytes	407.00 ns/op	387.00 ns/op	1.05
fastMsgIdFn h64 xxhash / 1000 bytes	453.00 ns/op	447.00 ns/op	1.01
fastMsgIdFn sha256 / 10000 bytes	102.15 us/op	98.111 us/op	1.04
fastMsgIdFn h32 xxhash / 10000 bytes	1.9220 us/op	1.8180 us/op	1.06
fastMsgIdFn h64 xxhash / 10000 bytes	1.3730 us/op	1.2890 us/op	1.07
enrSubnets - fastDeserialize 64 bits	1.2530 us/op	1.2050 us/op	1.04
enrSubnets - ssz BitVector 64 bits	479.00 ns/op	456.00 ns/op	1.05
enrSubnets - fastDeserialize 4 bits	167.00 ns/op	158.00 ns/op	1.06
enrSubnets - ssz BitVector 4 bits	484.00 ns/op	461.00 ns/op	1.05
prioritizePeers score -10:0 att 32-0.1 sync 2-0	101.51 us/op	100.23 us/op	1.01
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25	128.02 us/op	125.45 us/op	1.02
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5	164.23 us/op	160.63 us/op	1.02
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75	297.29 us/op	280.82 us/op	1.06
prioritizePeers score 0:0 att 64-1 sync 4-1	368.67 us/op	338.26 us/op	1.09
array of 16000 items push then shift	1.6386 us/op	1.5360 us/op	1.07
LinkedList of 16000 items push then shift	8.7040 ns/op	8.3710 ns/op	1.04
array of 16000 items push then pop	77.656 ns/op	79.064 ns/op	0.98
LinkedList of 16000 items push then pop	8.4080 ns/op	8.4930 ns/op	0.99
array of 24000 items push then shift	2.3067 us/op	2.3361 us/op	0.99
LinkedList of 24000 items push then shift	8.6250 ns/op	8.8050 ns/op	0.98
array of 24000 items push then pop	77.614 ns/op	79.605 ns/op	0.97
LinkedList of 24000 items push then pop	8.2780 ns/op	8.0630 ns/op	1.03
intersect bitArray bitLen 8	12.904 ns/op	12.632 ns/op	1.02
intersect array and set length 8	75.882 ns/op	70.619 ns/op	1.07
intersect bitArray bitLen 128	43.246 ns/op	41.672 ns/op	1.04
intersect array and set length 128	1.0326 us/op	980.01 ns/op	1.05
Buffer.concat 32 items	2.8380 us/op	2.5240 us/op	1.12
Uint8Array.set 32 items	2.7990 us/op	2.8370 us/op	0.99
pass gossip attestations to forkchoice per slot	2.6083 ms/op	2.6728 ms/op	0.98
computeDeltas	2.8715 ms/op	2.8119 ms/op	1.02
computeProposerBoostScoreFromBalances	1.7658 ms/op	1.7826 ms/op	0.99
altair processAttestation - 250000 vs - 7PWei normalcase	2.0248 ms/op	2.3633 ms/op	0.86
altair processAttestation - 250000 vs - 7PWei worstcase	3.1913 ms/op	3.4205 ms/op	0.93
altair processAttestation - setStatus - 1/6 committees join	137.43 us/op	144.53 us/op	0.95
altair processAttestation - setStatus - 1/3 committees join	265.38 us/op	279.62 us/op	0.95
altair processAttestation - setStatus - 1/2 committees join	356.92 us/op	377.93 us/op	0.94
altair processAttestation - setStatus - 2/3 committees join	446.51 us/op	483.49 us/op	0.92
altair processAttestation - setStatus - 4/5 committees join	645.37 us/op	707.35 us/op	0.91
altair processAttestation - setStatus - 100% committees join	768.46 us/op	776.44 us/op	0.99
altair processBlock - 250000 vs - 7PWei normalcase	17.428 ms/op	19.004 ms/op	0.92
altair processBlock - 250000 vs - 7PWei normalcase hashState	24.914 ms/op	25.041 ms/op	0.99
altair processBlock - 250000 vs - 7PWei worstcase	52.720 ms/op	53.380 ms/op	0.99
altair processBlock - 250000 vs - 7PWei worstcase hashState	69.971 ms/op	65.727 ms/op	1.06
phase0 processBlock - 250000 vs - 7PWei normalcase	1.9813 ms/op	2.2050 ms/op	0.90
phase0 processBlock - 250000 vs - 7PWei worstcase	27.684 ms/op	31.327 ms/op	0.88
altair processEth1Data - 250000 vs - 7PWei normalcase	458.32 us/op	483.51 us/op	0.95
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15	6.6870 us/op	8.9090 us/op	0.75
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219	19.315 us/op	25.460 us/op	0.76
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42	8.6980 us/op	13.017 us/op	0.67
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18	6.3840 us/op	10.924 us/op	0.58
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020	73.821 us/op	124.88 us/op	0.59
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777	607.89 us/op	732.18 us/op	0.83
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384	892.79 us/op	925.63 us/op	0.96
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384	883.98 us/op	910.09 us/op	0.97
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384	2.2037 ms/op	2.7347 ms/op	0.81
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384	1.5142 ms/op	1.6738 ms/op	0.90
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384	3.7346 ms/op	4.1563 ms/op	0.90
Tree 40 250000 create	297.29 ms/op	376.13 ms/op	0.79
Tree 40 250000 get(125000)	175.51 ns/op	201.52 ns/op	0.87
Tree 40 250000 set(125000)	915.56 ns/op	998.72 ns/op	0.92
Tree 40 250000 toArray()	17.333 ms/op	22.264 ms/op	0.78
Tree 40 250000 iterate all - toArray() + loop	17.191 ms/op	22.701 ms/op	0.76
Tree 40 250000 iterate all - get(i)	65.604 ms/op	77.749 ms/op	0.84
MutableVector 250000 create	10.647 ms/op	12.099 ms/op	0.88
MutableVector 250000 get(125000)	6.0450 ns/op	6.5880 ns/op	0.92
MutableVector 250000 set(125000)	246.02 ns/op	321.58 ns/op	0.77
MutableVector 250000 toArray()	2.6599 ms/op	4.1429 ms/op	0.64
MutableVector 250000 iterate all - toArray() + loop	2.8715 ms/op	4.3315 ms/op	0.66
MutableVector 250000 iterate all - get(i)	1.4794 ms/op	1.6103 ms/op	0.92
Array 250000 create	2.7027 ms/op	4.1108 ms/op	0.66
Array 250000 clone - spread	1.0696 ms/op	1.1696 ms/op	0.91
Array 250000 get(125000)	0.51300 ns/op	0.58300 ns/op	0.88
Array 250000 set(125000)	0.59800 ns/op	0.67500 ns/op	0.89
Array 250000 iterate all - loop	86.369 us/op	91.349 us/op	0.95
effectiveBalanceIncrements clone Uint8Array 300000	23.240 us/op	43.159 us/op	0.54
effectiveBalanceIncrements clone MutableVector 300000	315.00 ns/op	367.00 ns/op	0.86
effectiveBalanceIncrements rw all Uint8Array 300000	163.44 us/op	187.34 us/op	0.87
effectiveBalanceIncrements rw all MutableVector 300000	75.729 ms/op	88.947 ms/op	0.85
phase0 afterProcessEpoch - 250000 vs - 7PWei	110.51 ms/op	119.16 ms/op	0.93
phase0 beforeProcessEpoch - 250000 vs - 7PWei	40.375 ms/op	44.517 ms/op	0.91
altair processEpoch - mainnet_e81889	322.64 ms/op	362.57 ms/op	0.89
mainnet_e81889 - altair beforeProcessEpoch	63.025 ms/op	51.475 ms/op	1.22
mainnet_e81889 - altair processJustificationAndFinalization	17.371 us/op	18.967 us/op	0.92
mainnet_e81889 - altair processInactivityUpdates	5.3821 ms/op	6.1837 ms/op	0.87
mainnet_e81889 - altair processRewardsAndPenalties	65.864 ms/op	69.058 ms/op	0.95
mainnet_e81889 - altair processRegistryUpdates	2.8230 us/op	2.6950 us/op	1.05
mainnet_e81889 - altair processSlashings	500.00 ns/op	491.00 ns/op	1.02
mainnet_e81889 - altair processEth1DataReset	587.00 ns/op	553.00 ns/op	1.06
mainnet_e81889 - altair processEffectiveBalanceUpdates	1.5053 ms/op	1.2691 ms/op	1.19
mainnet_e81889 - altair processSlashingsReset	3.5590 us/op	3.9880 us/op	0.89
mainnet_e81889 - altair processRandaoMixesReset	4.4260 us/op	5.6540 us/op	0.78
mainnet_e81889 - altair processHistoricalRootsUpdate	639.00 ns/op	924.00 ns/op	0.69
mainnet_e81889 - altair processParticipationFlagUpdates	2.2790 us/op	2.9800 us/op	0.76
mainnet_e81889 - altair processSyncCommitteeUpdates	467.00 ns/op	619.00 ns/op	0.75
mainnet_e81889 - altair afterProcessEpoch	122.37 ms/op	128.62 ms/op	0.95
phase0 processEpoch - mainnet_e58758	344.92 ms/op	353.39 ms/op	0.98
mainnet_e58758 - phase0 beforeProcessEpoch	129.15 ms/op	131.68 ms/op	0.98
mainnet_e58758 - phase0 processJustificationAndFinalization	16.102 us/op	17.441 us/op	0.92
mainnet_e58758 - phase0 processRewardsAndPenalties	63.682 ms/op	64.524 ms/op	0.99
mainnet_e58758 - phase0 processRegistryUpdates	7.7650 us/op	8.1390 us/op	0.95
mainnet_e58758 - phase0 processSlashings	483.00 ns/op	525.00 ns/op	0.92
mainnet_e58758 - phase0 processEth1DataReset	505.00 ns/op	721.00 ns/op	0.70
mainnet_e58758 - phase0 processEffectiveBalanceUpdates	1.2575 ms/op	1.4524 ms/op	0.87
mainnet_e58758 - phase0 processSlashingsReset	4.2130 us/op	3.6180 us/op	1.16
mainnet_e58758 - phase0 processRandaoMixesReset	4.6960 us/op	4.5520 us/op	1.03
mainnet_e58758 - phase0 processHistoricalRootsUpdate	652.00 ns/op	719.00 ns/op	0.91
mainnet_e58758 - phase0 processParticipationRecordUpdates	3.7340 us/op	4.0350 us/op	0.93
mainnet_e58758 - phase0 afterProcessEpoch	94.592 ms/op	97.697 ms/op	0.97
phase0 processEffectiveBalanceUpdates - 250000 normalcase	1.2225 ms/op	1.2280 ms/op	1.00
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5	1.4404 ms/op	1.5045 ms/op	0.96
altair processInactivityUpdates - 250000 normalcase	23.934 ms/op	25.949 ms/op	0.92
altair processInactivityUpdates - 250000 worstcase	25.641 ms/op	26.215 ms/op	0.98
phase0 processRegistryUpdates - 250000 normalcase	6.5900 us/op	6.7790 us/op	0.97
phase0 processRegistryUpdates - 250000 badcase_full_deposits	230.91 us/op	253.02 us/op	0.91
phase0 processRegistryUpdates - 250000 worstcase 0.5	121.79 ms/op	105.09 ms/op	1.16
altair processRewardsAndPenalties - 250000 normalcase	68.581 ms/op	69.839 ms/op	0.98
altair processRewardsAndPenalties - 250000 worstcase	69.736 ms/op	73.917 ms/op	0.94
phase0 getAttestationDeltas - 250000 normalcase	6.4352 ms/op	6.9788 ms/op	0.92
phase0 getAttestationDeltas - 250000 worstcase	6.4128 ms/op	6.9877 ms/op	0.92
phase0 processSlashings - 250000 worstcase	3.4844 ms/op	3.6666 ms/op	0.95
altair processSyncCommitteeUpdates - 250000	165.47 ms/op	185.09 ms/op	0.89
BeaconState.hashTreeRoot - No change	250.00 ns/op	268.00 ns/op	0.93
BeaconState.hashTreeRoot - 1 full validator	51.892 us/op	54.043 us/op	0.96
BeaconState.hashTreeRoot - 32 full validator	517.89 us/op	519.36 us/op	1.00
BeaconState.hashTreeRoot - 512 full validator	4.9286 ms/op	5.7377 ms/op	0.86
BeaconState.hashTreeRoot - 1 validator.effectiveBalance	61.774 us/op	66.341 us/op	0.93
BeaconState.hashTreeRoot - 32 validator.effectiveBalance	921.58 us/op	971.42 us/op	0.95
BeaconState.hashTreeRoot - 512 validator.effectiveBalance	11.169 ms/op	12.058 ms/op	0.93
BeaconState.hashTreeRoot - 1 balances	47.437 us/op	51.537 us/op	0.92
BeaconState.hashTreeRoot - 32 balances	431.80 us/op	496.98 us/op	0.87
BeaconState.hashTreeRoot - 512 balances	4.3068 ms/op	4.6157 ms/op	0.93
BeaconState.hashTreeRoot - 250000 balances	70.129 ms/op	79.514 ms/op	0.88
aggregationBits - 2048 els - zipIndexesInBitList	14.870 us/op	16.964 us/op	0.88
regular array get 100000 times	37.691 us/op	33.888 us/op	1.11
wrappedArray get 100000 times	32.240 us/op	33.823 us/op	0.95
arrayWithProxy get 100000 times	15.395 ms/op	17.494 ms/op	0.88
ssz.Root.equals	532.00 ns/op	566.00 ns/op	0.94
byteArrayEquals	520.00 ns/op	556.00 ns/op	0.94
shuffle list - 16384 els	6.7454 ms/op	7.1460 ms/op	0.94
shuffle list - 250000 els	98.679 ms/op	105.77 ms/op	0.93
processSlot - 1 slots	8.4950 us/op	9.4340 us/op	0.90
processSlot - 32 slots	1.2906 ms/op	1.4169 ms/op	0.91
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei	36.465 ms/op	39.315 ms/op	0.93
getCommitteeAssignments - req 1 vs - 250000 vc	2.7577 ms/op	3.0276 ms/op	0.91
getCommitteeAssignments - req 100 vs - 250000 vc	3.9116 ms/op	4.3820 ms/op	0.89
getCommitteeAssignments - req 1000 vs - 250000 vc	4.2538 ms/op	4.7117 ms/op	0.90
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei	4.7000 ns/op	5.2800 ns/op	0.89
state getBlockRootAtSlot - 250000 vs - 7PWei	711.59 ns/op	775.01 ns/op	0.92
computeProposers - vc 250000	10.242 ms/op	11.738 ms/op	0.87
computeEpochShuffling - vc 250000	103.41 ms/op	110.06 ms/op	0.94
getNextSyncCommittee - vc 250000	169.78 ms/op	189.04 ms/op	0.90
computeSigningRoot for AttestationData	12.946 us/op	13.706 us/op	0.94
hash AttestationData serialized data then Buffer.toString(base64)	2.4087 us/op	2.5687 us/op	0.94
toHexString serialized data	1.0499 us/op	1.2000 us/op	0.87
Buffer.toString(base64)	324.81 ns/op	348.38 ns/op	0.93

by benchmarkbot/action

[wemeetagain]

🎉 This PR is included in v1.9.0 🎉