-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use proper state to verify attestations #5500
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
bf74eae
to
508274f
Compare
Tested for some days on a mainnet node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove stale comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in v1.9.0 🎉 |
Motivation
Right now we always use head state to verify attestations
Description
We should only use head block state if:
otherwise we should use head state dialed to target epoch. Notice that with
maxSkippedSlot=32
we'll always use head state unless it's at epoch boundaryAlso add some metrics to monitor slot distances in attestation
Closes #5498 Closes #4831
TODOs