Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dashboard panels with outdated metric queries #5502

Merged
merged 1 commit into from
May 17, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented May 17, 2023

Motivation

Looked through metrics and fixed few metric queries along the way.

Description

Some metrics were changed from gauge to histogram but the queries in the dashboards were not updated

Other updates are related to panels where we have a old and a new metric queries, just removed the old one as it should no longer be relevant at this point (updated Sep 1, 2022).

@nflaig nflaig requested a review from a team as a code owner May 17, 2023 13:28
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: e383d23 Previous: 1602f67 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.1279 ms/op 630.64 us/op 1.79
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 66.790 us/op 46.936 us/op 1.42
BLS verify - blst-native 1.5063 ms/op 1.2233 ms/op 1.23
BLS verifyMultipleSignatures 3 - blst-native 2.9542 ms/op 2.4936 ms/op 1.18
BLS verifyMultipleSignatures 8 - blst-native 5.9443 ms/op 5.3491 ms/op 1.11
BLS verifyMultipleSignatures 32 - blst-native 20.677 ms/op 19.367 ms/op 1.07
BLS aggregatePubkeys 32 - blst-native 28.936 us/op 25.999 us/op 1.11
BLS aggregatePubkeys 128 - blst-native 115.93 us/op 101.47 us/op 1.14
getAttestationsForBlock 64.255 ms/op 64.347 ms/op 1.00
isKnown best case - 1 super set check 281.00 ns/op 276.00 ns/op 1.02
isKnown normal case - 2 super set checks 274.00 ns/op 260.00 ns/op 1.05
isKnown worse case - 16 super set checks 263.00 ns/op 259.00 ns/op 1.02
CheckpointStateCache - add get delete 6.3040 us/op 5.4730 us/op 1.15
validate gossip signedAggregateAndProof - struct 2.8912 ms/op 2.8103 ms/op 1.03
validate gossip attestation - struct 1.5792 ms/op 1.3659 ms/op 1.16
pickEth1Vote - no votes 1.7342 ms/op 1.4015 ms/op 1.24
pickEth1Vote - max votes 11.877 ms/op 11.239 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.230 ms/op 9.6553 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 17.655 ms/op 15.691 ms/op 1.13
pickEth1Vote - Eth1Data fastSerialize value x2048 820.69 us/op 670.59 us/op 1.22
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.6002 ms/op 6.5932 ms/op 1.00
bytes32 toHexString 646.00 ns/op 493.00 ns/op 1.31
bytes32 Buffer.toString(hex) 451.00 ns/op 344.00 ns/op 1.31
bytes32 Buffer.toString(hex) from Uint8Array 647.00 ns/op 565.00 ns/op 1.15
bytes32 Buffer.toString(hex) + 0x 461.00 ns/op 360.00 ns/op 1.28
Object access 1 prop 0.20700 ns/op 0.17300 ns/op 1.20
Map access 1 prop 0.18000 ns/op 0.17700 ns/op 1.02
Object get x1000 7.3710 ns/op 7.6670 ns/op 0.96
Map get x1000 0.69300 ns/op 0.61500 ns/op 1.13
Object set x1000 60.970 ns/op 63.167 ns/op 0.97
Map set x1000 53.578 ns/op 44.455 ns/op 1.21
Return object 10000 times 0.26580 ns/op 0.23910 ns/op 1.11
Throw Error 10000 times 4.4013 us/op 4.2676 us/op 1.03
fastMsgIdFn sha256 / 200 bytes 3.6470 us/op 3.5620 us/op 1.02
fastMsgIdFn h32 xxhash / 200 bytes 326.00 ns/op 282.00 ns/op 1.16
fastMsgIdFn h64 xxhash / 200 bytes 456.00 ns/op 409.00 ns/op 1.11
fastMsgIdFn sha256 / 1000 bytes 12.344 us/op 11.712 us/op 1.05
fastMsgIdFn h32 xxhash / 1000 bytes 461.00 ns/op 422.00 ns/op 1.09
fastMsgIdFn h64 xxhash / 1000 bytes 554.00 ns/op 490.00 ns/op 1.13
fastMsgIdFn sha256 / 10000 bytes 109.69 us/op 105.39 us/op 1.04
fastMsgIdFn h32 xxhash / 10000 bytes 2.0580 us/op 1.9770 us/op 1.04
fastMsgIdFn h64 xxhash / 10000 bytes 1.5140 us/op 1.3970 us/op 1.08
enrSubnets - fastDeserialize 64 bits 1.6450 us/op 1.3240 us/op 1.24
enrSubnets - ssz BitVector 64 bits 629.00 ns/op 514.00 ns/op 1.22
enrSubnets - fastDeserialize 4 bits 221.00 ns/op 172.00 ns/op 1.28
enrSubnets - ssz BitVector 4 bits 629.00 ns/op 531.00 ns/op 1.18
prioritizePeers score -10:0 att 32-0.1 sync 2-0 116.81 us/op 110.73 us/op 1.05
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 162.79 us/op 137.95 us/op 1.18
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 205.47 us/op 189.51 us/op 1.08
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 381.22 us/op 337.41 us/op 1.13
prioritizePeers score 0:0 att 64-1 sync 4-1 445.37 us/op 413.75 us/op 1.08
array of 16000 items push then shift 1.7355 us/op 1.6905 us/op 1.03
LinkedList of 16000 items push then shift 9.3110 ns/op 9.3430 ns/op 1.00
array of 16000 items push then pop 117.46 ns/op 109.14 ns/op 1.08
LinkedList of 16000 items push then pop 9.9450 ns/op 9.0290 ns/op 1.10
array of 24000 items push then shift 2.4786 us/op 2.4070 us/op 1.03
LinkedList of 24000 items push then shift 10.681 ns/op 9.5870 ns/op 1.11
array of 24000 items push then pop 85.052 ns/op 92.390 ns/op 0.92
LinkedList of 24000 items push then pop 9.8590 ns/op 9.2060 ns/op 1.07
intersect bitArray bitLen 8 13.827 ns/op 13.771 ns/op 1.00
intersect array and set length 8 102.76 ns/op 84.476 ns/op 1.22
intersect bitArray bitLen 128 45.543 ns/op 45.057 ns/op 1.01
intersect array and set length 128 1.2646 us/op 1.1600 us/op 1.09
Buffer.concat 32 items 3.2510 us/op 2.8830 us/op 1.13
Uint8Array.set 32 items 2.4700 us/op 2.3430 us/op 1.05
pass gossip attestations to forkchoice per slot 2.4021 ms/op 2.3937 ms/op 1.00
computeDeltas 4.4777 ms/op 3.0833 ms/op 1.45
computeProposerBoostScoreFromBalances 1.8269 ms/op 1.8290 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 2.4350 ms/op 2.9525 ms/op 0.82
altair processAttestation - 250000 vs - 7PWei worstcase 3.6355 ms/op 4.2302 ms/op 0.86
altair processAttestation - setStatus - 1/6 committees join 146.03 us/op 145.42 us/op 1.00
altair processAttestation - setStatus - 1/3 committees join 286.83 us/op 295.72 us/op 0.97
altair processAttestation - setStatus - 1/2 committees join 385.68 us/op 386.23 us/op 1.00
altair processAttestation - setStatus - 2/3 committees join 486.07 us/op 490.38 us/op 0.99
altair processAttestation - setStatus - 4/5 committees join 689.45 us/op 697.87 us/op 0.99
altair processAttestation - setStatus - 100% committees join 803.90 us/op 818.04 us/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase 19.376 ms/op 20.112 ms/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase hashState 27.966 ms/op 30.417 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 60.196 ms/op 56.604 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase hashState 77.455 ms/op 74.745 ms/op 1.04
phase0 processBlock - 250000 vs - 7PWei normalcase 2.1824 ms/op 2.1121 ms/op 1.03
phase0 processBlock - 250000 vs - 7PWei worstcase 31.335 ms/op 31.217 ms/op 1.00
altair processEth1Data - 250000 vs - 7PWei normalcase 544.74 us/op 556.63 us/op 0.98
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 8.6090 us/op 9.4260 us/op 0.91
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 29.795 us/op 29.673 us/op 1.00
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 11.404 us/op 10.559 us/op 1.08
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 8.2760 us/op 7.9540 us/op 1.04
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 103.61 us/op 118.10 us/op 0.88
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 784.58 us/op 777.35 us/op 1.01
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 1.0632 ms/op 1.0613 ms/op 1.00
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 1.0471 ms/op 1.0182 ms/op 1.03
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.4313 ms/op 2.4917 ms/op 0.98
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.8681 ms/op 1.6340 ms/op 1.14
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 4.0327 ms/op 4.2136 ms/op 0.96
Tree 40 250000 create 326.09 ms/op 433.02 ms/op 0.75
Tree 40 250000 get(125000) 195.47 ns/op 194.75 ns/op 1.00
Tree 40 250000 set(125000) 1.0428 us/op 1.0200 us/op 1.02
Tree 40 250000 toArray() 22.219 ms/op 21.627 ms/op 1.03
Tree 40 250000 iterate all - toArray() + loop 21.528 ms/op 22.368 ms/op 0.96
Tree 40 250000 iterate all - get(i) 75.565 ms/op 74.799 ms/op 1.01
MutableVector 250000 create 12.429 ms/op 14.199 ms/op 0.88
MutableVector 250000 get(125000) 6.8170 ns/op 7.0750 ns/op 0.96
MutableVector 250000 set(125000) 252.40 ns/op 353.07 ns/op 0.71
MutableVector 250000 toArray() 3.2641 ms/op 3.8956 ms/op 0.84
MutableVector 250000 iterate all - toArray() + loop 3.5905 ms/op 3.5055 ms/op 1.02
MutableVector 250000 iterate all - get(i) 1.5681 ms/op 1.5692 ms/op 1.00
Array 250000 create 3.3273 ms/op 3.3929 ms/op 0.98
Array 250000 clone - spread 1.2103 ms/op 1.3117 ms/op 0.92
Array 250000 get(125000) 0.56800 ns/op 0.64400 ns/op 0.88
Array 250000 set(125000) 0.64700 ns/op 0.68900 ns/op 0.94
Array 250000 iterate all - loop 106.72 us/op 100.37 us/op 1.06
effectiveBalanceIncrements clone Uint8Array 300000 30.624 us/op 36.702 us/op 0.83
effectiveBalanceIncrements clone MutableVector 300000 344.00 ns/op 403.00 ns/op 0.85
effectiveBalanceIncrements rw all Uint8Array 300000 169.25 us/op 174.68 us/op 0.97
effectiveBalanceIncrements rw all MutableVector 300000 95.674 ms/op 95.702 ms/op 1.00
phase0 afterProcessEpoch - 250000 vs - 7PWei 120.61 ms/op 123.89 ms/op 0.97
phase0 beforeProcessEpoch - 250000 vs - 7PWei 47.154 ms/op 42.342 ms/op 1.11
altair processEpoch - mainnet_e81889 361.01 ms/op 371.28 ms/op 0.97
mainnet_e81889 - altair beforeProcessEpoch 79.568 ms/op 78.687 ms/op 1.01
mainnet_e81889 - altair processJustificationAndFinalization 32.267 us/op 24.831 us/op 1.30
mainnet_e81889 - altair processInactivityUpdates 9.7436 ms/op 6.4491 ms/op 1.51
mainnet_e81889 - altair processRewardsAndPenalties 83.798 ms/op 76.295 ms/op 1.10
mainnet_e81889 - altair processRegistryUpdates 7.6010 us/op 3.7760 us/op 2.01
mainnet_e81889 - altair processSlashings 1.2130 us/op 1.1220 us/op 1.08
mainnet_e81889 - altair processEth1DataReset 1.2860 us/op 1.2340 us/op 1.04
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9866 ms/op 1.5343 ms/op 1.29
mainnet_e81889 - altair processSlashingsReset 8.6450 us/op 7.3000 us/op 1.18
mainnet_e81889 - altair processRandaoMixesReset 13.872 us/op 8.4850 us/op 1.63
mainnet_e81889 - altair processHistoricalRootsUpdate 2.4340 us/op 1.7210 us/op 1.41
mainnet_e81889 - altair processParticipationFlagUpdates 7.5710 us/op 3.6740 us/op 2.06
mainnet_e81889 - altair processSyncCommitteeUpdates 1.4560 us/op 942.00 ns/op 1.55
mainnet_e81889 - altair afterProcessEpoch 168.48 ms/op 133.49 ms/op 1.26
phase0 processEpoch - mainnet_e58758 469.31 ms/op 454.26 ms/op 1.03
mainnet_e58758 - phase0 beforeProcessEpoch 249.25 ms/op 219.37 ms/op 1.14
mainnet_e58758 - phase0 processJustificationAndFinalization 40.686 us/op 30.516 us/op 1.33
mainnet_e58758 - phase0 processRewardsAndPenalties 76.895 ms/op 74.718 ms/op 1.03
mainnet_e58758 - phase0 processRegistryUpdates 15.444 us/op 12.882 us/op 1.20
mainnet_e58758 - phase0 processSlashings 888.00 ns/op 1.0190 us/op 0.87
mainnet_e58758 - phase0 processEth1DataReset 1.1570 us/op 1.0980 us/op 1.05
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.9894 ms/op 1.3750 ms/op 1.45
mainnet_e58758 - phase0 processSlashingsReset 8.0830 us/op 7.0330 us/op 1.15
mainnet_e58758 - phase0 processRandaoMixesReset 7.1160 us/op 9.1860 us/op 0.77
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.4490 us/op 1.4510 us/op 1.00
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.5810 us/op 11.301 us/op 0.67
mainnet_e58758 - phase0 afterProcessEpoch 112.24 ms/op 115.31 ms/op 0.97
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.0140 ms/op 1.5469 ms/op 1.30
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.0591 ms/op 1.9287 ms/op 1.07
altair processInactivityUpdates - 250000 normalcase 28.465 ms/op 28.802 ms/op 0.99
altair processInactivityUpdates - 250000 worstcase 27.057 ms/op 30.741 ms/op 0.88
phase0 processRegistryUpdates - 250000 normalcase 10.376 us/op 10.647 us/op 0.97
phase0 processRegistryUpdates - 250000 badcase_full_deposits 340.89 us/op 376.08 us/op 0.91
phase0 processRegistryUpdates - 250000 worstcase 0.5 149.74 ms/op 140.94 ms/op 1.06
altair processRewardsAndPenalties - 250000 normalcase 73.061 ms/op 78.214 ms/op 0.93
altair processRewardsAndPenalties - 250000 worstcase 72.742 ms/op 93.113 ms/op 0.78
phase0 getAttestationDeltas - 250000 normalcase 7.9279 ms/op 10.671 ms/op 0.74
phase0 getAttestationDeltas - 250000 worstcase 7.0331 ms/op 9.8250 ms/op 0.72
phase0 processSlashings - 250000 worstcase 3.5358 ms/op 4.3182 ms/op 0.82
altair processSyncCommitteeUpdates - 250000 207.46 ms/op 217.03 ms/op 0.96
BeaconState.hashTreeRoot - No change 355.00 ns/op 312.00 ns/op 1.14
BeaconState.hashTreeRoot - 1 full validator 55.989 us/op 63.766 us/op 0.88
BeaconState.hashTreeRoot - 32 full validator 580.34 us/op 596.72 us/op 0.97
BeaconState.hashTreeRoot - 512 full validator 5.9679 ms/op 6.5059 ms/op 0.92
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 67.639 us/op 68.710 us/op 0.98
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 964.56 us/op 984.33 us/op 0.98
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.642 ms/op 16.077 ms/op 0.85
BeaconState.hashTreeRoot - 1 balances 55.748 us/op 53.003 us/op 1.05
BeaconState.hashTreeRoot - 32 balances 541.05 us/op 534.63 us/op 1.01
BeaconState.hashTreeRoot - 512 balances 4.7918 ms/op 4.7708 ms/op 1.00
BeaconState.hashTreeRoot - 250000 balances 81.954 ms/op 84.047 ms/op 0.98
aggregationBits - 2048 els - zipIndexesInBitList 21.859 us/op 19.191 us/op 1.14
regular array get 100000 times 34.390 us/op 43.915 us/op 0.78
wrappedArray get 100000 times 46.671 us/op 34.673 us/op 1.35
arrayWithProxy get 100000 times 16.187 ms/op 17.291 ms/op 0.94
ssz.Root.equals 585.00 ns/op 582.00 ns/op 1.01
byteArrayEquals 583.00 ns/op 584.00 ns/op 1.00
shuffle list - 16384 els 7.1540 ms/op 7.1094 ms/op 1.01
shuffle list - 250000 els 105.54 ms/op 104.32 ms/op 1.01
processSlot - 1 slots 10.911 us/op 13.365 us/op 0.82
processSlot - 32 slots 1.4521 ms/op 1.6532 ms/op 0.88
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 39.944 ms/op 42.212 ms/op 0.95
getCommitteeAssignments - req 1 vs - 250000 vc 3.0314 ms/op 2.9801 ms/op 1.02
getCommitteeAssignments - req 100 vs - 250000 vc 4.2940 ms/op 4.2669 ms/op 1.01
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5475 ms/op 4.5523 ms/op 1.00
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.3000 ns/op 5.0100 ns/op 1.06
state getBlockRootAtSlot - 250000 vs - 7PWei 917.08 ns/op 1.1022 us/op 0.83
computeProposers - vc 250000 11.874 ms/op 10.568 ms/op 1.12
computeEpochShuffling - vc 250000 108.11 ms/op 107.26 ms/op 1.01
getNextSyncCommittee - vc 250000 200.40 ms/op 185.46 ms/op 1.08
computeSigningRoot for AttestationData 15.597 us/op 13.695 us/op 1.14
hash AttestationData serialized data then Buffer.toString(base64) 2.6892 us/op 2.4222 us/op 1.11
toHexString serialized data 1.2701 us/op 1.0524 us/op 1.21
Buffer.toString(base64) 354.36 ns/op 325.72 ns/op 1.09

by benchmarkbot/action

@wemeetagain wemeetagain merged commit c780a1d into unstable May 17, 2023
@wemeetagain wemeetagain deleted the nflaig/fix-broken-dashboard-panels branch May 17, 2023 16:27
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants