Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ens-normalize dependency resolution #5621

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jun 7, 2023

Motivation

Publish to docker hub is broken, see job

Description

Resolve ens-normalize via https instead of git (not installed in docker)

@nflaig nflaig requested a review from a team as a code owner June 7, 2023 22:22
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 0074c1c Previous: 8cd7bd2 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 837.10 us/op 644.25 us/op 1.30
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 45.124 us/op 56.751 us/op 0.80
BLS verify - blst-native 1.1942 ms/op 1.3069 ms/op 0.91
BLS verifyMultipleSignatures 3 - blst-native 2.4275 ms/op 2.6491 ms/op 0.92
BLS verifyMultipleSignatures 8 - blst-native 5.2108 ms/op 5.6152 ms/op 0.93
BLS verifyMultipleSignatures 32 - blst-native 18.154 ms/op 21.078 ms/op 0.86
BLS aggregatePubkeys 32 - blst-native 24.254 us/op 28.129 us/op 0.86
BLS aggregatePubkeys 128 - blst-native 94.525 us/op 108.36 us/op 0.87
getAttestationsForBlock 51.488 ms/op 59.214 ms/op 0.87
isKnown best case - 1 super set check 255.00 ns/op 265.00 ns/op 0.96
isKnown normal case - 2 super set checks 246.00 ns/op 262.00 ns/op 0.94
isKnown worse case - 16 super set checks 242.00 ns/op 258.00 ns/op 0.94
CheckpointStateCache - add get delete 4.8330 us/op 5.2410 us/op 0.92
validate gossip signedAggregateAndProof - struct 2.7135 ms/op 2.8652 ms/op 0.95
validate gossip attestation - struct 1.2890 ms/op 1.3757 ms/op 0.94
pickEth1Vote - no votes 1.2157 ms/op 1.3506 ms/op 0.90
pickEth1Vote - max votes 9.4678 ms/op 10.005 ms/op 0.95
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.3956 ms/op 9.4051 ms/op 0.89
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.670 ms/op 15.455 ms/op 0.95
pickEth1Vote - Eth1Data fastSerialize value x2048 603.57 us/op 703.00 us/op 0.86
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.3655 ms/op 7.5751 ms/op 0.97
bytes32 toHexString 482.00 ns/op 566.00 ns/op 0.85
bytes32 Buffer.toString(hex) 336.00 ns/op 419.00 ns/op 0.80
bytes32 Buffer.toString(hex) from Uint8Array 531.00 ns/op 625.00 ns/op 0.85
bytes32 Buffer.toString(hex) + 0x 340.00 ns/op 417.00 ns/op 0.82
Object access 1 prop 0.16600 ns/op 0.18600 ns/op 0.89
Map access 1 prop 0.16100 ns/op 0.16700 ns/op 0.96
Object get x1000 6.7050 ns/op 7.0430 ns/op 0.95
Map get x1000 0.60400 ns/op 0.67700 ns/op 0.89
Object set x1000 50.792 ns/op 61.201 ns/op 0.83
Map set x1000 42.854 ns/op 46.577 ns/op 0.92
Return object 10000 times 0.23480 ns/op 0.24670 ns/op 0.95
Throw Error 10000 times 4.1512 us/op 4.4260 us/op 0.94
fastMsgIdFn sha256 / 200 bytes 3.3760 us/op 3.6100 us/op 0.94
fastMsgIdFn h32 xxhash / 200 bytes 292.00 ns/op 299.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 200 bytes 394.00 ns/op 416.00 ns/op 0.95
fastMsgIdFn sha256 / 1000 bytes 11.424 us/op 12.130 us/op 0.94
fastMsgIdFn h32 xxhash / 1000 bytes 405.00 ns/op 441.00 ns/op 0.92
fastMsgIdFn h64 xxhash / 1000 bytes 469.00 ns/op 491.00 ns/op 0.96
fastMsgIdFn sha256 / 10000 bytes 102.18 us/op 107.49 us/op 0.95
fastMsgIdFn h32 xxhash / 10000 bytes 1.8680 us/op 1.9710 us/op 0.95
fastMsgIdFn h64 xxhash / 10000 bytes 1.3310 us/op 1.4300 us/op 0.93
enrSubnets - fastDeserialize 64 bits 1.2120 us/op 1.4080 us/op 0.86
enrSubnets - ssz BitVector 64 bits 462.00 ns/op 657.00 ns/op 0.70
enrSubnets - fastDeserialize 4 bits 164.00 ns/op 198.00 ns/op 0.83
enrSubnets - ssz BitVector 4 bits 483.00 ns/op 634.00 ns/op 0.76
prioritizePeers score -10:0 att 32-0.1 sync 2-0 101.58 us/op 111.27 us/op 0.91
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 130.53 us/op 151.01 us/op 0.86
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 164.00 us/op 203.37 us/op 0.81
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 305.40 us/op 419.12 us/op 0.73
prioritizePeers score 0:0 att 64-1 sync 4-1 378.41 us/op 491.80 us/op 0.77
array of 16000 items push then shift 1.6121 us/op 1.8356 us/op 0.88
LinkedList of 16000 items push then shift 8.6770 ns/op 9.9290 ns/op 0.87
array of 16000 items push then pop 89.651 ns/op 116.64 ns/op 0.77
LinkedList of 16000 items push then pop 8.3970 ns/op 9.1800 ns/op 0.91
array of 24000 items push then shift 2.3267 us/op 2.4900 us/op 0.93
LinkedList of 24000 items push then shift 8.3410 ns/op 9.4540 ns/op 0.88
array of 24000 items push then pop 70.686 ns/op 86.923 ns/op 0.81
LinkedList of 24000 items push then pop 8.0340 ns/op 9.0940 ns/op 0.88
intersect bitArray bitLen 8 12.631 ns/op 14.116 ns/op 0.89
intersect array and set length 8 74.160 ns/op 94.966 ns/op 0.78
intersect bitArray bitLen 128 41.980 ns/op 46.914 ns/op 0.89
intersect array and set length 128 1.0013 us/op 1.2961 us/op 0.77
Buffer.concat 32 items 2.8410 us/op 3.1980 us/op 0.89
Uint8Array.set 32 items 2.4110 us/op 2.3460 us/op 1.03
transfer serialized Status (84 B) 1.9720 us/op 2.1030 us/op 0.94
copy serialized Status (84 B) 1.6110 us/op 1.7700 us/op 0.91
transfer serialized SignedVoluntaryExit (112 B) 2.0370 us/op 2.1960 us/op 0.93
copy serialized SignedVoluntaryExit (112 B) 1.7570 us/op 1.8710 us/op 0.94
transfer serialized ProposerSlashing (416 B) 2.5310 us/op 2.4490 us/op 1.03
copy serialized ProposerSlashing (416 B) 2.9050 us/op 2.3360 us/op 1.24
transfer serialized Attestation (485 B) 2.4260 us/op 3.2710 us/op 0.74
copy serialized Attestation (485 B) 2.8950 us/op 3.4300 us/op 0.84
transfer serialized AttesterSlashing (33232 B) 2.9660 us/op 3.4810 us/op 0.85
copy serialized AttesterSlashing (33232 B) 5.9690 us/op 7.7130 us/op 0.77
transfer serialized Small SignedBeaconBlock (128000 B) 3.0670 us/op 3.6510 us/op 0.84
copy serialized Small SignedBeaconBlock (128000 B) 13.640 us/op 16.917 us/op 0.81
transfer serialized Avg SignedBeaconBlock (200000 B) 3.0840 us/op 3.8080 us/op 0.81
copy serialized Avg SignedBeaconBlock (200000 B) 28.827 us/op 28.193 us/op 1.02
transfer serialized BlobsSidecar (524380 B) 2.9980 us/op 4.6650 us/op 0.64
copy serialized BlobsSidecar (524380 B) 68.636 us/op 180.57 us/op 0.38
transfer serialized Big SignedBeaconBlock (1000000 B) 3.1840 us/op 4.5270 us/op 0.70
copy serialized Big SignedBeaconBlock (1000000 B) 296.00 us/op 293.47 us/op 1.01
pass gossip attestations to forkchoice per slot 2.6142 ms/op 2.9091 ms/op 0.90
forkChoice updateHead vc 100000 bc 64 eq 0 2.0606 ms/op 2.3921 ms/op 0.86
forkChoice updateHead vc 600000 bc 64 eq 0 11.585 ms/op 15.365 ms/op 0.75
forkChoice updateHead vc 1000000 bc 64 eq 0 21.509 ms/op 21.255 ms/op 1.01
forkChoice updateHead vc 600000 bc 320 eq 0 16.850 ms/op 16.950 ms/op 0.99
forkChoice updateHead vc 600000 bc 1200 eq 0 78.913 ms/op 86.492 ms/op 0.91
forkChoice updateHead vc 600000 bc 64 eq 1000 20.403 ms/op 22.101 ms/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 10000 21.914 ms/op 25.902 ms/op 0.85
forkChoice updateHead vc 600000 bc 64 eq 300000 30.700 ms/op 33.588 ms/op 0.91
computeDeltas 4.0072 ms/op 3.6844 ms/op 1.09
computeProposerBoostScoreFromBalances 1.7475 ms/op 2.0319 ms/op 0.86
altair processAttestation - 250000 vs - 7PWei normalcase 2.1211 ms/op 3.9698 ms/op 0.53
altair processAttestation - 250000 vs - 7PWei worstcase 3.5343 ms/op 6.0506 ms/op 0.58
altair processAttestation - setStatus - 1/6 committees join 136.98 us/op 175.84 us/op 0.78
altair processAttestation - setStatus - 1/3 committees join 271.67 us/op 358.13 us/op 0.76
altair processAttestation - setStatus - 1/2 committees join 361.06 us/op 498.93 us/op 0.72
altair processAttestation - setStatus - 2/3 committees join 449.54 us/op 671.45 us/op 0.67
altair processAttestation - setStatus - 4/5 committees join 638.49 us/op 1.0259 ms/op 0.62
altair processAttestation - setStatus - 100% committees join 743.47 us/op 954.50 us/op 0.78
altair processBlock - 250000 vs - 7PWei normalcase 17.968 ms/op 22.935 ms/op 0.78
altair processBlock - 250000 vs - 7PWei normalcase hashState 24.270 ms/op 32.902 ms/op 0.74
altair processBlock - 250000 vs - 7PWei worstcase 51.246 ms/op 60.730 ms/op 0.84
altair processBlock - 250000 vs - 7PWei worstcase hashState 67.169 ms/op 92.233 ms/op 0.73
phase0 processBlock - 250000 vs - 7PWei normalcase 2.0224 ms/op 2.8715 ms/op 0.70
phase0 processBlock - 250000 vs - 7PWei worstcase 27.693 ms/op 39.665 ms/op 0.70
altair processEth1Data - 250000 vs - 7PWei normalcase 459.33 us/op 936.73 us/op 0.49
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 6.8410 us/op 19.314 us/op 0.35
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 19.717 us/op 40.138 us/op 0.49
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 9.1570 us/op 15.604 us/op 0.59
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.5050 us/op 7.8770 us/op 0.83
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 74.609 us/op 95.086 us/op 0.78
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 610.96 us/op 1.0161 ms/op 0.60
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 898.95 us/op 1.6515 ms/op 0.54
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 866.45 us/op 1.0128 ms/op 0.86
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.3808 ms/op 4.2230 ms/op 0.56
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.4593 ms/op 1.9616 ms/op 0.74
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9360 ms/op 6.9463 ms/op 0.57
Tree 40 250000 create 301.18 ms/op 619.07 ms/op 0.49
Tree 40 250000 get(125000) 178.75 ns/op 228.11 ns/op 0.78
Tree 40 250000 set(125000) 923.39 ns/op 1.9540 us/op 0.47
Tree 40 250000 toArray() 17.151 ms/op 27.646 ms/op 0.62
Tree 40 250000 iterate all - toArray() + loop 17.142 ms/op 28.171 ms/op 0.61
Tree 40 250000 iterate all - get(i) 65.920 ms/op 91.868 ms/op 0.72
MutableVector 250000 create 9.2620 ms/op 17.490 ms/op 0.53
MutableVector 250000 get(125000) 6.3060 ns/op 7.8320 ns/op 0.81
MutableVector 250000 set(125000) 240.26 ns/op 431.96 ns/op 0.56
MutableVector 250000 toArray() 2.6313 ms/op 4.4370 ms/op 0.59
MutableVector 250000 iterate all - toArray() + loop 2.7351 ms/op 4.5969 ms/op 0.59
MutableVector 250000 iterate all - get(i) 1.5014 ms/op 1.7890 ms/op 0.84
Array 250000 create 2.5050 ms/op 4.1885 ms/op 0.60
Array 250000 clone - spread 1.1367 ms/op 1.5167 ms/op 0.75
Array 250000 get(125000) 0.55700 ns/op 1.2650 ns/op 0.44
Array 250000 set(125000) 0.62800 ns/op 1.2620 ns/op 0.50
Array 250000 iterate all - loop 80.958 us/op 134.24 us/op 0.60
effectiveBalanceIncrements clone Uint8Array 300000 29.026 us/op 58.659 us/op 0.49
effectiveBalanceIncrements clone MutableVector 300000 348.00 ns/op 435.00 ns/op 0.80
effectiveBalanceIncrements rw all Uint8Array 300000 166.02 us/op 200.08 us/op 0.83
effectiveBalanceIncrements rw all MutableVector 300000 78.768 ms/op 140.34 ms/op 0.56
phase0 afterProcessEpoch - 250000 vs - 7PWei 110.18 ms/op 135.28 ms/op 0.81
phase0 beforeProcessEpoch - 250000 vs - 7PWei 39.131 ms/op 52.355 ms/op 0.75
altair processEpoch - mainnet_e81889 316.59 ms/op 376.80 ms/op 0.84
mainnet_e81889 - altair beforeProcessEpoch 63.078 ms/op 72.539 ms/op 0.87
mainnet_e81889 - altair processJustificationAndFinalization 17.219 us/op 19.786 us/op 0.87
mainnet_e81889 - altair processInactivityUpdates 5.1732 ms/op 6.5002 ms/op 0.80
mainnet_e81889 - altair processRewardsAndPenalties 66.135 ms/op 73.216 ms/op 0.90
mainnet_e81889 - altair processRegistryUpdates 2.4570 us/op 3.8150 us/op 0.64
mainnet_e81889 - altair processSlashings 485.00 ns/op 600.00 ns/op 0.81
mainnet_e81889 - altair processEth1DataReset 502.00 ns/op 592.00 ns/op 0.85
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2037 ms/op 1.2762 ms/op 0.94
mainnet_e81889 - altair processSlashingsReset 4.5090 us/op 4.8870 us/op 0.92
mainnet_e81889 - altair processRandaoMixesReset 4.5770 us/op 4.7490 us/op 0.96
mainnet_e81889 - altair processHistoricalRootsUpdate 717.00 ns/op 904.00 ns/op 0.79
mainnet_e81889 - altair processParticipationFlagUpdates 2.3220 us/op 2.5880 us/op 0.90
mainnet_e81889 - altair processSyncCommitteeUpdates 507.00 ns/op 800.00 ns/op 0.63
mainnet_e81889 - altair afterProcessEpoch 114.90 ms/op 132.23 ms/op 0.87
phase0 processEpoch - mainnet_e58758 307.51 ms/op 352.40 ms/op 0.87
mainnet_e58758 - phase0 beforeProcessEpoch 119.68 ms/op 118.24 ms/op 1.01
mainnet_e58758 - phase0 processJustificationAndFinalization 16.165 us/op 18.823 us/op 0.86
mainnet_e58758 - phase0 processRewardsAndPenalties 51.925 ms/op 52.739 ms/op 0.98
mainnet_e58758 - phase0 processRegistryUpdates 8.0450 us/op 10.712 us/op 0.75
mainnet_e58758 - phase0 processSlashings 539.00 ns/op 535.00 ns/op 1.01
mainnet_e58758 - phase0 processEth1DataReset 516.00 ns/op 499.00 ns/op 1.03
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 949.83 us/op 1.0572 ms/op 0.90
mainnet_e58758 - phase0 processSlashingsReset 2.9680 us/op 3.5620 us/op 0.83
mainnet_e58758 - phase0 processRandaoMixesReset 4.6930 us/op 5.0310 us/op 0.93
mainnet_e58758 - phase0 processHistoricalRootsUpdate 676.00 ns/op 1.1830 us/op 0.57
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9710 us/op 6.2500 us/op 0.64
mainnet_e58758 - phase0 afterProcessEpoch 93.933 ms/op 106.95 ms/op 0.88
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2210 ms/op 1.3481 ms/op 0.91
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5859 ms/op 1.9510 ms/op 0.81
altair processInactivityUpdates - 250000 normalcase 20.075 ms/op 29.245 ms/op 0.69
altair processInactivityUpdates - 250000 worstcase 22.611 ms/op 29.329 ms/op 0.77
phase0 processRegistryUpdates - 250000 normalcase 6.1080 us/op 8.7280 us/op 0.70
phase0 processRegistryUpdates - 250000 badcase_full_deposits 235.18 us/op 274.71 us/op 0.86
phase0 processRegistryUpdates - 250000 worstcase 0.5 107.71 ms/op 214.14 ms/op 0.50
altair processRewardsAndPenalties - 250000 normalcase 53.649 ms/op 110.96 ms/op 0.48
altair processRewardsAndPenalties - 250000 worstcase 56.130 ms/op 115.52 ms/op 0.49
phase0 getAttestationDeltas - 250000 normalcase 6.4516 ms/op 14.163 ms/op 0.46
phase0 getAttestationDeltas - 250000 worstcase 6.2939 ms/op 14.626 ms/op 0.43
phase0 processSlashings - 250000 worstcase 3.5221 ms/op 7.7217 ms/op 0.46
altair processSyncCommitteeUpdates - 250000 169.48 ms/op 277.96 ms/op 0.61
BeaconState.hashTreeRoot - No change 250.00 ns/op 428.00 ns/op 0.58
BeaconState.hashTreeRoot - 1 full validator 50.220 us/op 57.458 us/op 0.87
BeaconState.hashTreeRoot - 32 full validator 501.83 us/op 629.22 us/op 0.80
BeaconState.hashTreeRoot - 512 full validator 5.5458 ms/op 5.8717 ms/op 0.94
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 59.837 us/op 69.367 us/op 0.86
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 826.89 us/op 1.0299 ms/op 0.80
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.088 ms/op 12.981 ms/op 0.85
BeaconState.hashTreeRoot - 1 balances 52.935 us/op 53.151 us/op 1.00
BeaconState.hashTreeRoot - 32 balances 423.08 us/op 520.17 us/op 0.81
BeaconState.hashTreeRoot - 512 balances 4.0987 ms/op 5.7600 ms/op 0.71
BeaconState.hashTreeRoot - 250000 balances 71.656 ms/op 84.182 ms/op 0.85
aggregationBits - 2048 els - zipIndexesInBitList 15.607 us/op 18.301 us/op 0.85
regular array get 100000 times 42.326 us/op 46.177 us/op 0.92
wrappedArray get 100000 times 39.230 us/op 35.574 us/op 1.10
arrayWithProxy get 100000 times 15.605 ms/op 18.178 ms/op 0.86
ssz.Root.equals 532.00 ns/op 682.00 ns/op 0.78
byteArrayEquals 519.00 ns/op 639.00 ns/op 0.81
shuffle list - 16384 els 6.7574 ms/op 9.2437 ms/op 0.73
shuffle list - 250000 els 98.268 ms/op 136.72 ms/op 0.72
processSlot - 1 slots 8.5400 us/op 14.795 us/op 0.58
processSlot - 32 slots 1.3485 ms/op 2.1159 ms/op 0.64
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 31.873 ms/op 47.592 ms/op 0.67
getCommitteeAssignments - req 1 vs - 250000 vc 2.8555 ms/op 3.7811 ms/op 0.76
getCommitteeAssignments - req 100 vs - 250000 vc 4.0150 ms/op 5.2540 ms/op 0.76
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3211 ms/op 6.0226 ms/op 0.72
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.2100 ns/op 6.5000 ns/op 0.65
state getBlockRootAtSlot - 250000 vs - 7PWei 845.75 ns/op 1.2094 us/op 0.70
computeProposers - vc 250000 10.307 ms/op 14.751 ms/op 0.70
computeEpochShuffling - vc 250000 100.47 ms/op 148.42 ms/op 0.68
getNextSyncCommittee - vc 250000 168.72 ms/op 256.38 ms/op 0.66
computeSigningRoot for AttestationData 13.472 us/op 19.620 us/op 0.69
hash AttestationData serialized data then Buffer.toString(base64) 2.4196 us/op 3.3184 us/op 0.73
toHexString serialized data 1.0602 us/op 1.9057 us/op 0.56
Buffer.toString(base64) 309.28 ns/op 473.02 ns/op 0.65

by benchmarkbot/action

@wemeetagain wemeetagain merged commit f428747 into unstable Jun 8, 2023
@wemeetagain wemeetagain deleted the nflaig/fix-dependency-resolution branch June 8, 2023 14:12
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants