feat: persist network thread profile #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Jun 12, 2023
| @@ -125,6 +129,7 @@ export type Api = { | |||
| */ | |||
| export const routesData: RoutesData<Api> = { | |||
| writeHeapdump: {url: "/eth/v1/lodestar/writeheapdump", method: "POST"}, | |||
| writeNetworkThreadProfile: {url: "/eth/v1/lodestar/writenetworkthreadprofile", method: "POST"}, | |||
There was a problem hiding this comment.
Every route uses different styles:
someroutesome-routesome_route<- let's use this one here to align with beacon APIs https://github.com/ethereum/beacon-APIs/blob/master/beacon-node-oapi.yaml
Suggested change
| writeNetworkThreadProfile: {url: "/eth/v1/lodestar/writenetworkthreadprofile", method: "POST"}, | |
| writeNetworkThreadProfile: {url: "/eth/v1/lodestar/write_network_thread_profile", method: "POST"}, |
I can PR for the rest after merging this PR
dapplion
reviewed
Jun 12, 2023
|
|
||
| session.post("Profiler.enable", () => { | ||
| session.post("Profiler.start", async () => { | ||
| await sleep(DEFAULT_PROFILE_DURATION); |
There was a problem hiding this comment.
This should be a optional parameter of the route defaulting to 1 epoch
dapplion
reviewed
Jun 12, 2023
| @@ -147,6 +149,12 @@ const libp2pWorkerApi: NetworkWorkerApi = { | |||
| dumpGossipPeerScoreStats: () => core.dumpGossipPeerScoreStats(), | |||
| dumpDiscv5KadValues: () => core.dumpDiscv5KadValues(), | |||
| dumpMeshPeers: () => core.dumpMeshPeers(), | |||
| writeProfile: async (dirpath = ".") => { | |||
| const profile = await profileNodeJS(); | |||
| const filePath = `${dirpath}/network_thread_${new Date().toISOString()}.cpuprofile`; | |||
There was a problem hiding this comment.
Use path.join for concatenation, or path.resolve if you need an absolute path
wemeetagain
approved these changes
Jun 13, 2023
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
node:inspectormodule to persist network thread profilepart of #5604