feat: verify gossip attestation messages in batch #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
|
one trade off is "prometheus scrape duration" metric, it's ~80ms compare to ~25ms in feat1 mostly because we aggregate signatures on the main thread:
also the beacon block "time until head" is the same |
twoeths
changed the title
wemeetagain
reviewed
Aug 21, 2023
| attestationOrBytesArr: AttestationOrBytes[], | ||
| subnet: number, | ||
| // for unit test, consumers do not need to pass this | ||
| phase0ValidationFn = validateGossipAttestationNoSignatureCheck |
There was a problem hiding this comment.
Unless this is talking about the phase0 fork, would recommend changing this language to "step 0", "step 1", etc.
dapplion
reviewed
Aug 21, 2023
| @@ -133,7 +133,8 @@ export class BlsMultiThreadWorkerPool implements IBlsVerifier { | |||
| // THe worker is not able to deserialize from uncompressed | |||
| // `Error: err _wrapDeserialize` | |||
| this.format = implementation === "blst-native" ? PointFormat.uncompressed : PointFormat.compressed; | |||
| this.workers = this.createWorkers(implementation, defaultPoolSize); | |||
| // 1 worker for the main thread | |||
| this.workers = this.createWorkers(implementation, defaultPoolSize - 1); | |||
There was a problem hiding this comment.
Check above that defaultPoolSize is greater than 1
| this.lastWaitTimeCheckedMs = now; | ||
| this.nextWaitTimeMs = null; | ||
| let resultedKey: string | null = null; | ||
| for (const key of this.indexedItems.keys()) { |
There was a problem hiding this comment.
Iterate by entries so you don't have to do a get below
| @@ -18,28 +29,33 @@ import {GossipQueue, IndexedGossipQueueMinSizeOpts} from "./types.js"; | |||
| */ | |||
| export class IndexedGossipQueueMinSize<T extends {indexed?: string}> implements GossipQueue<T> { | |||
There was a problem hiding this comment.
if not already you should collect this metrics when the node is scraped:
- Total count of unique data strings in the cache
- Total count of individual attestations in the cache
- Current histogram (reset, iterate, observe; like we do in the peer manager) of how long each data has been in the queue since addition
- Histogram of the age of a data when it is picked by the processor
There was a problem hiding this comment.
added missing metrics 👍
dapplion
approved these changes
Aug 22, 2023
This was referenced Aug 22, 2023
|
🎉 This PR is included in v1.11.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
subscribeAllSubnetsmodeDescription
50mswait time for each key if key size is <= 32 to allow batch more attestationsuseWorker=true) because it blocks main thread to aggregate signatures, so implementednetwork.beaconAttestationBatchValidationundefined|false, it's for backward compatible. In this case it goes withLinearGossipQueueandDefaultGossipHandlersIndexedGossipQueueMinSizeandBatchGossipHandlersCloses #5416
Test result on test mainnet node
featmainnet node (unstable+use_worker=true) there, so the gossipsub bandwidth is the samebeacon_attestationtopic