-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to log validator monitor events as info #6009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice feature
This was referenced Nov 5, 2023
Merged
🎉 This PR is included in v1.12.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5336
Description
Adds new CLI flag
--validatorMonitorLogs
to log validator monitor events as info.Note: This requires metrics to be enabled as currently the validator monitor is tightly coupled to metrics. I looked into decoupling those but it seemed too big of a change just for this feature.
Alternative solution
Instead of adding a new CLI flag to achieve this it would also be possible to set
--logLevelModule="vmon=debug"
. This would log all validator monitor events to stdout as well but it is less explicit and harder to communicate to users that this option exists.Example logs
info: Published unaggregated attestation validator=461942, slot=6618672, committeeIndex=12, subnet=12, sentPeers=6, delaySec=0.0100
info: Published aggregated attestation validator=461942, slot=6618672, committeeIndex=12, sentPeers=45, delaySec=0.0260
info: Attestation is included in aggregate validator=461942, slot=6618672, committeeIndex=12, aggregatorIndex=86682
info: Attestation is included in block validator=461942, slot=6618672, committeeIndex=12, inclusionDistance=1, correctHead=true, participants=189
info: Previous epoch attestation validator=461942, epoch=206832, summary=timely_head
info: Published unaggregated attestation validator=504990, slot=6618658, committeeIndex=23, subnet=23, sentPeers=7, delaySec=0.0140
info: Failed attestation in previous epoch validator=504990, prevEpoch=206833, isPrevSourceAttester=false, isPrevHeadAttester=false, isPrevTargetAttester=false, inclusionDistance=null
info: Previous epoch attestation validator=504990, epoch=206833, summary=no_aggregate_inclusion
info: Previous epoch block proposal validator=462345, slot=6622259, epoch=206945, summary=canonical