Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump libp2p deps #6015

Merged
merged 37 commits into from
Oct 13, 2023
Merged

chore: bump libp2p deps #6015

merged 37 commits into from
Oct 13, 2023

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Oct 2, 2023 •
edited by nazarhussain
Loading

Motivation

CI has been failing due to a bug in @libp2p/tcp. That bug should now be fixed in the latest version.

Description

  • Update all libp2p deps and smooth out the yarn.lock
  • Change test node names to be unique to allow better debugging
  • Fix some tweaks for tests which is not required anymore.

@wemeetagain wemeetagain requested a review from a team as a code owner October 2, 2023 15:28
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: fed4777 Previous: c6291ad Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 448.08 us/op 879.57 us/op 0.51
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 73.673 us/op 90.423 us/op 0.81
BLS verify - blst-native 1.2920 ms/op 1.4411 ms/op 0.90
BLS verifyMultipleSignatures 3 - blst-native 2.6998 ms/op 2.9955 ms/op 0.90
BLS verifyMultipleSignatures 8 - blst-native 5.9234 ms/op 6.7890 ms/op 0.87
BLS verifyMultipleSignatures 32 - blst-native 22.213 ms/op 24.058 ms/op 0.92
BLS verifyMultipleSignatures 64 - blst-native 43.177 ms/op 45.659 ms/op 0.95
BLS verifyMultipleSignatures 128 - blst-native 86.181 ms/op 93.008 ms/op 0.93
BLS deserializing 10000 signatures 874.40 ms/op 947.29 ms/op 0.92
BLS deserializing 100000 signatures 8.8148 s/op 9.3946 s/op 0.94
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3654 ms/op 1.3611 ms/op 1.00
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.4680 ms/op 1.5573 ms/op 0.94
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.2692 ms/op 2.3866 ms/op 0.95
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.4130 ms/op 3.5305 ms/op 0.97
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.3473 ms/op 5.7571 ms/op 1.10
BLS aggregatePubkeys 32 - blst-native 24.944 us/op 26.663 us/op 0.94
BLS aggregatePubkeys 128 - blst-native 97.948 us/op 103.41 us/op 0.95
getAttestationsForBlock 36.375 ms/op 39.618 ms/op 0.92
isKnown best case - 1 super set check 270.00 ns/op 310.00 ns/op 0.87
isKnown normal case - 2 super set checks 273.00 ns/op 296.00 ns/op 0.92
isKnown worse case - 16 super set checks 272.00 ns/op 289.00 ns/op 0.94
CheckpointStateCache - add get delete 4.9490 us/op 5.3340 us/op 0.93
validate api signedAggregateAndProof - struct 2.6881 ms/op 2.8957 ms/op 0.93
validate gossip signedAggregateAndProof - struct 2.7437 ms/op 2.8403 ms/op 0.97
validate gossip attestation - vc 640000 1.3348 ms/op 1.4368 ms/op 0.93
batch validate gossip attestation - vc 640000 - chunk 32 158.71 us/op 172.48 us/op 0.92
batch validate gossip attestation - vc 640000 - chunk 64 137.35 us/op 154.58 us/op 0.89
batch validate gossip attestation - vc 640000 - chunk 128 132.16 us/op 139.34 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 256 129.40 us/op 128.89 us/op 1.00
pickEth1Vote - no votes 1.1208 ms/op 1.3125 ms/op 0.85
pickEth1Vote - max votes 8.7688 ms/op 8.7582 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.025 ms/op 20.164 ms/op 0.84
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 23.904 ms/op 26.565 ms/op 0.90
pickEth1Vote - Eth1Data fastSerialize value x2048 549.86 us/op 597.02 us/op 0.92
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.4204 ms/op 5.7097 ms/op 0.95
bytes32 toHexString 462.00 ns/op 491.00 ns/op 0.94
bytes32 Buffer.toString(hex) 274.00 ns/op 314.00 ns/op 0.87
bytes32 Buffer.toString(hex) from Uint8Array 392.00 ns/op 435.00 ns/op 0.90
bytes32 Buffer.toString(hex) + 0x 275.00 ns/op 319.00 ns/op 0.86
Object access 1 prop 0.15000 ns/op 0.17300 ns/op 0.87
Map access 1 prop 0.14700 ns/op 0.16500 ns/op 0.89
Object get x1000 7.2890 ns/op 7.6080 ns/op 0.96
Map get x1000 0.60800 ns/op 0.62300 ns/op 0.98
Object set x1000 46.818 ns/op 50.827 ns/op 0.92
Map set x1000 37.260 ns/op 39.241 ns/op 0.95
Return object 10000 times 0.23290 ns/op 0.24440 ns/op 0.95
Throw Error 10000 times 3.7857 us/op 3.8904 us/op 0.97
fastMsgIdFn sha256 / 200 bytes 3.2680 us/op 3.3350 us/op 0.98
fastMsgIdFn h32 xxhash / 200 bytes 265.00 ns/op 273.00 ns/op 0.97
fastMsgIdFn h64 xxhash / 200 bytes 338.00 ns/op 346.00 ns/op 0.98
fastMsgIdFn sha256 / 1000 bytes 11.165 us/op 11.659 us/op 0.96
fastMsgIdFn h32 xxhash / 1000 bytes 384.00 ns/op 410.00 ns/op 0.94
fastMsgIdFn h64 xxhash / 1000 bytes 395.00 ns/op 435.00 ns/op 0.91
fastMsgIdFn sha256 / 10000 bytes 102.42 us/op 109.38 us/op 0.94
fastMsgIdFn h32 xxhash / 10000 bytes 1.8410 us/op 2.0310 us/op 0.91
fastMsgIdFn h64 xxhash / 10000 bytes 1.2720 us/op 1.4150 us/op 0.90
send data - 1000 256B messages 17.859 ms/op 18.376 ms/op 0.97
send data - 1000 512B messages 25.636 ms/op 27.234 ms/op 0.94
send data - 1000 1024B messages 40.453 ms/op 40.695 ms/op 0.99
send data - 1000 1200B messages 22.605 ms/op 27.105 ms/op 0.83
send data - 1000 2048B messages 28.677 ms/op 33.523 ms/op 0.86
send data - 1000 4096B messages 31.966 ms/op 35.589 ms/op 0.90
send data - 1000 16384B messages 71.826 ms/op 83.609 ms/op 0.86
send data - 1000 65536B messages 281.99 ms/op 321.11 ms/op 0.88
enrSubnets - fastDeserialize 64 bits 1.1760 us/op 1.2740 us/op 0.92
enrSubnets - ssz BitVector 64 bits 397.00 ns/op 423.00 ns/op 0.94
enrSubnets - fastDeserialize 4 bits 159.00 ns/op 179.00 ns/op 0.89
enrSubnets - ssz BitVector 4 bits 398.00 ns/op 416.00 ns/op 0.96
prioritizePeers score -10:0 att 32-0.1 sync 2-0 94.199 us/op 110.49 us/op 0.85
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 120.01 us/op 124.76 us/op 0.96
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 150.67 us/op 162.87 us/op 0.93
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 269.65 us/op 322.77 us/op 0.84
prioritizePeers score 0:0 att 64-1 sync 4-1 324.01 us/op 345.16 us/op 0.94
array of 16000 items push then shift 1.5691 us/op 1.8418 us/op 0.85
LinkedList of 16000 items push then shift 8.7740 ns/op 10.355 ns/op 0.85
array of 16000 items push then pop 68.108 ns/op 68.824 ns/op 0.99
LinkedList of 16000 items push then pop 8.4590 ns/op 9.5660 ns/op 0.88
array of 24000 items push then shift 2.3405 us/op 2.5359 us/op 0.92
LinkedList of 24000 items push then shift 8.7480 ns/op 9.6500 ns/op 0.91
array of 24000 items push then pop 108.25 ns/op 97.420 ns/op 1.11
LinkedList of 24000 items push then pop 8.4770 ns/op 10.171 ns/op 0.83
intersect bitArray bitLen 8 6.6320 ns/op 7.3240 ns/op 0.91
intersect array and set length 8 55.121 ns/op 56.265 ns/op 0.98
intersect bitArray bitLen 128 31.392 ns/op 34.828 ns/op 0.90
intersect array and set length 128 746.72 ns/op 801.17 ns/op 0.93
bitArray.getTrueBitIndexes() bitLen 128 1.5320 us/op 1.4730 us/op 1.04
bitArray.getTrueBitIndexes() bitLen 248 2.4990 us/op 2.5100 us/op 1.00
bitArray.getTrueBitIndexes() bitLen 512 4.7880 us/op 4.7140 us/op 1.02
Buffer.concat 32 items 998.00 ns/op 973.00 ns/op 1.03
Uint8Array.set 32 items 2.5640 us/op 1.6510 us/op 1.55
Set add up to 64 items then delete first 4.2387 us/op 4.4612 us/op 0.95
OrderedSet add up to 64 items then delete first 5.2543 us/op 5.6554 us/op 0.93
Set add up to 64 items then delete last 4.5219 us/op 4.6469 us/op 0.97
OrderedSet add up to 64 items then delete last 5.5290 us/op 5.7872 us/op 0.96
Set add up to 64 items then delete middle 4.4590 us/op 4.6546 us/op 0.96
OrderedSet add up to 64 items then delete middle 6.8795 us/op 7.2877 us/op 0.94
Set add up to 128 items then delete first 9.3094 us/op 9.5326 us/op 0.98
OrderedSet add up to 128 items then delete first 11.834 us/op 12.712 us/op 0.93
Set add up to 128 items then delete last 9.2381 us/op 9.2556 us/op 1.00
OrderedSet add up to 128 items then delete last 11.835 us/op 11.841 us/op 1.00
Set add up to 128 items then delete middle 8.9243 us/op 9.1635 us/op 0.97
OrderedSet add up to 128 items then delete middle 16.463 us/op 17.049 us/op 0.97
Set add up to 256 items then delete first 17.903 us/op 20.385 us/op 0.88
OrderedSet add up to 256 items then delete first 24.306 us/op 25.878 us/op 0.94
Set add up to 256 items then delete last 18.000 us/op 18.392 us/op 0.98
OrderedSet add up to 256 items then delete last 22.915 us/op 23.479 us/op 0.98
Set add up to 256 items then delete middle 17.970 us/op 18.372 us/op 0.98
OrderedSet add up to 256 items then delete middle 45.210 us/op 46.885 us/op 0.96
transfer serialized Status (84 B) 1.8430 us/op 1.7910 us/op 1.03
copy serialized Status (84 B) 1.4950 us/op 1.5710 us/op 0.95
transfer serialized SignedVoluntaryExit (112 B) 2.1040 us/op 2.0450 us/op 1.03
copy serialized SignedVoluntaryExit (112 B) 1.6020 us/op 1.8970 us/op 0.84
transfer serialized ProposerSlashing (416 B) 3.1910 us/op 2.4230 us/op 1.32
copy serialized ProposerSlashing (416 B) 2.9510 us/op 2.2490 us/op 1.31
transfer serialized Attestation (485 B) 3.2710 us/op 2.3880 us/op 1.37
copy serialized Attestation (485 B) 3.0280 us/op 2.1740 us/op 1.39
transfer serialized AttesterSlashing (33232 B) 2.5270 us/op 2.4480 us/op 1.03
copy serialized AttesterSlashing (33232 B) 5.0660 us/op 5.2310 us/op 0.97
transfer serialized Small SignedBeaconBlock (128000 B) 2.6210 us/op 2.7930 us/op 0.94
copy serialized Small SignedBeaconBlock (128000 B) 11.616 us/op 13.849 us/op 0.84
transfer serialized Avg SignedBeaconBlock (200000 B) 2.8790 us/op 3.3300 us/op 0.86
copy serialized Avg SignedBeaconBlock (200000 B) 19.097 us/op 30.584 us/op 0.62
transfer serialized BlobsSidecar (524380 B) 3.2170 us/op 3.2280 us/op 1.00
copy serialized BlobsSidecar (524380 B) 89.907 us/op 82.490 us/op 1.09
transfer serialized Big SignedBeaconBlock (1000000 B) 3.7540 us/op 3.1270 us/op 1.20
copy serialized Big SignedBeaconBlock (1000000 B) 171.15 us/op 156.78 us/op 1.09
pass gossip attestations to forkchoice per slot 3.9275 ms/op 4.1582 ms/op 0.94
forkChoice updateHead vc 100000 bc 64 eq 0 785.64 us/op 842.24 us/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 0 6.8536 ms/op 5.1263 ms/op 1.34
forkChoice updateHead vc 1000000 bc 64 eq 0 8.4470 ms/op 7.3948 ms/op 1.14
forkChoice updateHead vc 600000 bc 320 eq 0 4.3736 ms/op 4.4449 ms/op 0.98
forkChoice updateHead vc 600000 bc 1200 eq 0 4.4975 ms/op 4.5792 ms/op 0.98
forkChoice updateHead vc 600000 bc 7200 eq 0 5.6231 ms/op 5.7941 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 1000 12.967 ms/op 11.721 ms/op 1.11
forkChoice updateHead vc 600000 bc 64 eq 10000 12.499 ms/op 12.723 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 300000 19.610 ms/op 17.256 ms/op 1.14
computeDeltas 500000 validators 300 proto nodes 6.8709 ms/op 6.7054 ms/op 1.02
computeDeltas 500000 validators 1200 proto nodes 6.7290 ms/op 6.8202 ms/op 0.99
computeDeltas 500000 validators 7200 proto nodes 6.9993 ms/op 6.8465 ms/op 1.02
computeDeltas 750000 validators 300 proto nodes 10.935 ms/op 10.109 ms/op 1.08
computeDeltas 750000 validators 1200 proto nodes 12.536 ms/op 10.951 ms/op 1.14
computeDeltas 750000 validators 7200 proto nodes 12.141 ms/op 10.393 ms/op 1.17
computeDeltas 1400000 validators 300 proto nodes 21.669 ms/op 20.333 ms/op 1.07
computeDeltas 1400000 validators 1200 proto nodes 21.037 ms/op 19.131 ms/op 1.10
computeDeltas 1400000 validators 7200 proto nodes 19.816 ms/op 19.052 ms/op 1.04
computeDeltas 2100000 validators 300 proto nodes 29.466 ms/op 29.174 ms/op 1.01
computeDeltas 2100000 validators 1200 proto nodes 30.566 ms/op 28.521 ms/op 1.07
computeDeltas 2100000 validators 7200 proto nodes 31.237 ms/op 29.794 ms/op 1.05
computeProposerBoostScoreFromBalances 500000 validators 3.8979 ms/op 3.5071 ms/op 1.11
computeProposerBoostScoreFromBalances 750000 validators 3.4888 ms/op 3.6060 ms/op 0.97
computeProposerBoostScoreFromBalances 1400000 validators 3.3890 ms/op 3.5372 ms/op 0.96
computeProposerBoostScoreFromBalances 2100000 validators 3.3386 ms/op 4.0259 ms/op 0.83
altair processAttestation - 250000 vs - 7PWei normalcase 2.6311 ms/op 2.9147 ms/op 0.90
altair processAttestation - 250000 vs - 7PWei worstcase 3.6192 ms/op 4.4192 ms/op 0.82
altair processAttestation - setStatus - 1/6 committees join 178.58 us/op 229.00 us/op 0.78
altair processAttestation - setStatus - 1/3 committees join 354.08 us/op 443.08 us/op 0.80
altair processAttestation - setStatus - 1/2 committees join 469.41 us/op 601.61 us/op 0.78
altair processAttestation - setStatus - 2/3 committees join 590.51 us/op 748.64 us/op 0.79
altair processAttestation - setStatus - 4/5 committees join 800.02 us/op 1.0128 ms/op 0.79
altair processAttestation - setStatus - 100% committees join 932.48 us/op 1.1826 ms/op 0.79
altair processBlock - 250000 vs - 7PWei normalcase 9.1368 ms/op 10.019 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 29.012 ms/op 39.999 ms/op 0.73
altair processBlock - 250000 vs - 7PWei worstcase 38.743 ms/op 45.576 ms/op 0.85
altair processBlock - 250000 vs - 7PWei worstcase hashState 85.977 ms/op 100.27 ms/op 0.86
phase0 processBlock - 250000 vs - 7PWei normalcase 2.9622 ms/op 3.1175 ms/op 0.95
phase0 processBlock - 250000 vs - 7PWei worstcase 33.002 ms/op 35.570 ms/op 0.93
altair processEth1Data - 250000 vs - 7PWei normalcase 559.93 us/op 569.93 us/op 0.98
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 14.546 us/op 8.5420 us/op 1.70
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 83.382 us/op 36.438 us/op 2.29
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 20.561 us/op 20.548 us/op 1.00
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 14.118 us/op 11.842 us/op 1.19
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 147.19 us/op 186.41 us/op 0.79
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0975 ms/op 1.2996 ms/op 0.84
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.7934 ms/op 1.6605 ms/op 1.08
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.6175 ms/op 1.9940 ms/op 0.81
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.6574 ms/op 3.3553 ms/op 1.09
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.2338 ms/op 2.7237 ms/op 0.82
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.2218 ms/op 5.7802 ms/op 0.90
Tree 40 250000 create 326.29 ms/op 363.65 ms/op 0.90
Tree 40 250000 get(125000) 203.14 ns/op 225.13 ns/op 0.90
Tree 40 250000 set(125000) 980.23 ns/op 1.0845 us/op 0.90
Tree 40 250000 toArray() 21.360 ms/op 20.069 ms/op 1.06
Tree 40 250000 iterate all - toArray() + loop 21.164 ms/op 20.508 ms/op 1.03
Tree 40 250000 iterate all - get(i) 75.419 ms/op 77.840 ms/op 0.97
MutableVector 250000 create 15.102 ms/op 13.451 ms/op 1.12
MutableVector 250000 get(125000) 6.6150 ns/op 7.4270 ns/op 0.89
MutableVector 250000 set(125000) 282.71 ns/op 294.87 ns/op 0.96
MutableVector 250000 toArray() 3.7169 ms/op 3.3681 ms/op 1.10
MutableVector 250000 iterate all - toArray() + loop 3.8357 ms/op 3.3895 ms/op 1.13
MutableVector 250000 iterate all - get(i) 1.5765 ms/op 1.7492 ms/op 0.90
Array 250000 create 3.5994 ms/op 3.0602 ms/op 1.18
Array 250000 clone - spread 1.0080 ms/op 1.3434 ms/op 0.75
Array 250000 get(125000) 0.47600 ns/op 0.68800 ns/op 0.69
Array 250000 set(125000) 0.55200 ns/op 0.77500 ns/op 0.71
Array 250000 iterate all - loop 83.331 us/op 95.318 us/op 0.87
effectiveBalanceIncrements clone Uint8Array 300000 22.389 us/op 28.931 us/op 0.77
effectiveBalanceIncrements clone MutableVector 300000 241.00 ns/op 424.00 ns/op 0.57
effectiveBalanceIncrements rw all Uint8Array 300000 179.38 us/op 203.32 us/op 0.88
effectiveBalanceIncrements rw all MutableVector 300000 75.873 ms/op 93.963 ms/op 0.81
phase0 afterProcessEpoch - 250000 vs - 7PWei 113.52 ms/op 130.74 ms/op 0.87
phase0 beforeProcessEpoch - 250000 vs - 7PWei 34.597 ms/op 37.400 ms/op 0.93
altair processEpoch - mainnet_e81889 454.83 ms/op 480.68 ms/op 0.95
mainnet_e81889 - altair beforeProcessEpoch 67.815 ms/op 52.895 ms/op 1.28
mainnet_e81889 - altair processJustificationAndFinalization 21.311 us/op 17.805 us/op 1.20
mainnet_e81889 - altair processInactivityUpdates 5.5462 ms/op 6.0831 ms/op 0.91
mainnet_e81889 - altair processRewardsAndPenalties 52.778 ms/op 74.099 ms/op 0.71
mainnet_e81889 - altair processRegistryUpdates 3.4290 us/op 2.4530 us/op 1.40
mainnet_e81889 - altair processSlashings 614.00 ns/op 513.00 ns/op 1.20
mainnet_e81889 - altair processEth1DataReset 679.00 ns/op 531.00 ns/op 1.28
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3291 ms/op 1.4288 ms/op 0.93
mainnet_e81889 - altair processSlashingsReset 3.6240 us/op 3.2250 us/op 1.12
mainnet_e81889 - altair processRandaoMixesReset 5.3980 us/op 4.2350 us/op 1.27
mainnet_e81889 - altair processHistoricalRootsUpdate 801.00 ns/op 759.00 ns/op 1.06
mainnet_e81889 - altair processParticipationFlagUpdates 2.9340 us/op 1.7810 us/op 1.65
mainnet_e81889 - altair processSyncCommitteeUpdates 1.4180 us/op 704.00 ns/op 2.01
mainnet_e81889 - altair afterProcessEpoch 127.41 ms/op 130.43 ms/op 0.98
capella processEpoch - mainnet_e217614 1.4394 s/op 1.5230 s/op 0.95
mainnet_e217614 - capella beforeProcessEpoch 242.73 ms/op 246.26 ms/op 0.99
mainnet_e217614 - capella processJustificationAndFinalization 14.638 us/op 12.776 us/op 1.15
mainnet_e217614 - capella processInactivityUpdates 16.207 ms/op 16.717 ms/op 0.97
mainnet_e217614 - capella processRewardsAndPenalties 271.17 ms/op 288.46 ms/op 0.94
mainnet_e217614 - capella processRegistryUpdates 16.411 us/op 19.978 us/op 0.82
mainnet_e217614 - capella processSlashings 562.00 ns/op 444.00 ns/op 1.27
mainnet_e217614 - capella processEth1DataReset 504.00 ns/op 408.00 ns/op 1.24
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.3964 ms/op 4.1781 ms/op 1.05
mainnet_e217614 - capella processSlashingsReset 2.8780 us/op 2.2100 us/op 1.30
mainnet_e217614 - capella processRandaoMixesReset 4.5390 us/op 4.3240 us/op 1.05
mainnet_e217614 - capella processHistoricalRootsUpdate 866.00 ns/op 548.00 ns/op 1.58
mainnet_e217614 - capella processParticipationFlagUpdates 2.2860 us/op 1.9070 us/op 1.20
mainnet_e217614 - capella afterProcessEpoch 303.86 ms/op 323.73 ms/op 0.94
phase0 processEpoch - mainnet_e58758 421.92 ms/op 418.44 ms/op 1.01
mainnet_e58758 - phase0 beforeProcessEpoch 113.37 ms/op 106.61 ms/op 1.06
mainnet_e58758 - phase0 processJustificationAndFinalization 14.059 us/op 14.919 us/op 0.94
mainnet_e58758 - phase0 processRewardsAndPenalties 43.503 ms/op 43.437 ms/op 1.00
mainnet_e58758 - phase0 processRegistryUpdates 10.543 us/op 8.9230 us/op 1.18
mainnet_e58758 - phase0 processSlashings 559.00 ns/op 476.00 ns/op 1.17
mainnet_e58758 - phase0 processEth1DataReset 475.00 ns/op 454.00 ns/op 1.05
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0471 ms/op 974.67 us/op 1.07
mainnet_e58758 - phase0 processSlashingsReset 2.2860 us/op 2.3860 us/op 0.96
mainnet_e58758 - phase0 processRandaoMixesReset 4.5120 us/op 4.3130 us/op 1.05
mainnet_e58758 - phase0 processHistoricalRootsUpdate 858.00 ns/op 560.00 ns/op 1.53
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.3720 us/op 3.7950 us/op 1.15
mainnet_e58758 - phase0 afterProcessEpoch 102.84 ms/op 106.06 ms/op 0.97
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2534 ms/op 1.2168 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4448 ms/op 1.4350 ms/op 1.01
altair processInactivityUpdates - 250000 normalcase 21.415 ms/op 19.594 ms/op 1.09
altair processInactivityUpdates - 250000 worstcase 23.909 ms/op 21.092 ms/op 1.13
phase0 processRegistryUpdates - 250000 normalcase 9.5860 us/op 8.1010 us/op 1.18
phase0 processRegistryUpdates - 250000 badcase_full_deposits 361.17 us/op 319.88 us/op 1.13
phase0 processRegistryUpdates - 250000 worstcase 0.5 120.04 ms/op 122.64 ms/op 0.98
altair processRewardsAndPenalties - 250000 normalcase 49.974 ms/op 43.503 ms/op 1.15
altair processRewardsAndPenalties - 250000 worstcase 55.981 ms/op 61.798 ms/op 0.91
phase0 getAttestationDeltas - 250000 normalcase 9.1089 ms/op 8.6461 ms/op 1.05
phase0 getAttestationDeltas - 250000 worstcase 8.3809 ms/op 8.2721 ms/op 1.01
phase0 processSlashings - 250000 worstcase 2.2294 ms/op 2.3610 ms/op 0.94
altair processSyncCommitteeUpdates - 250000 159.94 ms/op 154.22 ms/op 1.04
BeaconState.hashTreeRoot - No change 264.00 ns/op 284.00 ns/op 0.93
BeaconState.hashTreeRoot - 1 full validator 114.59 us/op 153.34 us/op 0.75
BeaconState.hashTreeRoot - 32 full validator 1.2047 ms/op 1.6678 ms/op 0.72
BeaconState.hashTreeRoot - 512 full validator 13.696 ms/op 16.310 ms/op 0.84
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 138.48 us/op 168.74 us/op 0.82
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.7862 ms/op 2.0377 ms/op 0.88
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 24.443 ms/op 28.513 ms/op 0.86
BeaconState.hashTreeRoot - 1 balances 115.27 us/op 135.74 us/op 0.85
BeaconState.hashTreeRoot - 32 balances 1.0803 ms/op 1.0867 ms/op 0.99
BeaconState.hashTreeRoot - 512 balances 10.428 ms/op 10.492 ms/op 0.99
BeaconState.hashTreeRoot - 250000 balances 171.55 ms/op 188.92 ms/op 0.91
aggregationBits - 2048 els - zipIndexesInBitList 18.595 us/op 15.321 us/op 1.21
regular array get 100000 times 33.150 us/op 33.274 us/op 1.00
wrappedArray get 100000 times 43.748 us/op 33.192 us/op 1.32
arrayWithProxy get 100000 times 14.321 ms/op 15.186 ms/op 0.94
ssz.Root.equals 262.00 ns/op 234.00 ns/op 1.12
byteArrayEquals 256.00 ns/op 224.00 ns/op 1.14
shuffle list - 16384 els 7.1063 ms/op 7.5016 ms/op 0.95
shuffle list - 250000 els 106.72 ms/op 108.96 ms/op 0.98
processSlot - 1 slots 20.415 us/op 16.302 us/op 1.25
processSlot - 32 slots 4.1517 ms/op 3.8687 ms/op 1.07
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 49.619 ms/op 55.185 ms/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 2.6470 ms/op 2.9795 ms/op 0.89
getCommitteeAssignments - req 100 vs - 250000 vc 3.9319 ms/op 4.1349 ms/op 0.95
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1366 ms/op 4.3294 ms/op 0.96
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.7500 ns/op 5.2500 ns/op 1.10
state getBlockRootAtSlot - 250000 vs - 7PWei 607.27 ns/op 579.46 ns/op 1.05
computeProposers - vc 250000 9.5524 ms/op 10.297 ms/op 0.93
computeEpochShuffling - vc 250000 106.39 ms/op 121.61 ms/op 0.87
getNextSyncCommittee - vc 250000 154.19 ms/op 166.43 ms/op 0.93
computeSigningRoot for AttestationData 22.915 us/op 24.539 us/op 0.93
hash AttestationData serialized data then Buffer.toString(base64) 2.3379 us/op 2.6136 us/op 0.89
toHexString serialized data 1.1144 us/op 1.1730 us/op 0.95
Buffer.toString(base64) 220.16 ns/op 233.83 ns/op 0.94

by benchmarkbot/action

@nazarhussain
Uncomment a test
2550eb7
@nazarhussain
Update hooks to show time in the log
1df7905
@nazarhussain
Add a custom mocha wrapper to detected leaked resources
b52e7e0
@nazarhussain
Use mocha wrapper for beacon-node e2e tests
5c5d51e
@nazarhussain
Add multiple exit to mocha run
a495e37
@nazarhussain
Add mocha exit with failure count
d7b654b
@nazarhussain
Update the process exit strategy
a784688
@nazarhussain
Exit the process with signal
af4c603
@nazarhussain
Exit the process with signal
652294c
@nazarhussain
Stop the beacon node once
b3406a3
@nazarhussain
Abort the process
b471c54
@nazarhussain
Enable debug logging for e2e tests
04e34d6
@nazarhussain
Add unique name to each node for identification
96fdaa8
@nazarhussain
Add unique name to each node for identification
7d2256e
@nazarhussain
Fix gossip test close
ca2a6d3
@nazarhussain
Fixing peer manager close handler
1aeee1a
@nazarhussain
Update the process of finding active resources
cdb9771
@nazarhussain
Add log prefix to validators to debug
a5c6929
@nazarhussain
Add log prefix to validators to debug
519f626
@nazarhussain
Add try/catch for network core close
c8c4f28
@nazarhussain
Wait for peer disconnect
1c1168a
@nazarhussain
Updat the exit strategy to ignore default resources
efbd4fb
@nazarhussain
Add more logs to investigate
88a6acf
@philknows philknows added this to the v1.12.0 milestone Oct 10, 2023
@nflaig
Copy link
Member

nflaig commented Oct 10, 2023

We should confirm that this resolves the active handles issue (related libp2p issues are closed)

nazarhussain
nazarhussain previously approved these changes Oct 10, 2023
View reviewed changes
nazarhussain
nazarhussain previously approved these changes Oct 10, 2023
View reviewed changes
nflaig
nflaig requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a bunch of unrelated changes

packages/beacon-node/src/network/core/networkCore.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/unit/monitoring/service.test.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/unit/api/impl/validator/produceAttestationData.test.ts Outdated Show resolved Hide resolved
@nazarhussain nazarhussain enabled auto-merge (squash) October 11, 2023 13:03
@wemeetagain
Copy link
Member Author

file conflicts

nflaig
nflaig reviewed Oct 13, 2023
View reviewed changes
packages/beacon-node/src/network/core/networkCore.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/e2e/network/gossipsub.test.ts
@@ -19,7 +19,6 @@ describe("gossipsub / worker", function () {

function runTests(this: Mocha.Suite, {useWorker}: {useWorker: boolean}): void {
if (this.timeout() < 20 * 1000) this.timeout(150 * 1000);
this.retries(2); // This test fail sometimes, with a 5% rate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can this be removed now? Was this just related to libp2p issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because tests are performing more stable now, so we don't need to have retries here.

@nazarhussain nazarhussain merged commit ab2dfdd into unstable Oct 13, 2023
15 checks passed
@nazarhussain nazarhussain deleted the cayman/bump-libp2p branch October 13, 2023 10:08
This was referenced Oct 13, 2023
Open
Open
@wemeetagain
Copy link
Member Author

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain left review comments

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wemeetagain @nflaig @nazarhussain @philknows