test(prover): move tests for prover to vitest

.github/workflows/test.yml

@@ -270,7 +270,10 @@ jobs:
             packages/*/.git-data.json
           key: ${{ runner.os }}-node-${{ matrix.node }}-${{ github.sha }}
           fail-on-cache-miss: true
-
+      - name: Install Chrome browser
+        run: npx @puppeteer/browsers install chrome
+      - name: Install Firefox browser
+        run: npx @puppeteer/browsers install firefox
       - name: Browser tests
         run: |
           export DISPLAY=':99.0'

package.json

@@ -52,19 +52,22 @@
     "@types/sinon-chai": "^3.2.9",
     "@typescript-eslint/eslint-plugin": "6.7.2",
     "@typescript-eslint/parser": "6.7.2",
+    "@vitest/coverage-v8": "^1.0.1",
+    "@vitest/browser": "^1.0.1",
     "c8": "^8.0.1",
     "chai": "^4.3.8",
     "chai-as-promised": "^7.1.1",
     "codecov": "^3.8.3",
     "crypto-browserify": "^3.12.0",
     "electron": "^26.2.2",
     "eslint": "^8.50.0",
-    "eslint-plugin-import": "^2.28.1",
-    "eslint-plugin-prettier": "^5.0.0",
+    "eslint-import-resolver-typescript": "^3.6.1",
     "eslint-plugin-chai-expect": "^3.0.0",
+    "eslint-plugin-import": "^2.28.1",
     "eslint-plugin-mocha": "^10.2.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
+    "eslint-plugin-prettier": "^5.0.0",
     "https-browserify": "^1.0.0",
+    "jsdom": "^23.0.1",
     "karma": "^6.4.2",
     "karma-chai": "^0.1.0",
     "karma-chrome-launcher": "^3.2.0",
@@ -93,13 +96,17 @@
     "ts-node": "^10.9.1",
     "typescript": "^5.2.2",
     "typescript-docs-verifier": "^2.5.0",
-    "webpack": "^5.88.2",
+    "vite-plugin-node-polyfills": "^0.17.0",
+    "vite-plugin-top-level-await": "^1.3.1",
+    "vitest": "^1.0.2",
+    "vitest-when": "^0.3.0",
     "wait-port": "^1.1.0",
-    "vitest": "^0.34.6",
-    "vitest-when": "^0.2.0",
-    "@vitest/coverage-v8": "^0.34.6"
+    "webdriverio": "^8.24.12",
+    "webpack": "^5.88.2"
   },
   "resolutions": {
-    "dns-over-http-resolver": "^2.1.1"
+    "dns-over-http-resolver": "^2.1.1",
+    "chai": "^4.3.10",
+    "loupe": "^2.3.6"
   }
 }

packages/beacon-node/package.json

@@ -80,7 +80,7 @@
     "test:unit:minimal": "vitest --run --segfaultRetry 3 --dir test/unit/ --coverage",
     "test:unit:mainnet": "LODESTAR_PRESET=mainnet nyc --cache-dir .nyc_output/.cache -e .ts mocha 'test/unit-mainnet/**/*.test.ts'",
     "test:unit": "yarn test:unit:minimal && yarn test:unit:mainnet",
-    "test:e2e": "LODESTAR_PRESET=minimal vitest --run --segfaultRetry 3 --single-thread --dir test/e2e",
+    "test:e2e": "LODESTAR_PRESET=minimal vitest --run --segfaultRetry 3 --poolOptions.threads.singleFork --dir test/e2e",
     "test:sim": "mocha 'test/sim/**/*.test.ts'",
     "test:sim:merge-interop": "mocha 'test/sim/merge-interop.test.ts'",
     "test:sim:mergemock": "mocha 'test/sim/mergemock.test.ts'",

packages/beacon-node/test/unit/chain/opPools/syncCommittee.test.ts

@@ -38,7 +38,7 @@ describe("chain / opPools / SyncCommitteeMessagePool", function () {
     vi.clearAllMocks();
   });
 
-  it("should preaggregate SyncCommitteeContribution", () => {
+  it("should propagate SyncCommitteeContribution", () => {
     clockStub.secFromSlot.mockReturnValue(0);
     let contribution = cache.getContribution(subcommitteeIndex, syncCommittee.slot, syncCommittee.beaconBlockRoot);
     expect(contribution).not.toBeNull();

packages/beacon-node/test/unit/chain/prepareNextSlot.test.ts

@@ -1,4 +1,4 @@
-import {describe, it, expect, beforeEach, afterEach, vi, SpyInstance, Mock} from "vitest";
+import {describe, it, expect, beforeEach, afterEach, vi, Mock, MockInstance} from "vitest";
 import {config} from "@lodestar/config/default";
 import {ForkName, SLOTS_PER_EPOCH} from "@lodestar/params";
 import {routes} from "@lodestar/api";
@@ -20,7 +20,7 @@ describe("PrepareNextSlot scheduler", () => {
   let regenStub: MockedBeaconChain["regen"];
   let loggerStub: MockedLogger;
   let beaconProposerCacheStub: MockedBeaconChain["beaconProposerCache"];
-  let getForkStub: SpyInstance<[number], ForkName>;
+  let getForkStub: MockInstance<[number], ForkName>;
   let updateBuilderStatus: MockedBeaconChain["updateBuilderStatus"];
   let executionEngineStub: MockedBeaconChain["executionEngine"];
   const emitPayloadAttributes = true;

packages/beacon-node/test/unit/eth1/eth1DepositDataTracker.test.ts

@@ -1,4 +1,4 @@
-import {describe, it, expect, beforeEach, afterEach, vi, SpyInstance} from "vitest";
+import {describe, it, expect, beforeEach, afterEach, vi, MockInstance} from "vitest";
 import {config} from "@lodestar/config/default";
 import {TimeoutError} from "@lodestar/utils";
 import {Eth1DepositDataTracker} from "../../../src/eth1/eth1DepositDataTracker.js";
@@ -17,8 +17,8 @@ describe("Eth1DepositDataTracker", function () {
   const eth1Provider = new Eth1Provider(config, opts, signal, null);
   let db: BeaconDb;
   let eth1DepositDataTracker: Eth1DepositDataTracker;
-  let getBlocksByNumberStub: SpyInstance;
-  let getDepositEventsStub: SpyInstance;
+  let getBlocksByNumberStub: MockInstance;
+  let getDepositEventsStub: MockInstance;
 
   beforeEach(() => {
     db = getMockedBeaconDb();

packages/beacon-node/test/unit/monitoring/service.test.ts

@@ -1,4 +1,4 @@
-import {describe, it, expect, beforeEach, beforeAll, afterAll, vi, afterEach, SpyInstance} from "vitest";
+import {describe, it, expect, beforeEach, beforeAll, afterAll, vi, afterEach, MockInstance} from "vitest";
 import {ErrorAborted, TimeoutError} from "@lodestar/utils";
 import {RegistryMetricCreator} from "../../../src/index.js";
 import {HistogramExtra} from "../../../src/metrics/utils/histogram.js";
@@ -115,7 +115,7 @@ describe("monitoring / service", () => {
   });
 
   describe("MonitoringService - close", () => {
-    let clearTimeout: SpyInstance;
+    let clearTimeout: MockInstance;
 
     beforeAll(() => {
       clearTimeout = vi.spyOn(global, "clearTimeout");

packages/cli/test/sim/multi_fork.test.ts

@@ -2,6 +2,7 @@
 import path from "node:path";
 import {sleep, toHex, toHexString} from "@lodestar/utils";
 import {ApiError} from "@lodestar/api";
+import {SLOTS_PER_EPOCH} from "@lodestar/params";
 import {CLIQUE_SEALING_PERIOD, SIM_TESTS_SECONDS_PER_SLOT} from "../utils/simulation/constants.js";
 import {AssertionMatch, BeaconClient, ExecutionClient, ValidatorClient} from "../utils/simulation/interfaces.js";
 import {SimulationEnvironment} from "../utils/simulation/SimulationEnvironment.js";
@@ -213,7 +214,8 @@ const unknownBlockSync = await env.createNodePair({
         // unknown block sync can work only if the gap is maximum `slotImportTolerance * 2`
         // default value for slotImportTolerance is one epoch, so if gap is more than 2 epoch
         // unknown block sync will not work. So why we have to increase it for tests.
-        "sync.slotImportTolerance": headForUnknownBlockSync.response.data.message.slot / 2 + 2,
+        // Adding SLOTS_PER_EPOCH will cover the case if the node starts on the last slot of epoch
+        "sync.slotImportTolerance": headForUnknownBlockSync.response.data.message.slot / 2 + SLOTS_PER_EPOCH,
       },
     },
   },

packages/prover/package.json

@@ -53,9 +53,12 @@
     "lint:fix": "yarn run lint --fix",
     "pretest": "yarn run check-types",
     "test": "yarn test:unit && yarn test:e2e",
-    "test:unit": "nyc --cache-dir .nyc_output/.cache -e .ts mocha 'test/unit/**/*.test.ts'",
-    "test:browsers": "yarn karma start karma.config.cjs",
-    "test:e2e": "LODESTAR_PRESET=minimal mocha 'test/e2e/**/*.test.ts'",
+    "test:unit": "vitest --run --dir test/unit/ --coverage",
+    "test:browsers": "yarn test:browsers:chrome && yarn test:browsers:firefox && yarn test:browsers:electron",
+    "test:browsers:chrome": "vitest --run --browser chrome --config ./vitest.browser.config.ts --dir test/unit",
+    "test:browsers:firefox": "vitest --run --browser firefox --config ./vitest.browser.config.ts --dir test/unit",
+    "test:browsers:electron": "echo 'Electron tests will be introduced back in the future as soon vitest supports electron.'",
+    "test:e2e": "LODESTAR_PRESET=minimal vitest --run --poolOptions.threads.singleThread --dir test/e2e",
     "check-readme": "typescript-docs-verifier",
     "generate-fixtures": "node --loader ts-node/esm scripts/generate_fixtures.ts"
   },

packages/prover/test/e2e/cli/cmds/start.test.ts

@@ -1,7 +1,7 @@
 import childProcess from "node:child_process";
 import {writeFile, mkdir} from "node:fs/promises";
 import path from "node:path";
-import {expect} from "chai";
+import {describe, it, expect, beforeAll, afterAll} from "vitest";
 import Web3 from "web3";
 import {runCliCommand, spawnCliCommand, stopChildProcess} from "@lodestar/test-utils";
 import {sleep} from "@lodestar/utils";
@@ -15,11 +15,11 @@ describe("prover/start", () => {
   it("should show help", async () => {
     const output = await runCliCommand(cli, ["start", "--help"]);
 
-    expect(output).contains("Show help");
+    expect(output).toEqual(expect.stringContaining("Show help"));
   });
 
   it("should fail when --executionRpcUrl is missing", async () => {
-    await expect(runCliCommand(cli, ["start", "--port", "8088"])).eventually.rejectedWith(
+    await expect(runCliCommand(cli, ["start", "--port", "8088"])).rejects.toThrow(
       "Missing required argument: executionRpcUrl"
     );
   });
@@ -33,22 +33,21 @@ describe("prover/start", () => {
         "--beaconBootnodes",
         "http://localhost:0000",
       ])
-    ).eventually.rejectedWith("Arguments beaconBootnodes and beaconUrls are mutually exclusive");
+    ).rejects.toThrow("Arguments beaconBootnodes and beaconUrls are mutually exclusive");
   });
 
   it("should fail when both of --beaconUrls and --beaconBootnodes are not provided", async () => {
     await expect(
       runCliCommand(cli, ["start", "--port", "8088", "--executionRpcUrl", "http://localhost:3000"])
-    ).eventually.rejectedWith("Either --beaconUrls or --beaconBootnodes must be provided");
+    ).rejects.toThrow("Either --beaconUrls or --beaconBootnodes must be provided");
   });
 
   describe("when started", () => {
     let proc: childProcess.ChildProcess;
     const paramsFilePath = path.join("/tmp", "e2e-test-env", "params.json");
     const web3: Web3 = new Web3(proxyUrl);
 
-    before(async function () {
-      this.timeout(50000);
+    beforeAll(async function () {
       await waitForCapellaFork();
       await mkdir(path.dirname(paramsFilePath), {recursive: true});
       await writeFile(paramsFilePath, JSON.stringify(chainConfigToJson(config as ChainConfig)));
@@ -72,22 +71,22 @@ describe("prover/start", () => {
       );
       // Give sometime to the prover to start proxy server
       await sleep(3000);
-    });
+    }, 50000);
 
-    after(async () => {
+    afterAll(async () => {
       await stopChildProcess(proc);
     });
 
     it("should respond to verified calls", async () => {
       const accounts = await web3.eth.getAccounts();
 
-      expect(accounts.length).to.be.gt(0);
-      await expect(web3.eth.getBalance(accounts[0])).eventually.not.null;
+      expect(accounts.length).toBeGreaterThan(0);
+      await expect(web3.eth.getBalance(accounts[0])).resolves.not.toBeNull();
     });
 
     it("should respond to unverified calls", async () => {
       // Because web3 latest version return numbers as bigint by default
-      await expect(web3.eth.getChainId()).eventually.eql(BigInt(chainId));
+      await expect(web3.eth.getChainId()).resolves.toEqual(BigInt(chainId));
     });
   });
 });

packages/prover/test/e2e/web3_batch_request.test.ts

@@ -1,18 +1,16 @@
 /* eslint-disable @typescript-eslint/naming-convention */
-import {expect} from "chai";
+import {describe, it, expect, beforeAll} from "vitest";
 import Web3 from "web3";
 import {LCTransport} from "../../src/interfaces.js";
 import {createVerifiedExecutionProvider} from "../../src/web3_provider.js";
 import {rpcUrl, beaconUrl, config} from "../utils/e2e_env.js";
 import {getVerificationFailedMessage} from "../../src/utils/json_rpc.js";
 
+/* prettier-ignore */
 describe("web3_batch_requests", function () {
-  // Give some margin to sync light client
-  this.timeout("10s");
-
   let web3: Web3;
 
-  before(() => {
+  beforeAll(() => {
     const {provider} = createVerifiedExecutionProvider(new Web3.providers.HttpProvider(rpcUrl), {
       transport: LCTransport.Rest,
       urls: [beaconUrl],
@@ -45,8 +43,8 @@ describe("web3_batch_requests", function () {
 
       await batch.execute();
 
-      expect(results.length).to.be.gt(1);
-      await expect(Promise.all(results)).to.be.fulfilled;
+      expect(results.length).toBeGreaterThan(1);
+      await expect(Promise.all(results)).resolves.toBeDefined();
     });
 
     it("should be able to process batch request containing error", async () => {
@@ -66,8 +64,8 @@ describe("web3_batch_requests", function () {
 
       await batch.execute();
 
-      await expect(successRequest).to.be.fulfilled;
-      await expect(errorRequest).to.be.rejectedWith(getVerificationFailedMessage("eth_getBlockByHash"));
+      await expect(successRequest).resolves.toBeDefined();
+      await expect(errorRequest).rejects.toThrow(getVerificationFailedMessage("eth_getBlockByHash"));
     });
   });
-});
+}, {timeout: 10_000});

packages/prover/test/e2e/web3_provider.test.ts

@@ -1,15 +1,14 @@
 /* eslint-disable @typescript-eslint/naming-convention */
-import {expect} from "chai";
+import {describe, it, expect, beforeAll} from "vitest";
 import Web3 from "web3";
 import {ethers} from "ethers";
 import {LCTransport} from "../../src/interfaces.js";
 import {createVerifiedExecutionProvider} from "../../src/web3_provider.js";
 import {waitForCapellaFork, testTimeout, rpcUrl, beaconUrl, config} from "../utils/e2e_env.js";
 
+/* prettier-ignore */
 describe("web3_provider", function () {
-  this.timeout(testTimeout);
-
-  before("wait for the capella fork", async () => {
+  beforeAll(async () => {
     await waitForCapellaFork();
   });
 
@@ -26,8 +25,8 @@ describe("web3_provider", function () {
         const accounts = await web3.eth.getAccounts();
         // `getProof` will always remain the non-verified method
         // as we use it to create proof and verify
-        expect(accounts).not.to.be.empty;
-        await expect(web3.eth.getProof(accounts[0], [], "latest")).fulfilled;
+        expect(Object.keys(accounts)).not.toHaveLength(0);
+        await expect(web3.eth.getProof(accounts[0], [], "latest")).resolves.toBeDefined();
       });
     });
 
@@ -40,9 +39,9 @@ describe("web3_provider", function () {
         });
         const accounts = await provider.listAccounts();
 
-        expect(accounts).not.to.be.empty;
-        await expect(provider.send("eth_getProof", [accounts[0].address, [], "latest"])).fulfilled;
+        expect(Object.keys(accounts)).not.toHaveLength(0);
+        await expect(provider.send("eth_getProof", [accounts[0].address, [], "latest"])).resolves.toBeDefined();
       });
     });
   });
-});
+}, {timeout: testTimeout});

packages/prover/test/globalSetup.ts

@@ -0,0 +1,2 @@
+export async function setup(): Promise<void> {}
+export async function teardown(): Promise<void> {}