test: enable coredump for the unit tests #6107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
matthewkeil
reviewed
Nov 14, 2023
.github/workflows/test.yml
Outdated
| if: ${{ failure() && steps.unit_tests.conclusion == 'failure' }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: core-dump |
There was a problem hiding this comment.
will this over-write the existing if there are multiple?
There was a problem hiding this comment.
I think it is associated to the workflow run. So it will rewritten only if we re-run the workflow.
.github/workflows/test.yml
Outdated
Comment on lines
203
to
205
| - name: List down all files | ||
| if: ${{ failure() && steps.unit_tests.conclusion == 'failure' }} | ||
| run: ls -l |
There was a problem hiding this comment.
Curious!!! How does this fit into the solution? Is it to make sure we log the dump to stdout or something?
There was a problem hiding this comment.
This is for debugging purposes, to make sure. the coredump was generated with correct or may be different file names.
.github/workflows/test.yml
Outdated
Comment on lines
188
to
189
| - name: Replace nodejs with debug build | ||
| run: sudo cp -f node $(which node) |
There was a problem hiding this comment.
Curious why you chose to only replace for unit-tests
There was a problem hiding this comment.
Because we were observing the Segfault only during the unit tests.
|
@matthewkeil I tried triggering on-demand over 20 times and |
dapplion
reviewed
Nov 20, 2023
.github/workflows/test.yml
Outdated
| - name: Install unzip | ||
| run: sudo apt-get install unzip | ||
| - name: Download nodejs debug build | ||
| run: curl -L "https://drive.google.com/uc?export=download&id=1hlhbbQi-NJi8_WjULvOdo-K_tfZFzN3Z&confirm=t" > nodejs.zip |
There was a problem hiding this comment.
You can compress all the steps in a single multi-line inlined script, not sure if you need so much granularity at the UI level
There was a problem hiding this comment.
I don't see any issue even performing granular steps. Seems more useful while looking in the logs and seeing the UI. In the end both achieve the same thing.
There was a problem hiding this comment.
True, just an organizational detail. More verbose code and more lines in exchange for step by step reporting at the UI level. I would prefer to compact them but don't want to spend days fighting over this detail either
There was a problem hiding this comment.
As I said I prefer this granular approach, otherwise we can compact a lot of workflow in single bash script files and run in single step to avoid multi step reporting on the UI.
|
@matthewkeil @dapplion I restructured the workflow actions. Please re-review now so we can close this PR. |
matthewkeil
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
The restructuring you did looks great!! As @dapplion mentioned the output is a bit verbose though.
I still tend to think that running with debug for all CI runs, but only on unit-tests, is not the right approach but you are determined and I can definitely get behind that aspect of this PR. I have had challenges catching this so another approach seems helpful and is appreciated.
LGTM 👍
wemeetagain
approved these changes
Nov 23, 2023
|
@matthewkeil Running only for unit tests is because we observed segfault only during the unit tests so far. And each job run in isolation so can't affect each other behavior. If we observed segfault anywhere else we can reuse the same actions. I just want to get the coredump at least once 🦀 |
Yes I agree, if we don't observe the coredump in a week or two, we should revert it. But keeping the custom actions to reuse in future if needed. So why I restructured those actions as independent actions and not part of the workflow. |
|
🎉 This PR is included in v1.13.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve debugging capabilities.
Description
Make sure if tests fails again we have coredump to debug further.
Steps to test or reproduce
Run all tests