feat: track epoch transition steps time in metrics #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
|
Definitely not necessary to track every single step. Some functions are extremely cheap to run, just track the ones that do complex expensive logic, look at the benchmarks for reference |
twoeths
force-pushed
the
tuyen/epoch_transition_step_metrics
branch
from
5f6333e to
bc34818
Compare
wemeetagain
reviewed
Dec 5, 2023
dapplion
reviewed
Dec 6, 2023
| @@ -59,19 +65,31 @@ export function processEpoch(fork: ForkSeq, state: CachedBeaconStateAllForks, ca | |||
| throw new Error("Lodestar does not support this network, parameters don't fit number value inside state.slashings"); | |||
| } | |||
|
|
|||
| let timer = metrics?.epochTransitionStepTime.startTimer({step: "processJustificationAndFinalization"}); | |||
There was a problem hiding this comment.
I don't think it's necessary to use a let here, just declare individual variables. You only need to register labels once
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6143 +/- ##
=============================================
+ Coverage 0 90.35% +90.35%
=============================================
Files 0 78 +78
Lines 0 8089 +8089
Branches 0 490 +490
=============================================
+ Hits 0 7309 +7309
- Misses 0 772 +772
- Partials 0 8 +8 |
wemeetagain
approved these changes
Dec 12, 2023
nflaig
reviewed
Dec 12, 2023
| @@ -59,19 +65,53 @@ export function processEpoch(fork: ForkSeq, state: CachedBeaconStateAllForks, ca | |||
| throw new Error("Lodestar does not support this network, parameters don't fit number value inside state.slashings"); | |||
| } | |||
|
|
|||
| processJustificationAndFinalization(state, cache); | |||
| { | |||
| const timer = metrics?.epochTransitionStepTime.startTimer({ | |||
There was a problem hiding this comment.
would it make sense to have a metric utility function withTimer which just does the instrumentation? could refactor in a separate PR
wemeetagain
approved these changes
Dec 12, 2023
This was referenced Dec 15, 2023
|
🎉 This PR is included in v1.13.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have unstable epoch transitions and we have no idea which steps take the most time
Description
part of #6112
part of #6063
part of #5409