Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename deposit receipt to deposit request for Pectra #6748

Merged
merged 2 commits into from
May 8, 2024

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented May 8, 2024

EL uses the term "deposit request" while CL uses the term "deposit receipt" as per current devnet 0 spec. See ethereum/consensus-specs#3757 for more context

This PR renames deposit receipt to deposit request for:

  • Internal reference
  • ssz types

@ensi321 ensi321 requested a review from a team as a code owner May 8, 2024 12:20
@ensi321 ensi321 changed the base branch from unstable to electra-fork May 8, 2024 12:21
@nflaig
Copy link
Member

nflaig commented May 8, 2024

packages/light-client/stats.html needs to be removed

@ensi321 ensi321 merged commit 2386c32 into electra-fork May 8, 2024
13 of 18 checks passed
@ensi321 ensi321 deleted the nc/6110-deposit-request branch May 8, 2024 15:12
g11tech pushed a commit that referenced this pull request May 24, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit to g11tech/lodestar that referenced this pull request Jun 19, 2024
g11tech pushed a commit that referenced this pull request Jun 25, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Jun 25, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Jul 1, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Jul 30, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Jul 31, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Aug 2, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Aug 9, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Aug 9, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Aug 23, 2024
* Rename receipt to request

* Remove stats.html
g11tech pushed a commit that referenced this pull request Aug 27, 2024
* Rename receipt to request

* Remove stats.html
philknows pushed a commit that referenced this pull request Sep 3, 2024
* Rename receipt to request

* Remove stats.html
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants