Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add default message if server closes eventstream #6902

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore: add default message if server closes eventstream #6902

merged 1 commit into from
Jun 20, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jun 20, 2024

Motivation

Since we now log evenstream errors, I noticed that if server calls socket.end it will result in an empty error message.

Just minor UX thing, I've seen similar with other clients when shutting down the node. Best guess if there is no message is that the server closed the connection, can observe if this results in wrong messages for some clients but so far haven't seen other cases.

Description

Add default message if server closes eventstream

@nflaig nflaig requested a review from a team as a code owner June 20, 2024 19:47
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.75%. Comparing base (0c5adec) to head (258aa54).

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6902   +/-   ##
=========================================
  Coverage     62.75%   62.75%           
=========================================
  Files           578      578           
  Lines         61352    61353    +1     
  Branches       2121     2125    +4     
=========================================
+ Hits          38501    38502    +1     
  Misses        22813    22813           
  Partials         38       38

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: eae97e6 Previous: 0c5adec Ratio
bitArray.getTrueBitIndexes() bitLen 512 4.0240 us/op 13.087 us/op 0.31
Set add up to 128 items then delete last 3.8101 us/op 11.805 us/op 0.32
Full benchmark results
Benchmark suite Current: eae97e6 Previous: 0c5adec Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 775.62 us/op 619.68 us/op 1.25
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 42.229 us/op 76.017 us/op 0.56
BLS verify - blst-native 1.0920 ms/op 1.4776 ms/op 0.74
BLS verifyMultipleSignatures 3 - blst-native 2.4168 ms/op 3.1705 ms/op 0.76
BLS verifyMultipleSignatures 8 - blst-native 5.3335 ms/op 6.8231 ms/op 0.78
BLS verifyMultipleSignatures 32 - blst-native 19.765 ms/op 25.037 ms/op 0.79
BLS verifyMultipleSignatures 64 - blst-native 39.110 ms/op 50.190 ms/op 0.78
BLS verifyMultipleSignatures 128 - blst-native 77.541 ms/op 94.579 ms/op 0.82
BLS deserializing 10000 signatures 814.21 ms/op 1.0225 s/op 0.80
BLS deserializing 100000 signatures 8.0176 s/op 9.9922 s/op 0.80
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.1597 ms/op 1.3470 ms/op 0.86
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.3150 ms/op 1.6758 ms/op 0.78
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.0723 ms/op 2.4959 ms/op 0.83
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.6049 ms/op 3.9302 ms/op 0.92
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.0914 ms/op 6.8946 ms/op 0.74
BLS aggregatePubkeys 32 - blst-native 22.381 us/op 29.387 us/op 0.76
BLS aggregatePubkeys 128 - blst-native 85.403 us/op 115.56 us/op 0.74
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 63.782 ms/op 89.877 ms/op 0.71
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 49.572 ms/op 67.452 ms/op 0.73
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 28.113 ms/op 42.841 ms/op 0.66
getSlashingsAndExits - default max 73.896 us/op 176.72 us/op 0.42
getSlashingsAndExits - 2k 293.07 us/op 462.84 us/op 0.63
proposeBlockBody type=full, size=empty 4.7263 ms/op 7.6411 ms/op 0.62
isKnown best case - 1 super set check 487.00 ns/op 618.00 ns/op 0.79
isKnown normal case - 2 super set checks 481.00 ns/op 552.00 ns/op 0.87
isKnown worse case - 16 super set checks 489.00 ns/op 512.00 ns/op 0.96
InMemoryCheckpointStateCache - add get delete 4.5570 us/op 6.5500 us/op 0.70
validate api signedAggregateAndProof - struct 2.3584 ms/op 2.9312 ms/op 0.80
validate gossip signedAggregateAndProof - struct 2.3181 ms/op 3.1825 ms/op 0.73
validate gossip attestation - vc 640000 1.1663 ms/op 1.5466 ms/op 0.75
batch validate gossip attestation - vc 640000 - chunk 32 145.28 us/op 193.11 us/op 0.75
batch validate gossip attestation - vc 640000 - chunk 64 119.88 us/op 190.09 us/op 0.63
batch validate gossip attestation - vc 640000 - chunk 128 111.26 us/op 182.78 us/op 0.61
batch validate gossip attestation - vc 640000 - chunk 256 109.89 us/op 176.75 us/op 0.62
pickEth1Vote - no votes 854.70 us/op 1.6014 ms/op 0.53
pickEth1Vote - max votes 10.391 ms/op 15.833 ms/op 0.66
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.655 ms/op 19.625 ms/op 0.90
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.945 ms/op 32.619 ms/op 0.70
pickEth1Vote - Eth1Data fastSerialize value x2048 366.92 us/op 739.87 us/op 0.50
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.0315 ms/op 6.3051 ms/op 1.12
bytes32 toHexString 627.00 ns/op 932.00 ns/op 0.67
bytes32 Buffer.toString(hex) 511.00 ns/op 318.00 ns/op 1.61
bytes32 Buffer.toString(hex) from Uint8Array 602.00 ns/op 589.00 ns/op 1.02
bytes32 Buffer.toString(hex) + 0x 494.00 ns/op 320.00 ns/op 1.54
Object access 1 prop 0.34200 ns/op 0.25100 ns/op 1.36
Map access 1 prop 0.35000 ns/op 0.15600 ns/op 2.24
Object get x1000 5.1910 ns/op 7.7600 ns/op 0.67
Map get x1000 5.9400 ns/op 8.2820 ns/op 0.72
Object set x1000 25.505 ns/op 69.096 ns/op 0.37
Map set x1000 20.268 ns/op 48.771 ns/op 0.42
Return object 10000 times 0.30040 ns/op 0.39090 ns/op 0.77
Throw Error 10000 times 2.8069 us/op 4.2758 us/op 0.66
fastMsgIdFn sha256 / 200 bytes 2.0270 us/op 2.7300 us/op 0.74
fastMsgIdFn h32 xxhash / 200 bytes 442.00 ns/op 384.00 ns/op 1.15
fastMsgIdFn h64 xxhash / 200 bytes 477.00 ns/op 329.00 ns/op 1.45
fastMsgIdFn sha256 / 1000 bytes 6.0810 us/op 9.5040 us/op 0.64
fastMsgIdFn h32 xxhash / 1000 bytes 547.00 ns/op 539.00 ns/op 1.01
fastMsgIdFn h64 xxhash / 1000 bytes 550.00 ns/op 421.00 ns/op 1.31
fastMsgIdFn sha256 / 10000 bytes 51.581 us/op 75.700 us/op 0.68
fastMsgIdFn h32 xxhash / 10000 bytes 2.0300 us/op 2.2740 us/op 0.89
fastMsgIdFn h64 xxhash / 10000 bytes 1.4060 us/op 1.5230 us/op 0.92
send data - 1000 256B messages 10.706 ms/op 20.382 ms/op 0.53
send data - 1000 512B messages 15.740 ms/op 28.996 ms/op 0.54
send data - 1000 1024B messages 26.188 ms/op 38.580 ms/op 0.68
send data - 1000 1200B messages 26.362 ms/op 39.694 ms/op 0.66
send data - 1000 2048B messages 30.984 ms/op 50.982 ms/op 0.61
send data - 1000 4096B messages 28.790 ms/op 48.830 ms/op 0.59
send data - 1000 16384B messages 68.890 ms/op 116.49 ms/op 0.59
send data - 1000 65536B messages 255.24 ms/op 431.36 ms/op 0.59
enrSubnets - fastDeserialize 64 bits 1.1370 us/op 1.8960 us/op 0.60
enrSubnets - ssz BitVector 64 bits 565.00 ns/op 571.00 ns/op 0.99
enrSubnets - fastDeserialize 4 bits 354.00 ns/op 255.00 ns/op 1.39
enrSubnets - ssz BitVector 4 bits 552.00 ns/op 584.00 ns/op 0.95
prioritizePeers score -10:0 att 32-0.1 sync 2-0 113.60 us/op 267.81 us/op 0.42
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 157.52 us/op 322.31 us/op 0.49
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 235.91 us/op 477.37 us/op 0.49
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 361.04 us/op 650.31 us/op 0.56
prioritizePeers score 0:0 att 64-1 sync 4-1 445.31 us/op 1.1613 ms/op 0.38
array of 16000 items push then shift 1.2697 us/op 2.0152 us/op 0.63
LinkedList of 16000 items push then shift 6.8290 ns/op 14.059 ns/op 0.49
array of 16000 items push then pop 86.220 ns/op 215.81 ns/op 0.40
LinkedList of 16000 items push then pop 6.4930 ns/op 13.341 ns/op 0.49
array of 24000 items push then shift 1.9614 us/op 3.5171 us/op 0.56
LinkedList of 24000 items push then shift 6.5470 ns/op 12.924 ns/op 0.51
array of 24000 items push then pop 107.29 ns/op 293.75 ns/op 0.37
LinkedList of 24000 items push then pop 6.3740 ns/op 14.149 ns/op 0.45
intersect bitArray bitLen 8 5.4520 ns/op 11.084 ns/op 0.49
intersect array and set length 8 38.148 ns/op 116.66 ns/op 0.33
intersect bitArray bitLen 128 27.115 ns/op 37.562 ns/op 0.72
intersect array and set length 128 581.33 ns/op 1.1563 us/op 0.50
bitArray.getTrueBitIndexes() bitLen 128 1.3820 us/op 3.4040 us/op 0.41
bitArray.getTrueBitIndexes() bitLen 248 2.2750 us/op 6.5750 us/op 0.35
bitArray.getTrueBitIndexes() bitLen 512 4.0240 us/op 13.087 us/op 0.31
Buffer.concat 32 items 989.00 ns/op 1.3790 us/op 0.72
Uint8Array.set 32 items 1.5190 us/op 3.0270 us/op 0.50
Buffer.copy 1.6720 us/op 3.8050 us/op 0.44
Uint8Array.set - with subarray 1.8580 us/op 5.1490 us/op 0.36
Uint8Array.set - without subarray 1.5240 us/op 2.9990 us/op 0.51
Set add up to 64 items then delete first 1.7622 us/op 4.2566 us/op 0.41
OrderedSet add up to 64 items then delete first 2.7131 us/op 6.8735 us/op 0.39
Set add up to 64 items then delete last 1.9959 us/op 4.7293 us/op 0.42
OrderedSet add up to 64 items then delete last 3.0719 us/op 7.0096 us/op 0.44
Set add up to 64 items then delete middle 1.9986 us/op 4.8429 us/op 0.41
OrderedSet add up to 64 items then delete middle 4.4331 us/op 9.8596 us/op 0.45
Set add up to 128 items then delete first 3.9719 us/op 9.9193 us/op 0.40
OrderedSet add up to 128 items then delete first 6.1843 us/op 13.757 us/op 0.45
Set add up to 128 items then delete last 3.8101 us/op 11.805 us/op 0.32
OrderedSet add up to 128 items then delete last 5.8008 us/op 15.144 us/op 0.38
Set add up to 128 items then delete middle 3.8221 us/op 9.9400 us/op 0.38
OrderedSet add up to 128 items then delete middle 11.707 us/op 23.211 us/op 0.50
Set add up to 256 items then delete first 7.8011 us/op 21.638 us/op 0.36
OrderedSet add up to 256 items then delete first 12.280 us/op 31.194 us/op 0.39
Set add up to 256 items then delete last 7.5120 us/op 15.824 us/op 0.47
OrderedSet add up to 256 items then delete last 11.517 us/op 25.106 us/op 0.46
Set add up to 256 items then delete middle 7.4802 us/op 15.809 us/op 0.47
OrderedSet add up to 256 items then delete middle 34.058 us/op 55.824 us/op 0.61
transfer serialized Status (84 B) 1.5430 us/op 2.0460 us/op 0.75
copy serialized Status (84 B) 1.3780 us/op 1.6650 us/op 0.83
transfer serialized SignedVoluntaryExit (112 B) 1.4650 us/op 2.0210 us/op 0.72
copy serialized SignedVoluntaryExit (112 B) 1.2380 us/op 1.7640 us/op 0.70
transfer serialized ProposerSlashing (416 B) 1.6550 us/op 2.6370 us/op 0.63
copy serialized ProposerSlashing (416 B) 1.3930 us/op 2.6140 us/op 0.53
transfer serialized Attestation (485 B) 1.6270 us/op 2.5720 us/op 0.63
copy serialized Attestation (485 B) 2.2010 us/op 2.8300 us/op 0.78
transfer serialized AttesterSlashing (33232 B) 2.4190 us/op 2.4710 us/op 0.98
copy serialized AttesterSlashing (33232 B) 12.096 us/op 13.715 us/op 0.88
transfer serialized Small SignedBeaconBlock (128000 B) 3.1140 us/op 4.7800 us/op 0.65
copy serialized Small SignedBeaconBlock (128000 B) 14.816 us/op 37.620 us/op 0.39
transfer serialized Avg SignedBeaconBlock (200000 B) 3.5950 us/op 5.2920 us/op 0.68
copy serialized Avg SignedBeaconBlock (200000 B) 19.640 us/op 59.666 us/op 0.33
transfer serialized BlobsSidecar (524380 B) 3.5900 us/op 7.0910 us/op 0.51
copy serialized BlobsSidecar (524380 B) 67.629 us/op 183.63 us/op 0.37
transfer serialized Big SignedBeaconBlock (1000000 B) 3.6580 us/op 7.8490 us/op 0.47
copy serialized Big SignedBeaconBlock (1000000 B) 139.07 us/op 343.06 us/op 0.41
pass gossip attestations to forkchoice per slot 2.5333 ms/op 3.8179 ms/op 0.66
forkChoice updateHead vc 100000 bc 64 eq 0 431.92 us/op 896.19 us/op 0.48
forkChoice updateHead vc 600000 bc 64 eq 0 2.4607 ms/op 5.0928 ms/op 0.48
forkChoice updateHead vc 1000000 bc 64 eq 0 4.3067 ms/op 8.5386 ms/op 0.50
forkChoice updateHead vc 600000 bc 320 eq 0 2.4460 ms/op 4.0774 ms/op 0.60
forkChoice updateHead vc 600000 bc 1200 eq 0 2.5433 ms/op 4.4804 ms/op 0.57
forkChoice updateHead vc 600000 bc 7200 eq 0 2.7864 ms/op 6.2036 ms/op 0.45
forkChoice updateHead vc 600000 bc 64 eq 1000 9.7411 ms/op 13.136 ms/op 0.74
forkChoice updateHead vc 600000 bc 64 eq 10000 9.5751 ms/op 13.304 ms/op 0.72
forkChoice updateHead vc 600000 bc 64 eq 300000 12.008 ms/op 22.386 ms/op 0.54
computeDeltas 500000 validators 300 proto nodes 2.9910 ms/op 4.6834 ms/op 0.64
computeDeltas 500000 validators 1200 proto nodes 2.9403 ms/op 5.4797 ms/op 0.54
computeDeltas 500000 validators 7200 proto nodes 2.8997 ms/op 6.0617 ms/op 0.48
computeDeltas 750000 validators 300 proto nodes 4.4077 ms/op 8.6420 ms/op 0.51
computeDeltas 750000 validators 1200 proto nodes 4.3082 ms/op 8.6845 ms/op 0.50
computeDeltas 750000 validators 7200 proto nodes 4.2899 ms/op 9.3239 ms/op 0.46
computeDeltas 1400000 validators 300 proto nodes 8.4437 ms/op 16.729 ms/op 0.50
computeDeltas 1400000 validators 1200 proto nodes 8.2302 ms/op 18.195 ms/op 0.45
computeDeltas 1400000 validators 7200 proto nodes 8.0074 ms/op 13.131 ms/op 0.61
computeDeltas 2100000 validators 300 proto nodes 12.460 ms/op 19.998 ms/op 0.62
computeDeltas 2100000 validators 1200 proto nodes 13.155 ms/op 18.688 ms/op 0.70
computeDeltas 2100000 validators 7200 proto nodes 12.677 ms/op 19.766 ms/op 0.64
altair processAttestation - 250000 vs - 7PWei normalcase 1.7689 ms/op 2.5484 ms/op 0.69
altair processAttestation - 250000 vs - 7PWei worstcase 2.3421 ms/op 3.1855 ms/op 0.74
altair processAttestation - setStatus - 1/6 committees join 93.148 us/op 112.12 us/op 0.83
altair processAttestation - setStatus - 1/3 committees join 138.61 us/op 203.14 us/op 0.68
altair processAttestation - setStatus - 1/2 committees join 213.24 us/op 271.63 us/op 0.79
altair processAttestation - setStatus - 2/3 committees join 290.85 us/op 403.89 us/op 0.72
altair processAttestation - setStatus - 4/5 committees join 401.67 us/op 638.86 us/op 0.63
altair processAttestation - setStatus - 100% committees join 513.09 us/op 726.19 us/op 0.71
altair processBlock - 250000 vs - 7PWei normalcase 4.6145 ms/op 5.5789 ms/op 0.83
altair processBlock - 250000 vs - 7PWei normalcase hashState 25.162 ms/op 34.699 ms/op 0.73
altair processBlock - 250000 vs - 7PWei worstcase 39.312 ms/op 49.004 ms/op 0.80
altair processBlock - 250000 vs - 7PWei worstcase hashState 81.470 ms/op 87.681 ms/op 0.93
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3510 ms/op 3.0786 ms/op 0.76
phase0 processBlock - 250000 vs - 7PWei worstcase 28.911 ms/op 39.512 ms/op 0.73
altair processEth1Data - 250000 vs - 7PWei normalcase 273.50 us/op 695.05 us/op 0.39
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 5.4530 us/op 8.5090 us/op 0.64
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 20.126 us/op 27.855 us/op 0.72
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 7.4340 us/op 9.5710 us/op 0.78
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 5.9010 us/op 7.4740 us/op 0.79
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 82.119 us/op 98.339 us/op 0.84
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 617.78 us/op 843.37 us/op 0.73
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 684.61 us/op 1.5860 ms/op 0.43
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 771.18 us/op 1.0471 ms/op 0.74
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.1540 ms/op 2.6630 ms/op 0.81
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.2092 ms/op 2.3265 ms/op 0.52
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.2426 ms/op 4.1093 ms/op 0.79
Tree 40 250000 create 342.79 ms/op 258.95 ms/op 1.32
Tree 40 250000 get(125000) 120.48 ns/op 145.01 ns/op 0.83
Tree 40 250000 set(125000) 592.26 ns/op 642.77 ns/op 0.92
Tree 40 250000 toArray() 18.908 ms/op 16.022 ms/op 1.18
Tree 40 250000 iterate all - toArray() + loop 20.042 ms/op 16.533 ms/op 1.21
Tree 40 250000 iterate all - get(i) 51.012 ms/op 58.858 ms/op 0.87
MutableVector 250000 create 12.396 ms/op 9.8901 ms/op 1.25
MutableVector 250000 get(125000) 6.2300 ns/op 6.4830 ns/op 0.96
MutableVector 250000 set(125000) 183.38 ns/op 220.32 ns/op 0.83
MutableVector 250000 toArray() 3.0370 ms/op 3.7209 ms/op 0.82
MutableVector 250000 iterate all - toArray() + loop 3.1120 ms/op 3.8352 ms/op 0.81
MutableVector 250000 iterate all - get(i) 2.3994 ms/op 1.8062 ms/op 1.33
Array 250000 create 2.8838 ms/op 3.1854 ms/op 0.91
Array 250000 clone - spread 1.2280 ms/op 1.6021 ms/op 0.77
Array 250000 get(125000) 0.59500 ns/op 0.44000 ns/op 1.35
Array 250000 set(125000) 0.61400 ns/op 0.45500 ns/op 1.35
Array 250000 iterate all - loop 79.969 us/op 85.968 us/op 0.93
effectiveBalanceIncrements clone Uint8Array 300000 13.729 us/op 36.081 us/op 0.38
effectiveBalanceIncrements clone MutableVector 300000 321.00 ns/op 127.00 ns/op 2.53
effectiveBalanceIncrements rw all Uint8Array 300000 174.17 us/op 211.94 us/op 0.82
effectiveBalanceIncrements rw all MutableVector 300000 52.826 ms/op 72.309 ms/op 0.73
phase0 afterProcessEpoch - 250000 vs - 7PWei 80.625 ms/op 94.118 ms/op 0.86
phase0 beforeProcessEpoch - 250000 vs - 7PWei 41.171 ms/op 37.085 ms/op 1.11
altair processEpoch - mainnet_e81889 345.85 ms/op 464.58 ms/op 0.74
mainnet_e81889 - altair beforeProcessEpoch 61.348 ms/op 73.081 ms/op 0.84
mainnet_e81889 - altair processJustificationAndFinalization 15.282 us/op 17.216 us/op 0.89
mainnet_e81889 - altair processInactivityUpdates 4.6691 ms/op 7.6398 ms/op 0.61
mainnet_e81889 - altair processRewardsAndPenalties 52.421 ms/op 46.035 ms/op 1.14
mainnet_e81889 - altair processRegistryUpdates 4.4920 us/op 2.0630 us/op 2.18
mainnet_e81889 - altair processSlashings 1.0320 us/op 627.00 ns/op 1.65
mainnet_e81889 - altair processEth1DataReset 879.00 ns/op 383.00 ns/op 2.30
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.0267 ms/op 1.6256 ms/op 0.63
mainnet_e81889 - altair processSlashingsReset 4.5860 us/op 8.4550 us/op 0.54
mainnet_e81889 - altair processRandaoMixesReset 5.1840 us/op 11.948 us/op 0.43
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2920 us/op 1.3610 us/op 0.95
mainnet_e81889 - altair processParticipationFlagUpdates 2.6930 us/op 4.1800 us/op 0.64
mainnet_e81889 - altair processSyncCommitteeUpdates 1.2010 us/op 1.0890 us/op 1.10
mainnet_e81889 - altair afterProcessEpoch 85.373 ms/op 123.05 ms/op 0.69
capella processEpoch - mainnet_e217614 1.2470 s/op 1.4419 s/op 0.86
mainnet_e217614 - capella beforeProcessEpoch 251.63 ms/op 253.92 ms/op 0.99
mainnet_e217614 - capella processJustificationAndFinalization 16.505 us/op 12.990 us/op 1.27
mainnet_e217614 - capella processInactivityUpdates 17.746 ms/op 18.460 ms/op 0.96
mainnet_e217614 - capella processRewardsAndPenalties 247.18 ms/op 260.57 ms/op 0.95
mainnet_e217614 - capella processRegistryUpdates 12.465 us/op 12.793 us/op 0.97
mainnet_e217614 - capella processSlashings 1.1400 us/op 398.00 ns/op 2.86
mainnet_e217614 - capella processEth1DataReset 991.00 ns/op 282.00 ns/op 3.51
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.1945 ms/op 10.729 ms/op 0.39
mainnet_e217614 - capella processSlashingsReset 5.7860 us/op 2.5110 us/op 2.30
mainnet_e217614 - capella processRandaoMixesReset 11.068 us/op 4.6920 us/op 2.36
mainnet_e217614 - capella processHistoricalRootsUpdate 1.2800 us/op 1.8290 us/op 0.70
mainnet_e217614 - capella processParticipationFlagUpdates 2.8540 us/op 2.5170 us/op 1.13
mainnet_e217614 - capella afterProcessEpoch 264.09 ms/op 256.35 ms/op 1.03
phase0 processEpoch - mainnet_e58758 354.10 ms/op 420.02 ms/op 0.84
mainnet_e58758 - phase0 beforeProcessEpoch 106.95 ms/op 113.38 ms/op 0.94
mainnet_e58758 - phase0 processJustificationAndFinalization 15.273 us/op 16.256 us/op 0.94
mainnet_e58758 - phase0 processRewardsAndPenalties 35.494 ms/op 33.727 ms/op 1.05
mainnet_e58758 - phase0 processRegistryUpdates 6.8620 us/op 8.0330 us/op 0.85
mainnet_e58758 - phase0 processSlashings 875.00 ns/op 431.00 ns/op 2.03
mainnet_e58758 - phase0 processEth1DataReset 719.00 ns/op 380.00 ns/op 1.89
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1104 ms/op 1.2365 ms/op 0.90
mainnet_e58758 - phase0 processSlashingsReset 3.0970 us/op 4.7960 us/op 0.65
mainnet_e58758 - phase0 processRandaoMixesReset 2.9480 us/op 4.6780 us/op 0.63
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0840 us/op 326.00 ns/op 3.33
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.2650 us/op 4.9000 us/op 0.67
mainnet_e58758 - phase0 afterProcessEpoch 70.750 ms/op 89.641 ms/op 0.79
phase0 processEffectiveBalanceUpdates - 250000 normalcase 811.18 us/op 2.2116 ms/op 0.37
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4351 ms/op 2.1402 ms/op 0.67
altair processInactivityUpdates - 250000 normalcase 16.516 ms/op 22.304 ms/op 0.74
altair processInactivityUpdates - 250000 worstcase 19.696 ms/op 25.722 ms/op 0.77
phase0 processRegistryUpdates - 250000 normalcase 11.033 us/op 7.6690 us/op 1.44
phase0 processRegistryUpdates - 250000 badcase_full_deposits 311.69 us/op 332.86 us/op 0.94
phase0 processRegistryUpdates - 250000 worstcase 0.5 113.68 ms/op 155.59 ms/op 0.73
altair processRewardsAndPenalties - 250000 normalcase 42.138 ms/op 44.806 ms/op 0.94
altair processRewardsAndPenalties - 250000 worstcase 35.943 ms/op 47.774 ms/op 0.75
phase0 getAttestationDeltas - 250000 normalcase 6.2929 ms/op 8.4284 ms/op 0.75
phase0 getAttestationDeltas - 250000 worstcase 8.0427 ms/op 8.9506 ms/op 0.90
phase0 processSlashings - 250000 worstcase 87.610 us/op 117.53 us/op 0.75
altair processSyncCommitteeUpdates - 250000 103.31 ms/op 137.45 ms/op 0.75
BeaconState.hashTreeRoot - No change 510.00 ns/op 464.00 ns/op 1.10
BeaconState.hashTreeRoot - 1 full validator 86.877 us/op 126.01 us/op 0.69
BeaconState.hashTreeRoot - 32 full validator 1.4204 ms/op 1.6665 ms/op 0.85
BeaconState.hashTreeRoot - 512 full validator 10.171 ms/op 13.113 ms/op 0.78
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 163.71 us/op 177.63 us/op 0.92
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.2359 ms/op 2.4925 ms/op 0.90
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 28.761 ms/op 27.184 ms/op 1.06
BeaconState.hashTreeRoot - 1 balances 111.26 us/op 133.70 us/op 0.83
BeaconState.hashTreeRoot - 32 balances 760.35 us/op 1.5460 ms/op 0.49
BeaconState.hashTreeRoot - 512 balances 6.5771 ms/op 13.318 ms/op 0.49
BeaconState.hashTreeRoot - 250000 balances 138.25 ms/op 226.20 ms/op 0.61
aggregationBits - 2048 els - zipIndexesInBitList 20.490 us/op 33.420 us/op 0.61
byteArrayEquals 32 48.485 ns/op 63.955 ns/op 0.76
Buffer.compare 32 16.214 ns/op 21.819 ns/op 0.74
byteArrayEquals 1024 1.2812 us/op 1.8763 us/op 0.68
Buffer.compare 1024 24.464 ns/op 31.007 ns/op 0.79
byteArrayEquals 16384 20.487 us/op 29.557 us/op 0.69
Buffer.compare 16384 204.80 ns/op 241.93 ns/op 0.85
byteArrayEquals 123687377 154.23 ms/op 217.01 ms/op 0.71
Buffer.compare 123687377 5.0063 ms/op 9.2791 ms/op 0.54
byteArrayEquals 32 - diff last byte 48.038 ns/op 60.859 ns/op 0.79
Buffer.compare 32 - diff last byte 16.253 ns/op 20.143 ns/op 0.81
byteArrayEquals 1024 - diff last byte 1.2827 us/op 1.8102 us/op 0.71
Buffer.compare 1024 - diff last byte 27.630 ns/op 30.171 ns/op 0.92
byteArrayEquals 16384 - diff last byte 20.664 us/op 28.525 us/op 0.72
Buffer.compare 16384 - diff last byte 175.16 ns/op 207.76 ns/op 0.84
byteArrayEquals 123687377 - diff last byte 159.41 ms/op 204.70 ms/op 0.78
Buffer.compare 123687377 - diff last byte 6.2822 ms/op 7.2684 ms/op 0.86
byteArrayEquals 32 - random bytes 5.5480 ns/op 5.6770 ns/op 0.98
Buffer.compare 32 - random bytes 16.305 ns/op 19.312 ns/op 0.84
byteArrayEquals 1024 - random bytes 5.1460 ns/op 5.8390 ns/op 0.88
Buffer.compare 1024 - random bytes 16.761 ns/op 19.089 ns/op 0.88
byteArrayEquals 16384 - random bytes 5.2500 ns/op 5.6090 ns/op 0.94
Buffer.compare 16384 - random bytes 15.846 ns/op 19.063 ns/op 0.83
byteArrayEquals 123687377 - random bytes 8.1300 ns/op 6.8800 ns/op 1.18
Buffer.compare 123687377 - random bytes 19.220 ns/op 20.330 ns/op 0.95
regular array get 100000 times 31.716 us/op 34.088 us/op 0.93
wrappedArray get 100000 times 31.980 us/op 45.015 us/op 0.71
arrayWithProxy get 100000 times 10.362 ms/op 14.690 ms/op 0.71
ssz.Root.equals 44.879 ns/op 50.251 ns/op 0.89
byteArrayEquals 45.281 ns/op 49.250 ns/op 0.92
Buffer.compare 9.6710 ns/op 11.424 ns/op 0.85
shuffle list - 16384 els 5.7207 ms/op 6.6404 ms/op 0.86
shuffle list - 250000 els 86.794 ms/op 97.916 ms/op 0.89
processSlot - 1 slots 17.224 us/op 13.379 us/op 1.29
processSlot - 32 slots 2.6856 ms/op 3.1022 ms/op 0.87
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 35.954 ms/op 41.050 ms/op 0.88
getCommitteeAssignments - req 1 vs - 250000 vc 1.7727 ms/op 2.2469 ms/op 0.79
getCommitteeAssignments - req 100 vs - 250000 vc 3.5628 ms/op 4.1451 ms/op 0.86
getCommitteeAssignments - req 1000 vs - 250000 vc 3.8420 ms/op 4.6975 ms/op 0.82
findModifiedValidators - 10000 modified validators 225.29 ms/op 271.55 ms/op 0.83
findModifiedValidators - 1000 modified validators 173.13 ms/op 213.74 ms/op 0.81
findModifiedValidators - 100 modified validators 170.30 ms/op 247.87 ms/op 0.69
findModifiedValidators - 10 modified validators 200.87 ms/op 218.97 ms/op 0.92
findModifiedValidators - 1 modified validators 186.96 ms/op 183.18 ms/op 1.02
findModifiedValidators - no difference 172.38 ms/op 193.15 ms/op 0.89
compare ViewDUs 3.5901 s/op 3.5239 s/op 1.02
compare each validator Uint8Array 1.2309 s/op 1.9933 s/op 0.62
compare ViewDU to Uint8Array 1.0111 s/op 1.6105 s/op 0.63
migrate state 1000000 validators, 24 modified, 0 new 504.67 ms/op 857.15 ms/op 0.59
migrate state 1000000 validators, 1700 modified, 1000 new 761.33 ms/op 1.1332 s/op 0.67
migrate state 1000000 validators, 3400 modified, 2000 new 1.0195 s/op 1.3658 s/op 0.75
migrate state 1500000 validators, 24 modified, 0 new 516.22 ms/op 773.17 ms/op 0.67
migrate state 1500000 validators, 1700 modified, 1000 new 869.29 ms/op 964.43 ms/op 0.90
migrate state 1500000 validators, 3400 modified, 2000 new 914.05 ms/op 1.1207 s/op 0.82
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.1700 ns/op 4.8100 ns/op 1.28
state getBlockRootAtSlot - 250000 vs - 7PWei 373.69 ns/op 494.80 ns/op 0.76
computeProposers - vc 250000 5.5947 ms/op 7.4824 ms/op 0.75
computeEpochShuffling - vc 250000 85.549 ms/op 99.770 ms/op 0.86
getNextSyncCommittee - vc 250000 96.095 ms/op 133.61 ms/op 0.72
computeSigningRoot for AttestationData 17.768 us/op 18.250 us/op 0.97
hash AttestationData serialized data then Buffer.toString(base64) 1.2003 us/op 1.5729 us/op 0.76
toHexString serialized data 772.38 ns/op 955.30 ns/op 0.81
Buffer.toString(base64) 140.57 ns/op 185.67 ns/op 0.76

by benchmarkbot/action

@wemeetagain wemeetagain merged commit a074310 into unstable Jun 20, 2024
20 checks passed
@wemeetagain wemeetagain deleted the nflaig/eventstream-default-error branch June 20, 2024 21:09
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.20.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain