-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup usage of blinded types #6903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6903 +/- ##
============================================
- Coverage 62.56% 62.54% -0.03%
============================================
Files 575 575
Lines 61066 61012 -54
Branches 2122 2112 -10
============================================
- Hits 38208 38161 -47
+ Misses 22819 22812 -7
Partials 39 39 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
previously approved these changes
Jun 24, 2024
nflaig
approved these changes
Jun 24, 2024
🎉 This PR is included in v1.20.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't want to hide or shadow an actual consensus type name. And as defined in
params
package the blinded is not a defined fork group, so rather tend to use actual group name everywhere which is execution.Description
Based on discussion we dont want to hide/shadow an actual type. The blinded types implementation renames types, e.g.
BlindedBeaconBlock
toBeaconBlock
. Which is another consensus type. No such pattern used elsewhere for other fork groups.Blinded itself is not defined as a fork group in
params
package, so keeping that implementation requires an extra effort.Steps to test or reproduce