-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getHealth returns 206 status code if EL is optimistic or offline #6920
Conversation
Something else to consider is if EL is offline, this is not clearly defined in the spec but Lodestar considers itself synced for 32 slots until head is too far behind but it's can't properly serve all requests, so it might be better to immediately return a 206 status code in that case as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6920 +/- ##
=========================================
Coverage 62.52% 62.52%
=========================================
Files 575 575
Lines 60985 60985
Branches 2118 2121 +3
=========================================
+ Hits 38128 38129 +1
+ Misses 22818 22817 -1
Partials 39 39 |
Performance Report✔️ no performance regression detected Full benchmark results
|
|
🎉 This PR is included in v1.20.0 🎉 |
Motivation
Description
getHealth
returns 206 status code if EL is syncing / optimisticCloses #6664