-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expose metadata headers to scripts running in the browser #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6952 +/- ##
=========================================
Coverage 62.52% 62.52%
=========================================
Files 575 575
Lines 61055 61068 +13
Branches 2129 2129
=========================================
+ Hits 38173 38185 +12
- Misses 22843 22844 +1
Partials 39 39 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 15, 2024
🎉 This PR is included in v1.20.1 🎉 |
🎉 This PR is included in v1.21.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When returning data from light client api to the browser in SSZ format we rely on the metadata headers to determine the fork version. Those are not exposed by default so we need explicitly list them in
Access-Control-Expose-Headers
header.This currently causes issues in our browser tests and to users running light client in browser as we return SSZ by default, whereas in JSON responses the version was part of the payload (not header).
Description
Expose metadata headers to scripts running in the browser by setting a corresponding
Access-Control-Expose-Headers
header