chore: refactor block and state api utils #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6963 +/- ##
============================================
- Coverage 62.52% 62.49% -0.03%
============================================
Files 576 576
Lines 61171 61171
Branches 2140 2139 -1
============================================
- Hits 38245 38231 -14
- Misses 22888 22901 +13
- Partials 38 39 +1 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Jul 18, 2024
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
nflaig
reviewed
Jul 18, 2024
| // TODO: This is not OK, head and headState must be fetched atomically | ||
| const head = chain.forkChoice.getHead(); | ||
| const headState = chain.getHeadState(); | ||
| return {state: headState, executionOptimistic: isOptimisticBlock(head), finalized: false}; |
There was a problem hiding this comment.
@wemeetagain wondering here, we got the head state from getHeadState() which called getClosestHeadState
so we would previouly do this
which queried both blockStateCache and checkpointStateCache
while now we would just query blockStateCache
lodestar/packages/beacon-node/src/chain/regen/queued.ts
Lines 79 to 80 in fed08fe
There was a problem hiding this comment.
@nflaig , the change actually made it better. Previously we also queried the head state pulled up to next epoch in the checkpointStateCache which is only necessary for block processing while the "getHeadState()" api only wants the real head state. So it's better to only query blockStateCache in this case
|
🎉 This PR is included in v1.21.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
resolveBlockIdandresolveStateId)resolve*functions return a concrete slot or root which can be fetched using the chaingetBlockResponseandgetStateResponsegetStateResponseWithRegenis created with unimplemented logic and a special return type.