chore: unpin nodejs version from 22.4 #6982
Draft
+30
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f20484b.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6982 +/- ##
=========================================
Coverage 62.49% 62.49%
=========================================
Files 576 576
Lines 61170 61170
Branches 2134 2137 +3
=========================================
Hits 38227 38227
Misses 22904 22904
Partials 39 39 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Jul 28, 2024
|
moving to draft as it seems we have some consensus to wait until 22 becomes active LTS |
nflaig
reviewed
Aug 1, 2024
| node-version: 22.4 | ||
| cache: yarn | ||
| node-version: 22 | ||
| cache: yarn |
There was a problem hiding this comment.
we shouldn't re-add the white space here, and in a few other places
There was a problem hiding this comment.
Didn't added anything manually, just reverted the earlier merged PR.
There was a problem hiding this comment.
yes, but if/when we merge this should clean up the diff before that
@wemeetagain Previously we didn't had precedence to only use LTS versions, rather latest version. Even current codebase is still locked upto This PR was reverting an earlier PR because 22.5 introduced a regression, but 22.5.1 fixed it. Don't see any reason to keep restricting upto 22.4. |
I personally don't have confidence in nodejs release process for Having to debug strange node issue is not fun..and we have better things to do |
Yes, I think our experience the other day, where we had to pin the version, changed my mind a little bit. It seems that the nodejs folks treat the new version with more leeway to be actually unstable and breaking before it becomes "current". Once it becomes "current", their standards for something breaking become much higher. I tend to agree with Nico that we don't really care to have our daily progress possibly stopped again by a breaking version, and we can mitigate that by pinning a specific version until it becomes "current" LTS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use the latest stable node release.
Description
Node version 22.5.1 fixes the regressions.
Steps to test or reproduce
Run all tests.