-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add validator identities endpoint #7107
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7107 +/- ##
============================================
- Coverage 50.82% 48.98% -1.85%
============================================
Files 597 597
Lines 39789 39834 +45
Branches 2059 2056 -3
============================================
- Hits 20224 19511 -713
- Misses 19565 20282 +717
- Partials 0 41 +41 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
const openApiFile: OpenApiFile = { | ||
url: `https://raw.githubusercontent.com/nflaig/beacon-api-spec/main/${version}/beacon-node-oapi.json`, | ||
url: `https://github.com/ethereum/beacon-APIs/releases/download/${version}/beacon-node-oapi.json`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally got a pre-release, it already includes the validator identities endpoint
🎉 This PR is included in v1.23.0 🎉 |
Motivation
Description
Adds validator identities endpoint which is a much more lightweight alternative to retrieve the validator index from state compared to getStateValidators and also allows SSZ encoding of response.
There still needs to be another endpoint (see ethereum/beacon-APIs#449) before we can make use of this in the validator client as we currently also print out the status of the validator (although this is purely informational) but other clients that only need the index can make use of this as is.
Keep as draft for now until spec PR is merged.
Closes #7105