-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move validator status type and util to @lodestar/types #7140
Conversation
| "exited_slashed" | ||
| "withdrawal_possible" | ||
| "withdrawal_done"; | ||
export type {ValidatorStatus}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-export for backward compatibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7140 +/- ##
============================================
+ Coverage 49.16% 49.19% +0.03%
============================================
Files 596 597 +1
Lines 39701 39725 +24
Branches 2069 2073 +4
============================================
+ Hits 19518 19542 +24
- Misses 20141 20142 +1
+ Partials 42 41 -1 |
Performance Report✔️ no performance regression detected Full benchmark results
|
🎉 This PR is included in v1.23.0 🎉 |
Motivation
This change allows other devs to reuse
getValidatorStatus
as it is currently not exported from beacon-node package and most users don't want this heavy package as part of their dependency tree.There is also ongoing work to have a ssz api to return validators ethereum/beacon-APIs#449 but this means it won't include the status directly in the response and it needs to be reconstructed on the client side. Moving this function now makes later implementation of new api simpler.
Description
Move validator status type and util to
@lodestar/types