ChainSafe · wemeetagain · Oct 14, 2024 · Oct 11, 2024 · Oct 11, 2024 · Oct 11, 2024
@@ -25,26 +25,15 @@
     "rules": {
       "recommended": true,
       "complexity": {
-        "noForEach": "off",
-        "noStaticOnlyClass": "off",
-        "noThisInStatic": "off",
+        // We need couple of empty exports to make those files as esm modules
         "noUselessEmptyExport": "off",
-        "noUselessTypeConstraint": "error",
+        // We use normal functions for to ease with debugging context
         "useArrowFunction": "off",
-        "useFlatMap": "off",
-        "useLiteralKeys": "off",
-        "useOptionalChain": "off",
-        "useRegexLiterals": "off",
-        "noBannedTypes": "error",
-        "noUselessThisAlias": "error"
+        // This pattern is used a lot earlier in code so disabling this rule
+        "useLiteralKeys": "off"
       },
       "correctness": {
-        "noInvalidConstructorSuper": "off",
-        "noInvalidUseBeforeDeclaration": "off",
-        "noPrecisionLoss": "error",
         "noUnusedVariables": "error",
-        "noVoidTypeReturn": "off",
-        "useYield": "off",
         "useImportExtensions": {
           "level": "error",
           "options": {
@@ -57,33 +46,39 @@
           }
         },
         "useArrayLiterals": "error",
-        "noUndeclaredDependencies": "off", // TODO: Need to see why this rule is not detecting monorepo packages
         "noUndeclaredVariables": "error"
       },
-      "performance": {
-        "noAccumulatingSpread": "off",
-        "noDelete": "off"
-      },
       "style": {
+        // The code usage looks suspicious so it should be enabled in a separate PR
         "noCommaOperator": "off",
-        "noInferrableTypes": "off",
-        "noNonNullAssertion": "error",
+        // There are a lot of places we mutate params, should be fixed in an independent PR.
         "noParameterAssign": "off",
         "noRestrictedGlobals": {
           "level": "error",
           "options": {
             "deniedGlobals": ["fetch"]
           }
         },
-        "noUnusedTemplateLiteral": "off",
+        // There are a lot of places we mutate params, should be fixed in an independent PR.
         "noUselessElse": "off",
-        "noVar": "error",
-        "useConst": "error",
-        "useEnumInitializers": "off",
+        // We prefer to use `Math.pow` over `**` operator
         "useExponentiationOperator": "off",
+        // In some cases the enums are initialized with values of other enums
+        "useLiteralEnumMembers": "off",
+        // We prefer to have multiple declarations lines
+        "useSingleVarDeclarator": "off",
+        // We use `+` operator for string concatenation a lot
+        "useTemplate": "off",
+        // We use to export types and object without differentiating
         "useExportType": "off",
+        // We use to export types and object without differentiating
         "useImportType": "off",
-        "useLiteralEnumMembers": "off",
+        // It's nice to use `Number` namespace but should be done in a separate PR
+        "useNumberNamespace": "off",
+        // We prefer to auto-initialize enums
+        "useEnumInitializers": "off",
+        "noVar": "error",
+        "useConst": "error",
         "useNamingConvention": {
           "level": "error",
           "options": {
@@ -194,34 +189,16 @@
             ]
           }
         },
-        "useNumberNamespace": "off",
-        "useSingleVarDeclarator": "off",
-        "useTemplate": "off",
-        "noNamespace": "error",
-        "useAsConstAssertion": "error"
+        "noNamespace": "error"
       },
       "suspicious": {
-        "noAssignInExpressions": "error",
-        "noAsyncPromiseExecutor": "off",
+        // `void` as type is useful in our case when used as generic constraint e.g. K extends number | void
         "noConfusingVoidType": "off",
-        "noConsoleLog": "error",
-        "noDoubleEquals": "off",
-        "noDuplicateTestHooks": "off",
-        "noExplicitAny": "error",
-        "noExportsInTest": "off",
-        "noFallthroughSwitchClause": "off",
-        "noGlobalIsFinite": "off",
-        "noGlobalIsNan": "off",
+        // There are lot of cases in our code that need a separate PR to enable this rule
         "noImplicitAnyLet": "off",
-        "noPrototypeBuiltins": "off",
-        "noRedundantUseStrict": "off",
-        "noShadowRestrictedNames": "off",
-        "useDefaultSwitchClauseLast": "off",
-        "useGetterReturn": "off",
-        "noExtraNonNullAssertion": "error",
-        "noMisleadingInstantiator": "error",
-        "noUnsafeDeclarationMerging": "error",
-        "noEmptyBlockStatements": "off" // There is a lot of empty code blocks, should be enabled and clean up separately.
+        // There is a lot of empty code blocks, should be enabled and clean up separately.
+        "noEmptyBlockStatements": "off",
+        "noConsoleLog": "error"
       },
       "nursery": {
         "useConsistentMemberAccessibility": {
@@ -369,7 +346,11 @@
     {
       "include": ["**/test/**/*.test.ts"],
       "linter": {
-        "rules": {}
+        "rules": {
+          "complexity": {
+            "useArrowFunction": "off"
+          }
+        }
       }
     }
   ]

@@ -23,9 +23,9 @@ export function getRoutes(config: ChainForkConfig, methods: ApplicationMethods<E
         try {
           // Add injected headers from other plugins. This is required for fastify-cors for example
           // From: https://github.com/NodeFactoryIo/fastify-sse-v2/blob/b1686a979fbf655fb9936c0560294a0c094734d4/src/plugin.ts
-          Object.entries(res.getHeaders()).forEach(([key, value]) => {
+          for (const [key, value] of Object.entries(res.getHeaders())) {
             if (value !== undefined) res.raw.setHeader(key, value);
-          });
+          }
 
           res.raw.setHeader("Content-Type", "text/event-stream");
           res.raw.setHeader("Cache-Control", "no-cache,no-transform");

@@ -352,7 +352,9 @@ export class HttpClient implements IHttpClient {
 
     // Attach global/local signal to this request's controller
     const onSignalAbort = (): void => controller.abort();
-    abortSignals.forEach((s) => s?.addEventListener("abort", onSignalAbort));
+    for (const s of abortSignals) {
+      s?.addEventListener("abort", onSignalAbort);
+    }
 
     const routeId = definition.operationId;
     const {printableUrl, requestWireFormat, responseWireFormat} = init;
@@ -401,7 +403,9 @@ export class HttpClient implements IHttpClient {
       timer?.();
 
       clearTimeout(timeout);
-      abortSignals.forEach((s) => s?.removeEventListener("abort", onSignalAbort));
+      for (const s of abortSignals) {
+        s?.removeEventListener("abort", onSignalAbort);
+      }
     }
   }
 

@@ -70,7 +70,7 @@ export function parseAcceptHeader(accept?: string, supported = SUPPORTED_MEDIA_T
         }
 
         const qvalue = +weight.replace("q=", "");
-        if (isNaN(qvalue) || qvalue > 1 || qvalue <= 0) {
+        if (Number.isNaN(qvalue) || qvalue > 1 || qvalue <= 0) {
           // If we can't convert the qvalue to a valid number, move on
           return best;
         }

@@ -1,5 +1,3 @@
-"use strict";
-
 /**
  * Hypertext Transfer Protocol (HTTP) response status codes.
  * @see {@link https://www.rfc-editor.org/rfc/rfc7231#section-6}

@@ -50,7 +50,7 @@ export type U64Str = string;
 
 export function fromU64Str(u64Str: U64Str): number {
   const u64 = parseInt(u64Str, 10);
-  if (!isFinite(u64)) {
+  if (!Number.isFinite(u64)) {
     throw Error(`Invalid uin64 ${u64Str}`);
   }
   return u64;

@@ -192,7 +192,7 @@ function validateSchema(schema: Parameters<typeof ajv.compile>[0], json: unknown
   if (!valid) {
     // Remove descriptions, for better clarity in rendering on errors
     applyRecursively(schema, (obj) => {
-      delete obj.description;
+      obj.description = undefined;
     });
 
     throw Error(

@@ -139,19 +139,19 @@ function preprocessSchema(schema: JsonSchema): void {
 
   // Remove nullable
   applyRecursively(schema, (obj) => {
-    delete obj.nullable;
+    obj.nullable = undefined;
   });
 
   // Remove required: false
   applyRecursively(schema, (obj) => {
     if (typeof obj.required === "boolean") {
-      delete obj.required;
+      obj.required = undefined;
     }
   });
 
   // Remove non-intersecting allOf enum
   applyRecursively(schema, (obj) => {
-    if (obj.allOf && obj.allOf.every((s) => s.enum)) {
+    if (obj.allOf?.every((s) => s.enum)) {
       obj.allOf = [obj.allOf[0]];
     }
   });

@@ -21,7 +21,7 @@ export function getTestServer(): {server: FastifyInstance; start: () => Promise<
   const start = (): Promise<string> =>
     new Promise<string>((resolve, reject) => {
       server.listen({port: 0}, function (err, address) {
-        if (err !== null && err != undefined) {
+        if (err !== null && err !== undefined) {
           reject(err);
         } else {
           resolve(address);

@@ -50,7 +50,7 @@ export function resolveBlockId(forkChoice: IForkChoice, blockId: routes.beacon.B
 
   // block id must be slot
   const blockSlot = parseInt(blockId, 10);
-  if (isNaN(blockSlot) && isNaN(blockSlot - 0)) {
+  if (Number.isNaN(blockSlot) && Number.isNaN(blockSlot - 0)) {
     throw new ValidationError(`Invalid block id '${blockId}'`, "blockId");
   }
   return blockSlot;

@@ -34,7 +34,7 @@ export function resolveStateId(
 
   // id must be slot
   const blockSlot = parseInt(String(stateId), 10);
-  if (isNaN(blockSlot) && isNaN(blockSlot - 0)) {
+  if (Number.isNaN(blockSlot) && Number.isNaN(blockSlot - 0)) {
     throw new ValidationError(`Invalid block id '${stateId}'`, "blockId");
   }
 

@@ -35,7 +35,7 @@ export class CheckpointBalancesCache {
     const epochBoundaryRoot =
       epochBoundarySlot === state.slot ? blockRootHex : toRootHex(getBlockRootAtSlot(state, epochBoundarySlot));
 
-    const index = this.items.findIndex((item) => item.epoch === epoch && item.rootHex == epochBoundaryRoot);
+    const index = this.items.findIndex((item) => item.epoch === epoch && item.rootHex === epochBoundaryRoot);
     if (index === -1) {
       if (this.items.length === MAX_BALANCE_CACHE_SIZE) {
         this.items.shift();

@@ -78,6 +78,7 @@ async function maybeValidateBlobs(
     case BlockInputType.outOfRangeData:
       return {dataAvailabilityStatus: DataAvailabilityStatus.OutOfRange, availableBlockInput: blockInput};
 
+    // biome-ignore lint/suspicious/noFallthroughSwitchClause: We need fall-through behavior here
     case BlockInputType.availableData:
       if (opts.validBlobSidecars === BlobSidecarValidation.Full) {
         return {dataAvailabilityStatus: DataAvailabilityStatus.Available, availableBlockInput: blockInput};

@@ -31,7 +31,7 @@ export async function writeBlockInputToDb(this: BeaconChain, blocksInput: BlockI
 
     if (blockInput.type === BlockInputType.availableData || blockInput.type === BlockInputType.dataPromise) {
       const blobSidecars =
-        blockInput.type == BlockInputType.availableData
+        blockInput.type === BlockInputType.availableData
           ? blockInput.blockData.blobs
           : // At this point of import blobs are available and can be safely awaited
             (await blockInput.cachedData.availabilityPromise).blobs;

@@ -313,7 +313,8 @@ export class BlsMultiThreadWorkerPool implements IBlsVerifier {
       this.workers[0].status.code === WorkerStatusCode.initializationError &&
       this.workers.every((worker) => worker.status.code === WorkerStatusCode.initializationError)
     ) {
-      return job.reject(this.workers[0].status.error);
+      job.reject(this.workers[0].status.error);
+      return;
     }
 
     // Append batchable sets to `bufferedJobs`, starting a timeout to push them into `jobs`.

@@ -635,7 +635,7 @@ export class LightClientServer {
     if (
       attestedData.isFinalized &&
       finalizedHeaderAttested &&
-      computeSyncPeriodAtSlot(finalizedHeaderAttested.beacon.slot) == syncPeriod
+      computeSyncPeriodAtSlot(finalizedHeaderAttested.beacon.slot) === syncPeriod
     ) {
       isFinalized = true;
       finalityBranch = attestedData.finalityBranch;

@@ -13,7 +13,7 @@ const CHECKPOINT_FILE_NAME_LENGTH = 82;
 export class FileCPStateDatastore implements CPStateDatastore {
   private readonly folderPath: string;
 
-  constructor(parentDir: string = ".") {
+  constructor(parentDir = ".") {
     // by default use the beacon folder `/beacon/checkpoint_states`
     this.folderPath = path.join(parentDir, CHECKPOINT_STATES_FOLDER);
   }

@@ -65,8 +65,8 @@ export enum Bucket {
 
 export function getBucketNameByValue<T extends Bucket>(enumValue: T): keyof typeof Bucket {
   const keys = Object.keys(Bucket).filter((x) => {
-    if (isNaN(parseInt(x))) {
-      return Bucket[x as keyof typeof Bucket] == enumValue;
+    if (Number.isNaN(parseInt(x))) {
+      return Bucket[x as keyof typeof Bucket] === enumValue;
     } else {
       return false;
     }

@@ -105,7 +105,7 @@ export class BlockArchiveRepository extends Repository<Slot, SignedBeaconBlock>
   async *valuesStream(opts?: BlockFilterOptions): AsyncIterable<SignedBeaconBlock> {
     const firstSlot = this.getFirstSlot(opts);
     const valuesStream = super.valuesStream(opts);
-    const step = (opts && opts.step) ?? 1;
+    const step = opts?.step ?? 1;
 
     for await (const value of valuesStream) {
       if ((value.message.slot - firstSlot) % step === 0) {

@@ -21,6 +21,6 @@ export class Eth1DataCache {
 
   async getHighestCachedBlockNumber(): Promise<number | null> {
     const highestEth1Data = await this.db.eth1Data.lastValue();
-    return highestEth1Data && highestEth1Data.blockNumber;
+    return highestEth1Data?.blockNumber || null;
   }
 }
@@ -129,14 +129,14 @@ export class Eth1DepositsCache {
    */
   async getHighestDepositEventBlockNumber(): Promise<number | null> {
     const latestEvent = await this.db.depositEvent.lastValue();
-    return latestEvent && latestEvent.blockNumber;
+    return latestEvent?.blockNumber || null;
   }
 
   /**
    * Returns the lowest blockNumber stored in DB if any
    */
   async getLowestDepositEventBlockNumber(): Promise<number | null> {
     const firstEvent = await this.db.depositEvent.firstValue();
-    return firstEvent && firstEvent.blockNumber;
+    return firstEvent?.blockNumber || null;
   }
 }
@@ -193,7 +193,7 @@ export class Eth1MergeBlockTracker {
           // Persist found merge block here to affect both caller paths:
           // - internal searcher
           // - external caller if STOPPED
-          if (mergeBlock && this.status.code != StatusCode.FOUND) {
+          if (mergeBlock && this.status.code !== StatusCode.FOUND) {
             if (this.status.code === StatusCode.SEARCHING) {
               this.close();
             }

@@ -104,11 +104,11 @@ export class Eth1ForBlockProduction implements IEth1ForBlockProduction {
   }
 
   startPollingMergeBlock(): void {
-    return this.eth1MergeBlockTracker.startPollingMergeBlock();
+    this.eth1MergeBlockTracker.startPollingMergeBlock();
   }
 
   stopPollingEth1Data(): void {
-    return this.eth1DepositDataTracker?.stopPollingEth1Data();
+    this.eth1DepositDataTracker?.stopPollingEth1Data();
   }
 }
 

@@ -53,7 +53,7 @@ export function numToQuantity(num: number | bigint): QUANTITY {
  */
 export function quantityToNum(hex: QUANTITY, id = ""): number {
   const num = parseInt(hex, 16);
-  if (isNaN(num) || num < 0) throw Error(`Invalid hex decimal ${id} '${hex}'`);
+  if (Number.isNaN(num) || num < 0) throw Error(`Invalid hex decimal ${id} '${hex}'`);
   return num;
 }
 

@@ -121,7 +121,7 @@ export class Eth2Gossipsub extends GossipSub {
       // TODO: figure out a way to dynamically transition to the size
       dataTransform: new DataTransformSnappy(
         gossipTopicCache,
-        isFinite(config.BELLATRIX_FORK_EPOCH) ? GOSSIP_MAX_SIZE_BELLATRIX : GOSSIP_MAX_SIZE
+        Number.isFinite(config.BELLATRIX_FORK_EPOCH) ? GOSSIP_MAX_SIZE_BELLATRIX : GOSSIP_MAX_SIZE
       ),
       metricsRegister: metricsRegister as MetricsRegister | null,
       metricsTopicStrToLabel: metricsRegister