Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log as info instead of warn if builder does not provide a bid #7191

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix: log as info instead of warn if builder does not provide a bid #7191

merged 2 commits into from
Oct 22, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Oct 22, 2024 •
edited
Loading

Motivation

We previously had a really bad JSON parse error which created too much noise if builder didn't provide a bid but since the api client refactor we can handle this case properly but we still log it as a warn currently if builder does not provide a bid. While I think it's not as bad as it was, after further discussion and input in #6574 I think it's reasonable to just log it as info and create less noise (no stacktrace).

Description

Log as info instead of warn if builder does not provide a bid

Closes #6574

@nflaig nflaig requested a review from a team as a code owner October 22, 2024 13:53
wemeetagain
wemeetagain previously approved these changes Oct 22, 2024
View reviewed changes
@wemeetagain wemeetagain enabled auto-merge (squash) October 22, 2024 14:04
@wemeetagain wemeetagain merged commit fa969ca into unstable Oct 22, 2024
21 checks passed
@wemeetagain wemeetagain deleted the nflaig/no-bid-info branch October 22, 2024 14:41
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (0e4ea98) to head (1e510ff).
Report is 3 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #7191      +/-   ##
============================================
- Coverage     49.21%   49.21%   -0.01%     
============================================
  Files           598      598              
  Lines         39794    39794              
  Branches       2093     2087       -6     
============================================
- Hits          19584    19583       -1     
- Misses        20170    20171       +1     
  Partials         40       40

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 97239a7 Previous: 0e4ea98 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.5995 ms/op 2.0059 ms/op 1.30
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 66.264 us/op 52.802 us/op 1.25
BLS verify - blst 872.13 us/op 1.0596 ms/op 0.82
BLS verifyMultipleSignatures 3 - blst 1.3912 ms/op 1.5554 ms/op 0.89
BLS verifyMultipleSignatures 8 - blst 2.0749 ms/op 2.1669 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst 5.2241 ms/op 6.5700 ms/op 0.80
BLS verifyMultipleSignatures 64 - blst 10.138 ms/op 10.692 ms/op 0.95
BLS verifyMultipleSignatures 128 - blst 18.858 ms/op 16.812 ms/op 1.12
BLS deserializing 10000 signatures 794.81 ms/op 677.33 ms/op 1.17
BLS deserializing 100000 signatures 7.9055 s/op 6.8036 s/op 1.16
BLS verifyMultipleSignatures - same message - 3 - blst 983.16 us/op 1.1141 ms/op 0.88
BLS verifyMultipleSignatures - same message - 8 - blst 1.0864 ms/op 1.2213 ms/op 0.89
BLS verifyMultipleSignatures - same message - 32 - blst 1.7629 ms/op 1.9477 ms/op 0.91
BLS verifyMultipleSignatures - same message - 64 - blst 2.7638 ms/op 2.7373 ms/op 1.01
BLS verifyMultipleSignatures - same message - 128 - blst 4.6638 ms/op 4.2726 ms/op 1.09
BLS aggregatePubkeys 32 - blst 22.302 us/op 19.929 us/op 1.12
BLS aggregatePubkeys 128 - blst 79.911 us/op 69.957 us/op 1.14
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 74.016 ms/op 68.645 ms/op 1.08
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 60.850 ms/op 82.275 ms/op 0.74
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 66.015 ms/op 49.766 ms/op 1.33
getSlashingsAndExits - default max 118.94 us/op 99.023 us/op 1.20
getSlashingsAndExits - 2k 489.18 us/op 341.76 us/op 1.43
proposeBlockBody type=full, size=empty 9.1810 ms/op 7.0070 ms/op 1.31
isKnown best case - 1 super set check 813.00 ns/op 333.00 ns/op 2.44
isKnown normal case - 2 super set checks 861.00 ns/op 401.00 ns/op 2.15
isKnown worse case - 16 super set checks 919.00 ns/op 391.00 ns/op 2.35
InMemoryCheckpointStateCache - add get delete 4.8380 us/op 3.1950 us/op 1.51
updateUnfinalizedPubkeys - updating 10 pubkeys 1.5701 ms/op 1.4246 ms/op 1.10
updateUnfinalizedPubkeys - updating 100 pubkeys 7.0704 ms/op 3.6270 ms/op 1.95
updateUnfinalizedPubkeys - updating 1000 pubkeys 71.437 ms/op 62.567 ms/op 1.14
validate api signedAggregateAndProof - struct 1.7200 ms/op 2.9206 ms/op 0.59
validate gossip signedAggregateAndProof - struct 1.8458 ms/op 2.0658 ms/op 0.89
batch validate gossip attestation - vc 640000 - chunk 32 151.33 us/op 137.91 us/op 1.10
batch validate gossip attestation - vc 640000 - chunk 64 136.94 us/op 122.73 us/op 1.12
batch validate gossip attestation - vc 640000 - chunk 128 125.23 us/op 114.01 us/op 1.10
batch validate gossip attestation - vc 640000 - chunk 256 132.45 us/op 108.49 us/op 1.22
pickEth1Vote - no votes 1.2488 ms/op 1.0255 ms/op 1.22
pickEth1Vote - max votes 7.7191 ms/op 7.1150 ms/op 1.08
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.019 ms/op 15.159 ms/op 1.12
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 28.978 ms/op 22.728 ms/op 1.27
pickEth1Vote - Eth1Data fastSerialize value x2048 613.40 us/op 452.00 us/op 1.36
pickEth1Vote - Eth1Data fastSerialize tree x2048 3.6493 ms/op 4.0139 ms/op 0.91
bytes32 toHexString 578.00 ns/op 434.00 ns/op 1.33
bytes32 Buffer.toString(hex) 274.00 ns/op 250.00 ns/op 1.10
bytes32 Buffer.toString(hex) from Uint8Array 505.00 ns/op 362.00 ns/op 1.40
bytes32 Buffer.toString(hex) + 0x 291.00 ns/op 254.00 ns/op 1.15
Object access 1 prop 0.20400 ns/op 0.13300 ns/op 1.53
Map access 1 prop 0.15400 ns/op 0.13100 ns/op 1.18
Object get x1000 6.6910 ns/op 6.0210 ns/op 1.11
Map get x1000 7.6130 ns/op 6.3380 ns/op 1.20
Object set x1000 57.126 ns/op 33.319 ns/op 1.71
Map set x1000 44.389 ns/op 22.099 ns/op 2.01
Return object 10000 times 0.34370 ns/op 0.28680 ns/op 1.20
Throw Error 10000 times 3.9371 us/op 3.3022 us/op 1.19
toHex 206.66 ns/op 145.89 ns/op 1.42
Buffer.from 184.31 ns/op 148.93 ns/op 1.24
shared Buffer 114.93 ns/op 87.221 ns/op 1.32
fastMsgIdFn sha256 / 200 bytes 2.6290 us/op 2.1690 us/op 1.21
fastMsgIdFn h32 xxhash / 200 bytes 345.00 ns/op 231.00 ns/op 1.49
fastMsgIdFn h64 xxhash / 200 bytes 314.00 ns/op 265.00 ns/op 1.18
fastMsgIdFn sha256 / 1000 bytes 9.0180 us/op 7.2990 us/op 1.24
fastMsgIdFn h32 xxhash / 1000 bytes 494.00 ns/op 360.00 ns/op 1.37
fastMsgIdFn h64 xxhash / 1000 bytes 422.00 ns/op 334.00 ns/op 1.26
fastMsgIdFn sha256 / 10000 bytes 73.509 us/op 64.585 us/op 1.14
fastMsgIdFn h32 xxhash / 10000 bytes 2.1460 us/op 1.8310 us/op 1.17
fastMsgIdFn h64 xxhash / 10000 bytes 1.3710 us/op 1.2120 us/op 1.13
send data - 1000 256B messages 15.678 ms/op 13.121 ms/op 1.19
send data - 1000 512B messages 20.293 ms/op 16.463 ms/op 1.23
send data - 1000 1024B messages 29.147 ms/op 28.366 ms/op 1.03
send data - 1000 1200B messages 22.701 ms/op 27.838 ms/op 0.82
send data - 1000 2048B messages 35.305 ms/op 33.181 ms/op 1.06
send data - 1000 4096B messages 37.692 ms/op 31.330 ms/op 1.20
send data - 1000 16384B messages 80.528 ms/op 71.958 ms/op 1.12
send data - 1000 65536B messages 257.52 ms/op 221.19 ms/op 1.16
enrSubnets - fastDeserialize 64 bits 1.2530 us/op 1.0810 us/op 1.16
enrSubnets - ssz BitVector 64 bits 428.00 ns/op 348.00 ns/op 1.23
enrSubnets - fastDeserialize 4 bits 195.00 ns/op 142.00 ns/op 1.37
enrSubnets - ssz BitVector 4 bits 406.00 ns/op 352.00 ns/op 1.15
prioritizePeers score -10:0 att 32-0.1 sync 2-0 190.91 us/op 159.62 us/op 1.20
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 162.85 us/op 139.29 us/op 1.17
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 308.41 us/op 229.53 us/op 1.34
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 409.89 us/op 600.01 us/op 0.68
prioritizePeers score 0:0 att 64-1 sync 4-1 761.48 us/op 857.27 us/op 0.89
array of 16000 items push then shift 1.7811 us/op 1.6195 us/op 1.10
LinkedList of 16000 items push then shift 8.0460 ns/op 7.0970 ns/op 1.13
array of 16000 items push then pop 140.45 ns/op 114.10 ns/op 1.23
LinkedList of 16000 items push then pop 7.7750 ns/op 6.9250 ns/op 1.12
array of 24000 items push then shift 2.5720 us/op 2.3825 us/op 1.08
LinkedList of 24000 items push then shift 7.9060 ns/op 6.9990 ns/op 1.13
array of 24000 items push then pop 202.88 ns/op 135.84 ns/op 1.49
LinkedList of 24000 items push then pop 8.0360 ns/op 6.8360 ns/op 1.18
intersect bitArray bitLen 8 6.8130 ns/op 6.3530 ns/op 1.07
intersect array and set length 8 59.772 ns/op 46.517 ns/op 1.28
intersect bitArray bitLen 128 32.999 ns/op 29.311 ns/op 1.13
intersect array and set length 128 846.18 ns/op 671.89 ns/op 1.26
bitArray.getTrueBitIndexes() bitLen 128 2.1840 us/op 2.5700 us/op 0.85
bitArray.getTrueBitIndexes() bitLen 248 3.8190 us/op 3.7180 us/op 1.03
bitArray.getTrueBitIndexes() bitLen 512 8.4460 us/op 8.1740 us/op 1.03
Buffer.concat 32 items 1.0130 us/op 898.00 ns/op 1.13
Uint8Array.set 32 items 1.8240 us/op 1.3780 us/op 1.32
Buffer.copy 1.9480 us/op 1.6790 us/op 1.16
Uint8Array.set - with subarray 3.0930 us/op 2.6400 us/op 1.17
Uint8Array.set - without subarray 1.6590 us/op 1.4980 us/op 1.11
getUint32 - dataview 278.00 ns/op 248.00 ns/op 1.12
getUint32 - manual 247.00 ns/op 155.00 ns/op 1.59
Set add up to 64 items then delete first 2.9454 us/op 2.2287 us/op 1.32
OrderedSet add up to 64 items then delete first 4.7957 us/op 3.2775 us/op 1.46
Set add up to 64 items then delete last 3.4188 us/op 2.5198 us/op 1.36
OrderedSet add up to 64 items then delete last 4.9031 us/op 3.7371 us/op 1.31
Set add up to 64 items then delete middle 3.1934 us/op 2.5631 us/op 1.25
OrderedSet add up to 64 items then delete middle 6.5222 us/op 5.2585 us/op 1.24
Set add up to 128 items then delete first 6.5426 us/op 5.0662 us/op 1.29
OrderedSet add up to 128 items then delete first 10.440 us/op 7.9946 us/op 1.31
Set add up to 128 items then delete last 6.8409 us/op 4.9965 us/op 1.37
OrderedSet add up to 128 items then delete last 9.2150 us/op 7.3425 us/op 1.26
Set add up to 128 items then delete middle 6.0588 us/op 4.9084 us/op 1.23
OrderedSet add up to 128 items then delete middle 17.304 us/op 13.875 us/op 1.25
Set add up to 256 items then delete first 13.638 us/op 10.742 us/op 1.27
OrderedSet add up to 256 items then delete first 20.488 us/op 16.271 us/op 1.26
Set add up to 256 items then delete last 13.071 us/op 9.9144 us/op 1.32
OrderedSet add up to 256 items then delete last 18.061 us/op 14.786 us/op 1.22
Set add up to 256 items then delete middle 13.005 us/op 9.8693 us/op 1.32
OrderedSet add up to 256 items then delete middle 48.367 us/op 41.582 us/op 1.16
transfer serialized Status (84 B) 1.5090 us/op 1.3790 us/op 1.09
copy serialized Status (84 B) 1.2930 us/op 1.1390 us/op 1.14
transfer serialized SignedVoluntaryExit (112 B) 1.7200 us/op 1.4480 us/op 1.19
copy serialized SignedVoluntaryExit (112 B) 1.4310 us/op 1.1630 us/op 1.23
transfer serialized ProposerSlashing (416 B) 1.8160 us/op 1.5040 us/op 1.21
copy serialized ProposerSlashing (416 B) 1.7430 us/op 1.4370 us/op 1.21
transfer serialized Attestation (485 B) 1.7000 us/op 1.6060 us/op 1.06
copy serialized Attestation (485 B) 1.6200 us/op 1.4530 us/op 1.11
transfer serialized AttesterSlashing (33232 B) 1.8690 us/op 1.8320 us/op 1.02
copy serialized AttesterSlashing (33232 B) 4.9810 us/op 4.6940 us/op 1.06
transfer serialized Small SignedBeaconBlock (128000 B) 2.6920 us/op 2.5760 us/op 1.05
copy serialized Small SignedBeaconBlock (128000 B) 16.487 us/op 15.471 us/op 1.07
transfer serialized Avg SignedBeaconBlock (200000 B) 3.3100 us/op 3.1770 us/op 1.04
copy serialized Avg SignedBeaconBlock (200000 B) 26.740 us/op 23.055 us/op 1.16
transfer serialized BlobsSidecar (524380 B) 3.7190 us/op 2.7930 us/op 1.33
copy serialized BlobsSidecar (524380 B) 83.191 us/op 87.570 us/op 0.95
transfer serialized Big SignedBeaconBlock (1000000 B) 4.0240 us/op 2.7740 us/op 1.45
copy serialized Big SignedBeaconBlock (1000000 B) 185.27 us/op 146.23 us/op 1.27
pass gossip attestations to forkchoice per slot 3.0883 ms/op 2.8189 ms/op 1.10
forkChoice updateHead vc 100000 bc 64 eq 0 529.68 us/op 494.87 us/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 0 4.2696 ms/op 2.7596 ms/op 1.55
forkChoice updateHead vc 1000000 bc 64 eq 0 5.7248 ms/op 6.2508 ms/op 0.92
forkChoice updateHead vc 600000 bc 320 eq 0 3.1465 ms/op 2.7565 ms/op 1.14
forkChoice updateHead vc 600000 bc 1200 eq 0 3.1830 ms/op 2.8289 ms/op 1.13
forkChoice updateHead vc 600000 bc 7200 eq 0 4.4947 ms/op 3.5496 ms/op 1.27
forkChoice updateHead vc 600000 bc 64 eq 1000 10.562 ms/op 10.159 ms/op 1.04
forkChoice updateHead vc 600000 bc 64 eq 10000 11.669 ms/op 10.276 ms/op 1.14
forkChoice updateHead vc 600000 bc 64 eq 300000 14.542 ms/op 13.353 ms/op 1.09
computeDeltas 500000 validators 300 proto nodes 4.2923 ms/op 4.0134 ms/op 1.07
computeDeltas 500000 validators 1200 proto nodes 4.3824 ms/op 4.0557 ms/op 1.08
computeDeltas 500000 validators 7200 proto nodes 4.4881 ms/op 3.9924 ms/op 1.12
computeDeltas 750000 validators 300 proto nodes 6.9376 ms/op 5.9964 ms/op 1.16
computeDeltas 750000 validators 1200 proto nodes 6.7208 ms/op 5.9374 ms/op 1.13
computeDeltas 750000 validators 7200 proto nodes 6.8108 ms/op 6.0071 ms/op 1.13
computeDeltas 1400000 validators 300 proto nodes 12.145 ms/op 11.315 ms/op 1.07
computeDeltas 1400000 validators 1200 proto nodes 12.020 ms/op 11.231 ms/op 1.07
computeDeltas 1400000 validators 7200 proto nodes 12.606 ms/op 11.052 ms/op 1.14
computeDeltas 2100000 validators 300 proto nodes 19.145 ms/op 17.513 ms/op 1.09
computeDeltas 2100000 validators 1200 proto nodes 19.344 ms/op 17.427 ms/op 1.11
computeDeltas 2100000 validators 7200 proto nodes 20.828 ms/op 17.349 ms/op 1.20
altair processAttestation - 250000 vs - 7PWei normalcase 2.1796 ms/op 1.7914 ms/op 1.22
altair processAttestation - 250000 vs - 7PWei worstcase 3.4942 ms/op 2.6506 ms/op 1.32
altair processAttestation - setStatus - 1/6 committees join 121.42 us/op 119.07 us/op 1.02
altair processAttestation - setStatus - 1/3 committees join 229.94 us/op 314.41 us/op 0.73
altair processAttestation - setStatus - 1/2 committees join 301.30 us/op 647.38 us/op 0.47
altair processAttestation - setStatus - 2/3 committees join 388.26 us/op 409.69 us/op 0.95
altair processAttestation - setStatus - 4/5 committees join 648.03 us/op 578.15 us/op 1.12
altair processAttestation - setStatus - 100% committees join 707.54 us/op 656.51 us/op 1.08
altair processBlock - 250000 vs - 7PWei normalcase 7.6112 ms/op 5.7935 ms/op 1.31
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.461 ms/op 28.395 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase 37.161 ms/op 42.061 ms/op 0.88
altair processBlock - 250000 vs - 7PWei worstcase hashState 75.891 ms/op 82.579 ms/op 0.92
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9991 ms/op 2.2153 ms/op 0.90
phase0 processBlock - 250000 vs - 7PWei worstcase 22.793 ms/op 27.230 ms/op 0.84
altair processEth1Data - 250000 vs - 7PWei normalcase 412.51 us/op 325.79 us/op 1.27
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 6.3250 us/op 11.211 us/op 0.56
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 34.083 us/op 44.406 us/op 0.77
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 9.8440 us/op 13.624 us/op 0.72
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.2660 us/op 8.8280 us/op 0.71
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 146.91 us/op 188.31 us/op 0.78
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.2069 ms/op 2.0246 ms/op 0.60
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.6422 ms/op 1.4585 ms/op 1.13
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.7026 ms/op 2.8397 ms/op 0.60
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.3382 ms/op 3.4683 ms/op 1.25
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.8609 ms/op 2.2159 ms/op 0.84
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.0426 ms/op 3.5533 ms/op 1.14
Tree 40 250000 create 296.03 ms/op 217.81 ms/op 1.36
Tree 40 250000 get(125000) 180.71 ns/op 143.42 ns/op 1.26
Tree 40 250000 set(125000) 979.68 ns/op 588.05 ns/op 1.67
Tree 40 250000 toArray() 22.101 ms/op 14.802 ms/op 1.49
Tree 40 250000 iterate all - toArray() + loop 22.378 ms/op 15.171 ms/op 1.48
Tree 40 250000 iterate all - get(i) 64.606 ms/op 47.480 ms/op 1.36
Array 250000 create 3.6490 ms/op 2.8945 ms/op 1.26
Array 250000 clone - spread 1.5319 ms/op 1.3508 ms/op 1.13
Array 250000 get(125000) 0.46400 ns/op 0.42500 ns/op 1.09
Array 250000 set(125000) 0.48400 ns/op 0.43600 ns/op 1.11
Array 250000 iterate all - loop 99.586 us/op 95.755 us/op 1.04
phase0 afterProcessEpoch - 250000 vs - 7PWei 58.725 ms/op 49.622 ms/op 1.18
Array.fill - length 1000000 3.8238 ms/op 3.4872 ms/op 1.10
Array push - length 1000000 17.317 ms/op 16.828 ms/op 1.03
Array.get 0.30721 ns/op 0.27044 ns/op 1.14
Uint8Array.get 0.48025 ns/op 0.43505 ns/op 1.10
phase0 beforeProcessEpoch - 250000 vs - 7PWei 23.502 ms/op 17.839 ms/op 1.32
altair processEpoch - mainnet_e81889 381.23 ms/op 297.97 ms/op 1.28
mainnet_e81889 - altair beforeProcessEpoch 25.606 ms/op 18.335 ms/op 1.40
mainnet_e81889 - altair processJustificationAndFinalization 20.768 us/op 19.988 us/op 1.04
mainnet_e81889 - altair processInactivityUpdates 7.6517 ms/op 5.0530 ms/op 1.51
mainnet_e81889 - altair processRewardsAndPenalties 41.782 ms/op 64.222 ms/op 0.65
mainnet_e81889 - altair processRegistryUpdates 2.4420 us/op 2.9400 us/op 0.83
mainnet_e81889 - altair processSlashings 716.00 ns/op 659.00 ns/op 1.09
mainnet_e81889 - altair processEth1DataReset 442.00 ns/op 513.00 ns/op 0.86
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9827 ms/op 1.9235 ms/op 1.03
mainnet_e81889 - altair processSlashingsReset 7.6320 us/op 6.8690 us/op 1.11
mainnet_e81889 - altair processRandaoMixesReset 11.539 us/op 7.4850 us/op 1.54
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0070 us/op 911.00 ns/op 1.11
mainnet_e81889 - altair processParticipationFlagUpdates 4.7950 us/op 3.7520 us/op 1.28
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0610 us/op 722.00 ns/op 1.47
mainnet_e81889 - altair afterProcessEpoch 60.103 ms/op 50.620 ms/op 1.19
capella processEpoch - mainnet_e217614 1.4760 s/op 1.1344 s/op 1.30
mainnet_e217614 - capella beforeProcessEpoch 101.31 ms/op 61.019 ms/op 1.66
mainnet_e217614 - capella processJustificationAndFinalization 25.246 us/op 22.511 us/op 1.12
mainnet_e217614 - capella processInactivityUpdates 24.378 ms/op 15.967 ms/op 1.53
mainnet_e217614 - capella processRewardsAndPenalties 278.71 ms/op 270.00 ms/op 1.03
mainnet_e217614 - capella processRegistryUpdates 16.257 us/op 19.918 us/op 0.82
mainnet_e217614 - capella processSlashings 613.00 ns/op 732.00 ns/op 0.84
mainnet_e217614 - capella processEth1DataReset 708.00 ns/op 611.00 ns/op 1.16
mainnet_e217614 - capella processEffectiveBalanceUpdates 15.820 ms/op 5.6653 ms/op 2.79
mainnet_e217614 - capella processSlashingsReset 4.4460 us/op 4.5450 us/op 0.98
mainnet_e217614 - capella processRandaoMixesReset 5.3410 us/op 6.6060 us/op 0.81
mainnet_e217614 - capella processHistoricalRootsUpdate 740.00 ns/op 850.00 ns/op 0.87
mainnet_e217614 - capella processParticipationFlagUpdates 2.9180 us/op 2.9460 us/op 0.99
mainnet_e217614 - capella afterProcessEpoch 144.38 ms/op 120.15 ms/op 1.20
phase0 processEpoch - mainnet_e58758 392.82 ms/op 363.92 ms/op 1.08
mainnet_e58758 - phase0 beforeProcessEpoch 127.19 ms/op 83.096 ms/op 1.53
mainnet_e58758 - phase0 processJustificationAndFinalization 19.976 us/op 23.684 us/op 0.84
mainnet_e58758 - phase0 processRewardsAndPenalties 36.414 ms/op 47.389 ms/op 0.77
mainnet_e58758 - phase0 processRegistryUpdates 10.756 us/op 12.281 us/op 0.88
mainnet_e58758 - phase0 processSlashings 622.00 ns/op 676.00 ns/op 0.92
mainnet_e58758 - phase0 processEth1DataReset 613.00 ns/op 527.00 ns/op 1.16
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3282 ms/op 2.0810 ms/op 0.64
mainnet_e58758 - phase0 processSlashingsReset 4.7800 us/op 5.1410 us/op 0.93
mainnet_e58758 - phase0 processRandaoMixesReset 6.9820 us/op 6.3750 us/op 1.10
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0570 us/op 531.00 ns/op 1.99
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.8390 us/op 4.6800 us/op 1.03
mainnet_e58758 - phase0 afterProcessEpoch 51.038 ms/op 42.539 ms/op 1.20
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.1277 ms/op 3.3776 ms/op 0.63
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.7073 ms/op 2.3472 ms/op 1.15
altair processInactivityUpdates - 250000 normalcase 22.542 ms/op 23.162 ms/op 0.97
altair processInactivityUpdates - 250000 worstcase 18.471 ms/op 24.159 ms/op 0.76
phase0 processRegistryUpdates - 250000 normalcase 13.426 us/op 10.383 us/op 1.29
phase0 processRegistryUpdates - 250000 badcase_full_deposits 443.86 us/op 460.18 us/op 0.96
phase0 processRegistryUpdates - 250000 worstcase 0.5 156.86 ms/op 139.75 ms/op 1.12
altair processRewardsAndPenalties - 250000 normalcase 52.409 ms/op 51.788 ms/op 1.01
altair processRewardsAndPenalties - 250000 worstcase 49.941 ms/op 48.848 ms/op 1.02
phase0 getAttestationDeltas - 250000 normalcase 12.556 ms/op 7.7934 ms/op 1.61
phase0 getAttestationDeltas - 250000 worstcase 9.1341 ms/op 7.2403 ms/op 1.26
phase0 processSlashings - 250000 worstcase 106.14 us/op 126.00 us/op 0.84
altair processSyncCommitteeUpdates - 250000 158.03 ms/op 115.66 ms/op 1.37
BeaconState.hashTreeRoot - No change 428.00 ns/op 251.00 ns/op 1.71
BeaconState.hashTreeRoot - 1 full validator 121.42 us/op 146.89 us/op 0.83
BeaconState.hashTreeRoot - 32 full validator 1.4584 ms/op 1.5020 ms/op 0.97
BeaconState.hashTreeRoot - 512 full validator 13.388 ms/op 13.068 ms/op 1.02
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 152.62 us/op 187.56 us/op 0.81
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.1416 ms/op 1.6186 ms/op 1.32
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 27.158 ms/op 23.598 ms/op 1.15
BeaconState.hashTreeRoot - 1 balances 123.63 us/op 116.84 us/op 1.06
BeaconState.hashTreeRoot - 32 balances 1.0856 ms/op 1.1942 ms/op 0.91
BeaconState.hashTreeRoot - 512 balances 10.323 ms/op 9.2271 ms/op 1.12
BeaconState.hashTreeRoot - 250000 balances 198.17 ms/op 202.80 ms/op 0.98
aggregationBits - 2048 els - zipIndexesInBitList 41.292 us/op 23.327 us/op 1.77
byteArrayEquals 32 61.968 ns/op 53.052 ns/op 1.17
Buffer.compare 32 20.362 ns/op 17.554 ns/op 1.16
byteArrayEquals 1024 1.9670 us/op 1.5679 us/op 1.25
Buffer.compare 1024 31.373 ns/op 26.176 ns/op 1.20
byteArrayEquals 16384 29.962 us/op 24.974 us/op 1.20
Buffer.compare 16384 216.06 ns/op 199.88 ns/op 1.08
byteArrayEquals 123687377 228.96 ms/op 187.99 ms/op 1.22
Buffer.compare 123687377 11.270 ms/op 6.1809 ms/op 1.82
byteArrayEquals 32 - diff last byte 60.612 ns/op 51.299 ns/op 1.18
Buffer.compare 32 - diff last byte 19.506 ns/op 17.332 ns/op 1.13
byteArrayEquals 1024 - diff last byte 1.7792 us/op 1.5502 us/op 1.15
Buffer.compare 1024 - diff last byte 29.219 ns/op 26.672 ns/op 1.10
byteArrayEquals 16384 - diff last byte 29.316 us/op 24.672 us/op 1.19
Buffer.compare 16384 - diff last byte 236.94 ns/op 199.16 ns/op 1.19
byteArrayEquals 123687377 - diff last byte 228.47 ms/op 187.82 ms/op 1.22
Buffer.compare 123687377 - diff last byte 11.781 ms/op 6.7051 ms/op 1.76
byteArrayEquals 32 - random bytes 5.7180 ns/op 5.1590 ns/op 1.11
Buffer.compare 32 - random bytes 19.619 ns/op 18.071 ns/op 1.09
byteArrayEquals 1024 - random bytes 6.0120 ns/op 5.1550 ns/op 1.17
Buffer.compare 1024 - random bytes 20.085 ns/op 17.869 ns/op 1.12
byteArrayEquals 16384 - random bytes 6.2230 ns/op 5.0950 ns/op 1.22
Buffer.compare 16384 - random bytes 27.374 ns/op 18.745 ns/op 1.46
byteArrayEquals 123687377 - random bytes 7.8500 ns/op 6.4100 ns/op 1.22
Buffer.compare 123687377 - random bytes 21.950 ns/op 18.860 ns/op 1.16
regular array get 100000 times 52.664 us/op 32.559 us/op 1.62
wrappedArray get 100000 times 39.284 us/op 32.445 us/op 1.21
arrayWithProxy get 100000 times 16.138 ms/op 14.220 ms/op 1.13
ssz.Root.equals 55.941 ns/op 45.424 ns/op 1.23
byteArrayEquals 53.248 ns/op 44.491 ns/op 1.20
Buffer.compare 12.533 ns/op 10.171 ns/op 1.23
processSlot - 1 slots 16.129 us/op 11.831 us/op 1.36
processSlot - 32 slots 2.9317 ms/op 2.7696 ms/op 1.06
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 39.405 ms/op 39.277 ms/op 1.00
getCommitteeAssignments - req 1 vs - 250000 vc 2.3418 ms/op 2.1123 ms/op 1.11
getCommitteeAssignments - req 100 vs - 250000 vc 4.3447 ms/op 4.1146 ms/op 1.06
getCommitteeAssignments - req 1000 vs - 250000 vc 5.1904 ms/op 4.4277 ms/op 1.17
findModifiedValidators - 10000 modified validators 371.76 ms/op 261.94 ms/op 1.42
findModifiedValidators - 1000 modified validators 290.40 ms/op 159.60 ms/op 1.82
findModifiedValidators - 100 modified validators 235.11 ms/op 152.11 ms/op 1.55
findModifiedValidators - 10 modified validators 191.83 ms/op 156.31 ms/op 1.23
findModifiedValidators - 1 modified validators 217.64 ms/op 143.64 ms/op 1.52
findModifiedValidators - no difference 239.37 ms/op 150.84 ms/op 1.59
compare ViewDUs 3.8702 s/op 3.1957 s/op 1.21
compare each validator Uint8Array 1.5487 s/op 928.71 ms/op 1.67
compare ViewDU to Uint8Array 1.4226 s/op 1.0545 s/op 1.35
migrate state 1000000 validators, 24 modified, 0 new 805.30 ms/op 655.26 ms/op 1.23
migrate state 1000000 validators, 1700 modified, 1000 new 1.0519 s/op 982.23 ms/op 1.07
migrate state 1000000 validators, 3400 modified, 2000 new 1.3462 s/op 1.1929 s/op 1.13
migrate state 1500000 validators, 24 modified, 0 new 902.22 ms/op 773.48 ms/op 1.17
migrate state 1500000 validators, 1700 modified, 1000 new 1.2235 s/op 996.45 ms/op 1.23
migrate state 1500000 validators, 3400 modified, 2000 new 1.3629 s/op 1.2524 s/op 1.09
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.1700 ns/op 4.0300 ns/op 1.53
state getBlockRootAtSlot - 250000 vs - 7PWei 923.82 ns/op 816.48 ns/op 1.13
computeProposers - vc 250000 10.785 ms/op 6.3398 ms/op 1.70
computeEpochShuffling - vc 250000 51.741 ms/op 39.817 ms/op 1.30
getNextSyncCommittee - vc 250000 168.61 ms/op 123.20 ms/op 1.37
computeSigningRoot for AttestationData 26.309 us/op 27.111 us/op 0.97
hash AttestationData serialized data then Buffer.toString(base64) 1.8865 us/op 1.5294 us/op 1.23
toHexString serialized data 1.2941 us/op 862.93 ns/op 1.50
Buffer.toString(base64) 214.29 ns/op 183.56 ns/op 1.17
nodejs block root to RootHex using toHex 212.54 ns/op 158.96 ns/op 1.34
nodejs block root to RootHex using toRootHex 115.33 ns/op 95.524 ns/op 1.21
browser block root to RootHex using the deprecated toHexString 350.35 ns/op 233.49 ns/op 1.50
browser block root to RootHex using toHex 254.49 ns/op 177.86 ns/op 1.43
browser block root to RootHex using toRootHex 194.64 ns/op 158.27 ns/op 1.23

by benchmarkbot/action

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.23.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning log when builder does not return a payload
2 participants
@nflaig @wemeetagain