-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reuse setup and build action in sim merge tests #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7345 +/- ##
=========================================
Coverage 48.76% 48.76%
=========================================
Files 601 601
Lines 40243 40243
Branches 2067 2067
=========================================
Hits 19626 19626
Misses 20579 20579
Partials 38 38 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
nazarhussain
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sim merge tests are broken https://github.com/ChainSafe/lodestar/actions/runs/12677099857/job/35331680453#step:11:230
Description
This reuses the setup and build action in sim merge tests, I am actually not sure why this fixes the issue somehow related to how we restore dependencies or that's my assumption at least.
The root cause of this is that ubuntu 22 might not have
GLIBCXX_3.4.32
which I also encountered on my local system but only when running the binary, seems related to the node version, likely due to openssl bump on nodejs sideother fix would be to update system dependencies manually
as suggested here