-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: chain.nHistoricalStatesFileDataStore #7551
base: unstable
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7551 +/- ##
============================================
- Coverage 50.15% 50.13% -0.03%
============================================
Files 603 603
Lines 40454 40472 +18
Branches 2231 2230 -1
============================================
- Hits 20291 20290 -1
- Misses 20123 20142 +19
Partials 40 40 🚀 New features to boost your workflow:
|
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs spec test changes, test/spec/presets/fork_choice.test.ts:91:23
Motivation
chain.nHistoricalStatesFileDataStore: true
does not work in docker. This PR fixes it.Description