-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support capella fork on simpleserialize.com #321
Conversation
|
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I am hoping you were able to validate the website locally
@g11tech yes was able to verify it works and looks correct locally, something I noticed during testing is that there is no error shown when trying to serialize/deserialize invalid data, it only logs an error to the console. This is also the case on the live website (https://simpleserialize.com/). For example:
Maybe catch the error and show a simple browser alert? |
I just ran
any ideas? might be due to changes done in #318 |
yes very likely, i think you will need to update ssz version in lodestar first since its originating from lodestar types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build issues because of ssz exports refac
I created a separate issue #324 as this also fails on master branch so I don't think it is isolated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be building fine locally after clearing old cached node modules
Motivation
Closes #320
Description
capella
fork types@lodestar/types
package instead of@chainsafe/lodestar-types
capella
as default fork instead ofphase0