Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support optional output arrays for getAll() apis #383

Merged
merged 1 commit into from
Jul 15, 2024
Merged

feat: support optional output arrays for getAll() apis #383

merged 1 commit into from
Jul 15, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jul 15, 2024 •
edited
Loading

Motivation

  • In some state transition flows of lodestar, the returned value of getAll() or getAllReadonly() or getAllReadonValues() are just temporary objects, we can preallocate them at the file level and reuse to save gc time

Description

@github-actions github-actions bot added the ssz label Jul 15, 2024
@twoeths twoeths marked this pull request as ready for review July 15, 2024 10:19
@twoeths twoeths requested a review from a team as a code owner July 15, 2024 10:19
@twoeths
Copy link
Contributor Author

twoeths commented Jul 15, 2024

got lower gc rate

Screenshot 2024-07-15 at 17 20 32

Prepare Next Epoch is likely 150ms - 300ms less on holesky

Screenshot 2024-07-15 at 17 21 11

@twoeths twoeths merged commit bfe89f6 into te/batch_hash_tree_root Jul 15, 2024
9 checks passed
@twoeths twoeths deleted the te/get_all_apis branch July 15, 2024 10:21
twoeths added a commit that referenced this pull request Jul 16, 2024
@twoeths
feat: support optional output arrays for getAll() apis (#383)
4873a66
@twoeths twoeths mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ssz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twoeths