Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Save changes button enabled despite no changes being made #1176

Closed
asnaith opened this issue Jun 22, 2021 · 0 comments · Fixed by #1178
Closed

Settings: Save changes button enabled despite no changes being made #1176

asnaith opened this issue Jun 22, 2021 · 0 comments · Fixed by #1178
Assignees
@Tbaut
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs.

Comments

@asnaith
Copy link
Contributor

asnaith commented Jun 22, 2021 •
edited
Loading

Describe the bug
User can click the save changes button on the profile tab when no changes are made

To Reproduce
Steps to reproduce the behavior:

  1. Login to files
  2. Navigate to settings
  3. Click the "save changes" button without making any changes

Observed behavior
You can repeatedly click the save changes button even though there are no changes to save

Expected behavior
The button should only be enabled when there are changes to save

Screenshot
Screen Shot 2021-06-22 at 10 43 54 AM

Desktop (please complete the following information):

OS: macOS
Browser: Chrome
Version : 91

Additional context
Happening on dev and current production release
@asnaith asnaith added the Issue: Bug 🐛 Added to issues relating to a critical severity bugs. label Jun 22, 2021
@Tbaut Tbaut self-assigned this Jun 23, 2021
@Tbaut Tbaut mentioned this issue Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tbaut Tbaut

Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disabled button in settings when no change made ChainSafe/ui-monorepo
2 participants
@asnaith @Tbaut