Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled button in settings when no change made #1178

Merged
merged 5 commits into from
Jun 24, 2021
Merged

Disabled button in settings when no change made #1178

merged 5 commits into from
Jun 24, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jun 23, 2021

closes #1176

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Jun 23, 2021
@render
Copy link

render bot commented Jun 23, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1178.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c39hujaa9d8odklajdbg.

@render
Copy link

render bot commented Jun 23, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1178.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c39hujqa9d8odklajds0.

@Tbaut Tbaut changed the title Disabled button in settings Disabled button in settings when no change made Jun 23, 2021
@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jun 23, 2021
tanmoyAtb
tanmoyAtb approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formik.dirty thing is awesome!

RyRy79261
RyRy79261 approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@RyRy79261 RyRy79261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a lint issue

packages/files-ui/src/Components/Modules/Settings/Profile.tsx Outdated Show resolved Hide resolved
@Tbaut Tbaut enabled auto-merge (squash) June 24, 2021 09:15
@Tbaut Tbaut merged commit d19e0c6 into dev Jun 24, 2021
@Tbaut Tbaut deleted the fix/tbaut-disabled-setting-button branch June 24, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@asnaith asnaith Awaiting requested review from asnaith

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings: Save changes button enabled despite no changes being made
3 participants
@Tbaut @RyRy79261 @tanmoyAtb