Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular progress bar doesn't reflect the real progress #1904

Closed
Tbaut opened this issue Feb 1, 2022 · 1 comment · Fixed by #1963
Closed

Circular progress bar doesn't reflect the real progress #1904

Tbaut opened this issue Feb 1, 2022 · 1 comment · Fixed by #1963
Assignees
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Priority: P3 Low Added to issues relating to a low severity bugs. Product: Files

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Feb 1, 2022

It's somewhat a nit, but it annoyed me enough to log it :D

If you play with the Circular progress on Storybook, and set the progress to 40 (click 3 times on "add 10"), it'll look like 50%, e.g
image

This is 50% (clicking 4 times on add 10)
image

I figured this is directly related to the width, here's the same 40%, and 50% with a 100px width - it's looking good:
image
image

I tried to dig a bit, but couldn't figure out quickly enough.

Either one of you has an idea, or we can forget about it for now.

@Tbaut Tbaut added Priority: P3 Low Added to issues relating to a low severity bugs. Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files labels Feb 1, 2022
@FSM1
Copy link
Contributor

FSM1 commented Feb 7, 2022

ahhh I also noticed this the last time I was working with the circular progress bar. Will do a bit more digging

@tanmoyAtb tanmoyAtb self-assigned this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Priority: P3 Low Added to issues relating to a low severity bugs. Product: Files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants