Circular progress bar fix. #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-1963.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c89sb3fh8vl18jmuob6g. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-1963.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c89sb3vh8vl18jmuobb0. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1963.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c89sb4nh8vl18jmuobng. |
github-actions
bot
added
the
Type: Bug Fix
…y-cirular-progress-1904
Tbaut
approved these changes
Feb 22, 2022
|
I must admit I hadn't previously set a timer and then checked to see if 25% was actually 25% etc...but I did now 😄
Really nice find and fix 🔥 |
asnaith
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1904
The basic problem was adjustment due the progress stroke width.
See the storybooks too check.
Submission checklist:
Layout
Theme