Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sharing design #1908

Closed
Tbaut opened this issue Feb 2, 2022 · 1 comment · Fixed by #1927
Closed

New Sharing design #1908

Tbaut opened this issue Feb 2, 2022 · 1 comment · Fixed by #1927
Assignees

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Feb 2, 2022

From a user on Discord

Here, after sharing... how I can close this window? There is no CLOSE (X button), clicking out of window space also does not working.

We should change this, this means:

  • change the sharing component (used when creating a shared folder, or sharing an existing one)
  • ditch the current input with ENS etc, and use a single one, see design below
  • ditch the double modal, and have only one set of buttons at the bottom

image

@tanmoyAtb tanmoyAtb self-assigned this Feb 3, 2022
@tanmoyAtb tanmoyAtb mentioned this issue Feb 8, 2022
4 tasks
@Tbaut
Copy link
Collaborator Author

Tbaut commented Feb 9, 2022

A comment for you @serenaho, I realized while playing with the implementation, that the "Generate link" button is unlike any other button in our interface. In fact, while playing with it, only the copy suggest that it does something, but it looks like a normal text, could we make it a little more "button-like", or have it underlined maybe?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants