-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sharing design #1927
New sharing design #1927
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1927.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c81ch0c41lsbk9445ieg. |
Your Render PR Server URL is https://storage-ui-stage-pr-1927.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c81ch1441lsbk9445j00. |
Your Render PR Server URL is https://chainsafe-components-stage-pr-1927.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c81ch1s41lsbk9445jcg. |
Can you check the tests @tanmoyAtb Link and file sharing are legitimately failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice and working very well. I left a couple comments, the CreateOrManage...
file is slowly getting out of hands with 650+ lines of codes. I wish we could some code to components (like each user line) to some lower-level component, passing around some props. This could be left for a refactoring later on. I see a lot of reader and writer specific code, although we could have somewhat generic functions handling both. and reducing a little the JSX, as it's barely readable (and don't get me wrong, it was already in a bad shape, this PR is not the 100% guilty one).
In any case, beside my comments below, we can leave that for a later refactoring.
packages/files-ui/src/Components/Modules/FileBrowsers/LinkSharing/SharingLink.tsx
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrManageSharedFolder.tsx
Outdated
Show resolved
Hide resolved
…ManageSharedFolder.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
I agree with all of the points, I felt the file getting out of hand as well. I have some refactoring in mind that I'll add in this PR. The readers and writers part is something we had before, I'll see about merging them as well. Checking on the tests as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @tanmoyAtb 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @tanmoyAtb! Nice test fixes too @FSM1 👍
I made some minor suggestions but mainly requested a change to put loginData
back to how it was before.
packages/files-ui/cypress/support/page-objects/modals/createSharedFolderModal.ts
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/Sharing/LinkList.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/Sharing/PermissionsDropdown.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/Sharing/PermissionsDropdown.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor, thanks a lot!
there are just some small nits found by Andrew, and we can merge 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Merging this one right away to see if creates conflicts with others
closes #1908
Submission checklist:
Layout
Theme